From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0D49ECAAD8 for ; Thu, 22 Sep 2022 02:42:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E67884BD1; Thu, 22 Sep 2022 04:42:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663814577; bh=uV6Uh9Hy12s3RRPbb7jgvUkZQgn6eBlsHHvMR5P6Z+4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dNiAsQiksXNrjsQf41mXQUAVlw4HMt7b5biJnU+AQDiidUiXXxXz2ES1tPrEF2j7t mqAE00OHpIqhRPyGXUnpLcQoONbG4jO5OEavIWcai3mC2Uf0QsmJhCmAIovDUN4GsI Gi7s1OrTlS/ePSpEMGu39z+YA1g6vFIWgE7OdSfTtyQ4INnirRD2Tlx8VNI9iYcA9W 4LjUfRKYxppFALHF0B3zuLVhbu3jCJaaVuGBbtJbgWVLWfAfsX4uFeL3NhjeMXMuDB XvDHGbsnr0lSfAWoMdt0d/b+micPJ91qqhrWC9f+bF9LBqD4fKY8Dh9oYUBYjPp/ec GA7nGgxKRulEA== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1402384BAC; Thu, 22 Sep 2022 04:42:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663814575; bh=uV6Uh9Hy12s3RRPbb7jgvUkZQgn6eBlsHHvMR5P6Z+4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hC3hbFc63gWMz36vE2JWP8f91vOq2Ps6OBJ0ejcGafN1WUC4/trkYhgMKoT0O2pSi DfAfL6MqeVAumKGOp7R7lbW6RFbpc8oUNaGReEsA+Os4tT5jgh8uQMF2wgUv2KSl9q 6k4mAk9iw21/xzklcQJ1tnQWQLz+gzKn7T1OIg360Uco3O3s9aiV7e/u2Nap8hpaOQ yxdVOjvWLJAqd2RbZAqCNj2UwHK5M+48woFwUd3pyr59WhwmPiHElqtUSevEq+0LdD iPZRD5dMCQTLCNLAGWH5JYm3udTiprHqW97lsurTQM4ZQevA5yblf0/SkOMJ7ZxuZL odh/BF0HA+p2w== Message-ID: <5f0288f7-6e24-08af-cb30-1e031b6c5a2f@denx.de> Date: Thu, 22 Sep 2022 04:42:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 4/4] ARM: dts: imx8m: imx8mm-mx8menlo: Enable SPL SDP support Content-Language: en-US To: Peng Fan , u-boot@lists.denx.de Cc: Fabio Estevam , Marcel Ziswiler , Max Krummenacher , Peng Fan , Stefano Babic References: <20220919194118.105820-1-marex@denx.de> <20220919194118.105820-4-marex@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/21/22 07:30, Peng Fan wrote: [...] >> @@ -50,6 +50,9 @@ CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y >>   CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x300 >>   CONFIG_SPL_I2C=y >>   CONFIG_SPL_POWER=y >> +CONFIG_SPL_USB_HOST=y > > Nitpick, would this option required? Sadly, yes, that's all the common EHCI bits also needed by the UDC. > Otherwise looks good to me, > > Reviewed-by: Peng Fan [...]