From: Pratyush Anand <panand@redhat.com>
To: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>,
"bhe@redhat.com" <bhe@redhat.com>
Cc: "dyoung@redhat.com" <dyoung@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [Makedumpfile Patch v3 7/7] mem-usage: allow to work only with -f for kernel version < 4.11
Date: Fri, 3 Mar 2017 10:26:12 +0530 [thread overview]
Message-ID: <5f10b643-bc47-e4a4-bd3d-7f0c7b8adf68@redhat.com> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701EAAE77@BPXM01GP.gisp.nec.co.jp>
On Friday 03 March 2017 10:05 AM, Atsushi Kumagai wrote:
> When you change the design, please note it into changelog,
> it's a review point of view.
>
> Changes since v2:
> - Fixed a memory leak issue and updated man page and usage info
Sorry about that!!
>
> As for the return value, I guess both is OK if there is a clear intention.
> If this is what you intended, I have no objection.
> (it actually sounds more reasonable)
>
> So I'll merge the v3 patch into v1.6.2, thanks for your work.
and thanks :-)
~Pratyush
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2017-03-03 4:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 8:36 [Makedumpfile Patch v3 0/7] Fix --mem-usage /proc/kcore Pratyush Anand
2017-03-02 8:36 ` [Makedumpfile Patch v3 1/7] show_mem_usage(): calculate page offset after elf load Pratyush Anand
2017-03-02 8:36 ` [Makedumpfile Patch v3 2/7] initial(): call cach_init() a bit early Pratyush Anand
2017-07-19 7:46 ` Atsushi Kumagai
2017-07-19 11:20 ` Pratyush Anand
2017-07-20 6:54 ` Atsushi Kumagai
2017-07-20 8:01 ` Hatayama, Daisuke
2017-03-02 8:36 ` [Makedumpfile Patch v3 3/7] x86_64: check physical address in PT_LOAD for none direct mapped regions Pratyush Anand
2017-03-02 8:36 ` [Makedumpfile Patch v3 4/7] elf_info: kcore: check for invalid physical address Pratyush Anand
2017-03-02 8:36 ` [Makedumpfile Patch v3 5/7] makedumpfile: Correct the calculation of kvaddr in set_kcore_vmcoreinfo Pratyush Anand
2017-03-02 8:36 ` [Makedumpfile Patch v3 6/7] makedumpfile: Discard process_dump_load Pratyush Anand
2017-03-02 8:36 ` [Makedumpfile Patch v3 7/7] mem-usage: allow to work only with -f for kernel version < 4.11 Pratyush Anand
2017-03-03 2:10 ` Atsushi Kumagai
2017-03-03 2:48 ` Pratyush Anand
2017-03-03 3:07 ` bhe
2017-03-03 4:35 ` Atsushi Kumagai
2017-03-03 4:56 ` Pratyush Anand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f10b643-bc47-e4a4-bd3d-7f0c7b8adf68@redhat.com \
--to=panand@redhat.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.