From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbeBWPT6 (ORCPT ); Fri, 23 Feb 2018 10:19:58 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:38453 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbeBWPT5 (ORCPT ); Fri, 23 Feb 2018 10:19:57 -0500 X-Google-Smtp-Source: AG47ELvvUj9qtgqsPRsIpvE7+xNl78nTSspivbVPPSC2jHblam6rTqL4UKbI2q8F3JDVqs+kKJWx+Q== Subject: Re: [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, konrad.wilk@oracle.com Cc: Oleksandr Andrushchenko References: <1519200222-20623-1-git-send-email-andr2000@gmail.com> <1519200222-20623-7-git-send-email-andr2000@gmail.com> <9081e140-dd0e-bb55-240f-77ff19a33f3c@oracle.com> From: Oleksandr Andrushchenko Message-ID: <5f1d8590-8c74-ac40-896e-06405f23be3a@gmail.com> Date: Fri, 23 Feb 2018 17:19:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <9081e140-dd0e-bb55-240f-77ff19a33f3c@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2018 05:12 PM, Boris Ostrovsky wrote: > On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > >> + >> +struct drm_driver xen_drm_driver = { >> + .driver_features = DRIVER_GEM | DRIVER_MODESET | >> + DRIVER_PRIME | DRIVER_ATOMIC, >> + .lastclose = lastclose, >> + .gem_free_object_unlocked = free_object, >> + .gem_vm_ops = &xen_drm_vm_ops, >> + .prime_handle_to_fd = drm_gem_prime_handle_to_fd, >> + .prime_fd_to_handle = drm_gem_prime_fd_to_handle, >> + .gem_prime_import = drm_gem_prime_import, >> + .gem_prime_export = drm_gem_prime_export, >> + .gem_prime_get_sg_table = prime_get_sg_table, >> + .gem_prime_import_sg_table = prime_import_sg_table, >> + .gem_prime_vmap = prime_vmap, >> + .gem_prime_vunmap = prime_vunmap, >> + .gem_prime_mmap = prime_mmap, >> + .dumb_create = dumb_create, >> + .fops = &xendrm_fops, >> + .name = "xendrm-du", >> + .desc = "Xen PV DRM Display Unit", >> + .date = "20161109", > You must have been working on this for a while ;-) yes, this is true ;) > > I assume this needs to be updated. It can be, but I would either stick to the current value for historical reasons or would update it in the final version of the driver, so it reflects the date of issuing ;) >> +bool xen_drm_front_drv_is_used(struct platform_device *pdev) >> +{ >> + struct xen_drm_front_drm_info *drm_info = platform_get_drvdata(pdev); >> + struct drm_device *dev; >> + >> + if (!drm_info) >> + return false; >> + >> + dev = drm_info->drm_dev; >> + if (!dev) >> + return false; >> + >> + /* >> + * FIXME: the code below must be protected by drm_global_mutex, >> + * but it is not accessible to us. Anyways there is a race condition, >> + * but we will re-try. >> + */ >> + return dev->open_count != 0; > Would it be a problem, given the race, if you report that the frontend > is not in use, while it actually is? no, backend will not be able to activate us again > -boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Andrushchenko Subject: Re: [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver Date: Fri, 23 Feb 2018 17:19:53 +0200 Message-ID: <5f1d8590-8c74-ac40-896e-06405f23be3a@gmail.com> References: <1519200222-20623-1-git-send-email-andr2000@gmail.com> <1519200222-20623-7-git-send-email-andr2000@gmail.com> <9081e140-dd0e-bb55-240f-77ff19a33f3c@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E5756F19C for ; Fri, 23 Feb 2018 15:19:57 +0000 (UTC) Received: by mail-lf0-x243.google.com with SMTP id 37so12842658lfs.7 for ; Fri, 23 Feb 2018 07:19:57 -0800 (PST) In-Reply-To: <9081e140-dd0e-bb55-240f-77ff19a33f3c@oracle.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, konrad.wilk@oracle.com Cc: Oleksandr Andrushchenko List-Id: dri-devel@lists.freedesktop.org T24gMDIvMjMvMjAxOCAwNToxMiBQTSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+IE9uIDAyLzIx LzIwMTggMDM6MDMgQU0sIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOgo+Cj4+ICsKPj4g K3N0cnVjdCBkcm1fZHJpdmVyIHhlbl9kcm1fZHJpdmVyID0gewo+PiArCS5kcml2ZXJfZmVhdHVy ZXMgICAgICAgICAgID0gRFJJVkVSX0dFTSB8IERSSVZFUl9NT0RFU0VUIHwKPj4gKwkJCQkgICAg IERSSVZFUl9QUklNRSB8IERSSVZFUl9BVE9NSUMsCj4+ICsJLmxhc3RjbG9zZSAgICAgICAgICAg ICAgICAgPSBsYXN0Y2xvc2UsCj4+ICsJLmdlbV9mcmVlX29iamVjdF91bmxvY2tlZCAgPSBmcmVl X29iamVjdCwKPj4gKwkuZ2VtX3ZtX29wcyAgICAgICAgICAgICAgICA9ICZ4ZW5fZHJtX3ZtX29w cywKPj4gKwkucHJpbWVfaGFuZGxlX3RvX2ZkICAgICAgICA9IGRybV9nZW1fcHJpbWVfaGFuZGxl X3RvX2ZkLAo+PiArCS5wcmltZV9mZF90b19oYW5kbGUgICAgICAgID0gZHJtX2dlbV9wcmltZV9m ZF90b19oYW5kbGUsCj4+ICsJLmdlbV9wcmltZV9pbXBvcnQgICAgICAgICAgPSBkcm1fZ2VtX3By aW1lX2ltcG9ydCwKPj4gKwkuZ2VtX3ByaW1lX2V4cG9ydCAgICAgICAgICA9IGRybV9nZW1fcHJp bWVfZXhwb3J0LAo+PiArCS5nZW1fcHJpbWVfZ2V0X3NnX3RhYmxlICAgID0gcHJpbWVfZ2V0X3Nn X3RhYmxlLAo+PiArCS5nZW1fcHJpbWVfaW1wb3J0X3NnX3RhYmxlID0gcHJpbWVfaW1wb3J0X3Nn X3RhYmxlLAo+PiArCS5nZW1fcHJpbWVfdm1hcCAgICAgICAgICAgID0gcHJpbWVfdm1hcCwKPj4g KwkuZ2VtX3ByaW1lX3Z1bm1hcCAgICAgICAgICA9IHByaW1lX3Z1bm1hcCwKPj4gKwkuZ2VtX3By aW1lX21tYXAgICAgICAgICAgICA9IHByaW1lX21tYXAsCj4+ICsJLmR1bWJfY3JlYXRlICAgICAg ICAgICAgICAgPSBkdW1iX2NyZWF0ZSwKPj4gKwkuZm9wcyAgICAgICAgICAgICAgICAgICAgICA9 ICZ4ZW5kcm1fZm9wcywKPj4gKwkubmFtZSAgICAgICAgICAgICAgICAgICAgICA9ICJ4ZW5kcm0t ZHUiLAo+PiArCS5kZXNjICAgICAgICAgICAgICAgICAgICAgID0gIlhlbiBQViBEUk0gRGlzcGxh eSBVbml0IiwKPj4gKwkuZGF0ZSAgICAgICAgICAgICAgICAgICAgICA9ICIyMDE2MTEwOSIsCj4g WW91IG11c3QgaGF2ZSBiZWVuIHdvcmtpbmcgb24gdGhpcyBmb3IgYSB3aGlsZSA7LSkKeWVzLCB0 aGlzIGlzIHRydWUgOykKPgo+IEkgYXNzdW1lIHRoaXMgbmVlZHMgdG8gYmUgdXBkYXRlZC4KSXQg Y2FuIGJlLCBidXQgSSB3b3VsZCBlaXRoZXIgc3RpY2sgdG8gdGhlIGN1cnJlbnQgdmFsdWUKZm9y IGhpc3RvcmljYWwgcmVhc29ucyBvciB3b3VsZCB1cGRhdGUgaXQgaW4gdGhlIGZpbmFsIHZlcnNp b24Kb2YgdGhlIGRyaXZlciwgc28gaXQgcmVmbGVjdHMgdGhlIGRhdGUgb2YgaXNzdWluZyA7KQo+ PiArYm9vbCB4ZW5fZHJtX2Zyb250X2Rydl9pc191c2VkKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2Ug KnBkZXYpCj4+ICt7Cj4+ICsJc3RydWN0IHhlbl9kcm1fZnJvbnRfZHJtX2luZm8gKmRybV9pbmZv ID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRl djsKPj4gKwo+PiArCWlmICghZHJtX2luZm8pCj4+ICsJCXJldHVybiBmYWxzZTsKPj4gKwo+PiAr CWRldiA9IGRybV9pbmZvLT5kcm1fZGV2Owo+PiArCWlmICghZGV2KQo+PiArCQlyZXR1cm4gZmFs c2U7Cj4+ICsKPj4gKwkvKgo+PiArCSAqIEZJWE1FOiB0aGUgY29kZSBiZWxvdyBtdXN0IGJlIHBy b3RlY3RlZCBieSBkcm1fZ2xvYmFsX211dGV4LAo+PiArCSAqIGJ1dCBpdCBpcyBub3QgYWNjZXNz aWJsZSB0byB1cy4gQW55d2F5cyB0aGVyZSBpcyBhIHJhY2UgY29uZGl0aW9uLAo+PiArCSAqIGJ1 dCB3ZSB3aWxsIHJlLXRyeS4KPj4gKwkgKi8KPj4gKwlyZXR1cm4gZGV2LT5vcGVuX2NvdW50ICE9 IDA7Cj4gV291bGQgaXQgYmUgYSBwcm9ibGVtLCBnaXZlbiB0aGUgcmFjZSwgaWYgeW91IHJlcG9y dCB0aGF0IHRoZSBmcm9udGVuZAo+IGlzIG5vdCBpbiB1c2UsIHdoaWxlIGl0IGFjdHVhbGx5IGlz PwpubywgYmFja2VuZCB3aWxsIG5vdCBiZSBhYmxlIHRvIGFjdGl2YXRlIHVzIGFnYWluCj4gLWJv cmlzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK