From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D031BC433EF for ; Sun, 24 Oct 2021 11:19:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55247601FF for ; Sun, 24 Oct 2021 11:19:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55247601FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mebX8-0006sf-7x for qemu-devel@archiver.kernel.org; Sun, 24 Oct 2021 07:19:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mebWT-0006BO-2V for qemu-devel@nongnu.org; Sun, 24 Oct 2021 07:18:41 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:34394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mebWR-0004Fe-Kr for qemu-devel@nongnu.org; Sun, 24 Oct 2021 07:18:40 -0400 Received: by mail-wm1-x333.google.com with SMTP id o4-20020a1c7504000000b0032cab7473caso1863711wmc.1 for ; Sun, 24 Oct 2021 04:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hC2ROvRhq8ySPx31tUgyPwfZCKQtqHjtM9lDYcHukpk=; b=GAnYireEosSJOqaa5WMXAmGDe2ahEl5DbITC/lgJGH42sFDMmSFCrBVBWytoYS7JEK JrXp49tECUGdSSaXyp3zFwSf3xQkXuaHS4lh07kGJVzb+U77FZbMSUH6DkrzunAe4YS9 uIHwk2RDwGa7Ghi23eFEogZzwepCGr8VCgaQQ7XVYLYWdmpUx8d0wS/NwDcDALuOWlT7 fgoHtiuiDTIqkp96zJTR/dPnlGpK9YVmzW7ZzhnyMX2hN5frzdr9nvIPjLXiNhdsmSzd PcAXUfVdHZc7VQxN76yR40tAvWqqzkQJD3F7UJ75Sq1cv2lfSO6bGFEV1hvHm5i/BdpR zvFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hC2ROvRhq8ySPx31tUgyPwfZCKQtqHjtM9lDYcHukpk=; b=M1R8uvAojUFTrHnYmtRdF8Vk6KQM/xEIlHhfsEn3AtmKbJSJWlJIWa5MlRb4a4agzD kUUPw7TJ/wqQHDgIW2WANRMSBwLL7qyUwyLl+QQA44qLkSLq33pQmZ5cOU07img92plS KUTZqD/8cGb5ozma37ukuFu/SNuxHM9I6TXQmaC2iXFWNH/EufBlZZfC8dONYdOR/nPv R/xRIZpw+qWOZIoB3h9ktvyimXAe8fu0t/pI9povykJj9btNyCnXtx3ac1BhyZYguvMj DMqhIwSeekbYIIffFwyfh0WxkUA4Z6n+nCmTZx1PTdNQWYar9+3R5JuvtYBufRhnEBJ8 1qgw== X-Gm-Message-State: AOAM530Lx5mrGfUZyPK6aobqHgwZfUHg8gu9LBU6B99RrL8LBGzjhGJL GWPaFbyPHaoYj6NEYMp3CNs= X-Google-Smtp-Source: ABdhPJyOpJt1DEQgtVcFH911eidjizwIx1+8a8A5j2xAcoEzLBKv+jXwx+meB5CIvOlLH8sZo3WIxw== X-Received: by 2002:a1c:1bd7:: with SMTP id b206mr2585701wmb.57.1635074317761; Sun, 24 Oct 2021 04:18:37 -0700 (PDT) Received: from [192.168.1.36] (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id k17sm13096708wrq.7.2021.10.24.04.18.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Oct 2021 04:18:36 -0700 (PDT) Message-ID: <5f225ccc-e84b-eae9-ffb9-35853704c9e8@amsat.org> Date: Sun, 24 Oct 2021 13:18:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20211023214803.522078-1-f4bug@amsat.org> <20211023214803.522078-16-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -47 X-Spam_score: -4.8 X-Spam_bar: ---- X-Spam_report: (-4.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.33, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Luis Pires Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/24/21 06:53, Richard Henderson wrote: > On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote: >> +#define TRANS_DF_E(NAME, trans_func, gen_func) \ >> +        TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ >> +                    gen_func##_b, gen_func##_h, gen_func##_w, >> gen_func##_d) > > I think this would be better as a table. > > #define TRANS_DF_E(NAME, trans_func, gen_func) \ >     static void (* const NAME##_tab[4])(TCGv_ptr, TCGv_i32, TCGV) = { \ >         gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d)       \ >     };                                                                \ >     TRANS_MSA(trans_func, NAME##_tag[a->df]) Nice tip! Thanks :>