From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471C0C04AB4 for ; Tue, 14 May 2019 07:23:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6B5A206A3 for ; Tue, 14 May 2019 07:23:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=russell.cc header.i=@russell.cc header.b="prVvBfyG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="c8g+mmmo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6B5A206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=russell.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4538LS42nSzDqMG for ; Tue, 14 May 2019 17:23:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=russell.cc (client-ip=66.111.4.26; helo=out2-smtp.messagingengine.com; envelope-from=ruscur@russell.cc; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=russell.cc Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=russell.cc header.i=@russell.cc header.b="prVvBfyG"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="c8g+mmmo"; dkim-atps=neutral Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4538Jr4ZhszDqJV for ; Tue, 14 May 2019 17:22:19 +1000 (AEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D1F7E24811; Tue, 14 May 2019 03:22:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 14 May 2019 03:22:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=russell.cc; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=fm1; bh= C2tqMHY/rN4zDLt1czzdTIeaoMoR2rT5PtdfzubldGA=; b=prVvBfyGcd5GXDJH ST1vEc/pMaLvGr96oUKgZ56ZkCVXBgfoLRa36Rf4B1xId/AkqbA8RhbsFQYGDHek PdQ9FPqSDzXSHBXQd9nfOdwTKJjWjxFCSPDdB6NQ7q+/89qXvqCAnl4UxytdHpEl jDyVjxZoJMqdHPfamQdTOKQfgfjGGQO/NgTudorghDbvnEDExlBfwZVbWONR189y ApvNvCyuA1jD62RKq53oEpiERUgABjueiFCAA7rla8WK0dUHulHA8IhWzPQy6ta2 SS69AlAgSyobrt8sOFu1u4kqErPD6flankVuqUJ56xVjX06FRyEA9p3XzWO3l2Qq +qekiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=C2tqMHY/rN4zDLt1czzdTIeaoMoR2rT5Ptdfzubld GA=; b=c8g+mmmoEBY7vdyPGYc7BWxZ/OtFk/ncH6Zqp/KAWXcqKZ4JI/9ZSwgnJ hxbu2W1vluJYp4FAKNzKdd32t4p54NtPxepWzpvenpS1lg45GTj0Hbo6QqW0iJQS bsAagSKsyMNE5Ft4b1QaPZR3AdB2PgVDL326PrUY9LVMK864j6TN2Ai7EW5oHwMt jxctPd8p23FdTGYdkin4PMj1M2Qb43W42McSDPFbh9YhMv3A3XNuRiaJfPWPeZsO Lmr5B5MaAtt3Zh0CXez7ACOHHcuKmopWrZigUi6Jt2FWPcdDfm/17/Dt7Vl+4IqF OTYKPg3iKJEb0rSLfORXIJeeCiBeA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleehgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlvddtmdenucfjughrpefkuffhvfffjghftggfggfgsehtjeertddt reejnecuhfhrohhmpeftuhhsshgvlhhlucevuhhrrhgvhicuoehruhhstghurhesrhhush hsvghllhdrtggtqeenucffohhmrghinhepohiilhgrsghsrdhorhhgnecukfhppeduvddv rdelledrkedvrddutdenucfrrghrrghmpehmrghilhhfrhhomheprhhushgtuhhrsehruh hsshgvlhhlrdgttgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy:

Received: from crackle.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id D51C680060; Tue, 14 May 2019 03:22:14 -0400 (EDT) Message-ID: <5f31b4964d64aea3fc31165b9cbd0b9d16fd2aa0.camel@russell.cc> Subject: Re: [v2 2/2] [PowerPC] Allow use of SIMD in interrupts from kernel code From: Russell Currey To: Shawn Landden Date: Tue, 14 May 2019 17:22:12 +1000 In-Reply-To: <20190514022308.32363-2-shawn@git.icu> References: <20190513005104.20140-1-shawn@git.icu> <20190514022308.32363-1-shawn@git.icu> <20190514022308.32363-2-shawn@git.icu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 2019-05-13 at 23:23 -0300, Shawn Landden wrote: > This second patch is separate because it could be wrong, > like I am not sure about how kernel thread migration works, > and it is even allowing simd in preemptible kernel code. > > Signed-off-by: Shawn Landden > --- Hi Shawn, This patch doesn't build on 64-bit embedded (ppc64e_defconfig): arch/powerpc/kernel/process.c:194:13: error: 'interrupted_kernel_fpu_idle' defined but not used [-Werror=unused-function] static bool interrupted_kernel_fpu_idle(void) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ and otherwise adds two sparse warnings: +arch/powerpc/kernel/process.c:356:13: warning: function 'disable_kernel_altivec' with external linkage has definition +arch/powerpc/kernel/process.c:416:6: warning: symbol 'may_use_simd' was not declared. Should it be static? There's also some style issues (spaces instead of tabs). Reported by snowpatch (see https://patchwork.ozlabs.org/patch/1099181/) - Russell