All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Lange Norbert <norbert.lange@andritz.com>,
	Philippe Gerum <rpm@xenomai.org>,
	"Xenomai (xenomai@xenomai.org)" <xenomai@xenomai.org>
Subject: Re: [PATCH 2/2] cobalt: switch hand over status to -ENODEV for non-RTDM fd
Date: Thu, 29 Aug 2019 16:52:23 +0200	[thread overview]
Message-ID: <5f37d7d4-d4bb-6473-dd1a-494bd0472c83@siemens.com> (raw)
In-Reply-To: <VI1PR05MB5917F833764544DF7F3E666FF6A20@VI1PR05MB5917.eurprd05.prod.outlook.com>

On 29.08.19 16:12, Lange Norbert via Xenomai wrote:
> 
> I ran into a rather big issue with linux filehandles
> I use Xenomai master on ipipe-core-4.19.60-x86-5 with those patches,
> (can't be 100% sure its not some kernel/userspace conflict, but I doubt it)
> 
> What happens is that upon a __cobalt_close with a linux filehande, the
> syscall sc_cobalt_close returns EBADF, but that means the libc close will
> never be tried and filehandles are leaking like mad.
> 

Ah, good catch. Looks like Philippe's patch was missing a change to rtdm_fd_close().

Thanks a lot for testing pro-actively!

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux


  parent reply	other threads:[~2019-08-29 14:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 17:29 [PATCH 0/2] For review - core RTDM, RTnet changes Philippe Gerum
2019-06-20 17:29 ` [PATCH 1/2] drivers/net: drop socket-specific module refcounting Philippe Gerum
2019-07-04  9:04   ` Jan Kiszka
2019-06-20 17:29 ` [PATCH 2/2] cobalt: switch hand over status to -ENODEV for non-RTDM fd Philippe Gerum
2019-07-04  9:04   ` Jan Kiszka
2019-08-29 14:12   ` Lange Norbert
2019-08-29 14:45     ` Philippe Gerum
2019-08-29 14:52     ` Jan Kiszka [this message]
2019-08-30  9:58       ` Lange Norbert
2019-08-30 11:23         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f37d7d4-d4bb-6473-dd1a-494bd0472c83@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=norbert.lange@andritz.com \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.