From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C05C4338F for ; Thu, 19 Aug 2021 16:35:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2583061053 for ; Thu, 19 Aug 2021 16:35:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2583061053 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63B1D80F47; Thu, 19 Aug 2021 18:35:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="D31Hzbhv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 262FD80ECD; Thu, 19 Aug 2021 18:34:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20628.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::628]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06AA4829C6 for ; Thu, 19 Aug 2021 18:34:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WGJ/iJEQxDU+tFXTEMLQt6E+XLC9vOzdvN73Yh3NovLIv1wv9+nQyO+DBhbDgYFT4J/BL6LsQ/2QyDX07x8l1FE2f4UX8dGhJ+6gbFvzQXztKj8cbSVzPPwlw5NThkuPuT3gJQd0z3bIO0VWQanWn50k2bHfzaolWAtJE5C2gmB7sSHeqDXxw9+JMg4QXwtMKxqYpR/mRG2XW6VY06sv5TFl3bkheY95XN8lv5d6/X228zTr/fMt9ennsp/LEzlGY9/QcmD4TtY+1nTFG/Or/sAzxigikIZ4LtB2QX3lZOBdrjarYlGfjm57RmKRt4yV7xs7ZlFEFee+jdmsErd8pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CX1uo/2Dm7s7nG/hZ8qImjjcn3JFoqQBKlohh2SOcF0=; b=JuWT1txEiVHyHWS5rfWDTFD3posHtiDYcvMq39ZR2FKIwxyKmRdYSKLaKq//Pt+TQ6wmMhN8aW8yVdchu4l/HTnoCg5Cc0loKHmoZEHbCUoWZZjgk6e6r98ZGvr2E3jPe7KEmW9zDAUS9hW1Zex2oyjmXtEAT3GvteyGh1ZBjGBYJgKqmqkkDxrrtCraNYcRRWF7zjuKjBpCQ9Xc6Fv8CkiBzF0kwGObPHZuTcbkOKmdf/6kYn2oEdRHM4LRJ7R3wOE/p8xjjiTRb3oUS8lVLeA8xg+zqIRJzGPULhUubtuESW0v8Hjy1GZKjJMK/YqWm8Q9c8onnX5kdgmqa9HGSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=gateworks.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CX1uo/2Dm7s7nG/hZ8qImjjcn3JFoqQBKlohh2SOcF0=; b=D31HzbhvTt7oqSsu0/JVq5rk9SdtEi/ZYz6fT81KLft2BuQMQUsvxUHJ5sizOlKDPMQHrHQtAQMYRSCipRYkxoR8iFmut5DfgE6wWmAxCHJSnmKKPRILnoz4U5SgTjnReckBp18IfdW0QXJZDJslXjsJIAYpB/jRCJevPu5HSdo= Received: from SN4PR0501CA0089.namprd05.prod.outlook.com (2603:10b6:803:22::27) by CH2PR02MB6327.namprd02.prod.outlook.com (2603:10b6:610:b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.19; Thu, 19 Aug 2021 16:34:51 +0000 Received: from SN1NAM02FT0049.eop-nam02.prod.protection.outlook.com (2603:10b6:803:22:cafe::37) by SN4PR0501CA0089.outlook.office365.com (2603:10b6:803:22::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.8 via Frontend Transport; Thu, 19 Aug 2021 16:34:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; gateworks.com; dkim=none (message not signed) header.d=none;gateworks.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0049.mail.protection.outlook.com (10.97.5.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4436.19 via Frontend Transport; Thu, 19 Aug 2021 16:34:51 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 19 Aug 2021 09:34:50 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 19 Aug 2021 09:34:50 -0700 Envelope-to: git@xilinx.com, tharvey@gateworks.com, priyanka.jain@nxp.com, pbrobinson@gmail.com, lokeshvutla@ti.com, kostap@marvell.com, kever.yang@rock-chips.com, jagan@amarulasolutions.com, hs@denx.de, festevam@denx.de, u-boot@lists.denx.de, andre.przywara@arm.com Received: from [172.30.17.109] (port=43554) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mGl0C-00015P-TX; Thu, 19 Aug 2021 09:34:49 -0700 Subject: Re: [PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned for 64bit systems To: Andre Przywara , Michal Simek , , CC: Fabio Estevam , Heiko Schocher , Jagan Teki , Kever Yang , Konstantin Porotchkin , Lokesh Vutla , Peter Robinson , Priyanka Jain , Tim Harvey References: <863295f0-3d4f-499a-78ae-57b5aaea36fe@arm.com> From: Michal Simek Message-ID: <5f43bbbf-0766-4407-7eda-fd40663b6e1e@xilinx.com> Date: Thu, 19 Aug 2021 18:34:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <863295f0-3d4f-499a-78ae-57b5aaea36fe@arm.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6bf7c940-49ed-4b6f-87df-08d9632f448e X-MS-TrafficTypeDiagnostic: CH2PR02MB6327: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bCOF66RkvmxIk3lUuBMGI0ZLlqOx7SlOpBxgq9gdPoZvwrLyMsjc1OPjSMG3ImMrxbDeIbpPDScy3qQisvSvZv6eaXpH6ke/DW99iZdgOCERc4MSnOT2CYYztTJjuleDH0q8pe/YDvODmJrWZw+U3LeaZpp+QAhByvLaJt7/vt9ZzwykgnNETsj47C+uL4NZPB50QfXfcV4Fsn0PZ8tBp+IkOi/zVcVdN+97/jCIWg5nRp3ZulxU+04/pBJkFsZF5+hCe0n+qzraQlz9RgUM8UQAd6+nQAY1blUP1nypcCg4XfH9BSeP8Fk2fpEeC8tGGs1STeEIxjVrvB5yxuyIA7SVLYVBlLY9UOymeeSiL+bdPNQNuZsP2+nXPbDsSHqXWDo6sX+NktVFiVPJiV2x15cGdMUOAZfLANlQ1IUE6WpkxCZlJVKDMDc1G7KqOwBusP5WsyrbUCs9jHObeqecqtbdCy/WBaC9rByzv1ENEmwZduuyIN+x8c09b8TDuYGTD/LxmYDDzQAl/kI6TJIdRcf6I0WwlUNdMoqd/WP321WqVOjoDkQKXUtuizO5tIuo4w1jL+nncKDc0y/dBJvCQ1LDQZuWBKGcRStJTsGEPgdwJXNlVltZkmEEks7Ycef08wMeR6rg74oUNFmnWWt2o6dhSY6ZRjExIERUoshuRXyEGx9h0rlGlo3OJDvtI119lrFjj4axdHHPldyqC+2TNESLzvsU88sApg6CO3q8AhNpZ7PNnMK40Neqv3icfFEd X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(36840700001)(46966006)(31696002)(5660300002)(478600001)(70206006)(7416002)(6636002)(9786002)(31686004)(356005)(36860700001)(53546011)(70586007)(2906002)(6666004)(7636003)(82310400003)(36756003)(186003)(4326008)(36906005)(2616005)(110136005)(54906003)(426003)(44832011)(316002)(8936002)(47076005)(336012)(8676002)(26005)(82740400003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2021 16:34:51.3620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf7c940-49ed-4b6f-87df-08d9632f448e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0049.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6327 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Andre, On 8/19/21 6:10 PM, Andre Przywara wrote: > On 8/19/21 12:19 PM, Michal Simek wrote: > > Hi Michal, > >> DTBs for 64bit systems should be also 64bit aligned. > > What does "align" mean here, exactly? This is about generating .dtb > *files*, right? dtc makes sure that the internal structures are properly > aligned, so what else should be aligned here? > >> Signed-off-by: Michal Simek >> --- >> >>   arch/arm/dts/Makefile | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile >> index 537c96bf5b35..8d4fc333ea7a 100644 >> --- a/arch/arm/dts/Makefile >> +++ b/arch/arm/dts/Makefile >> @@ -1,5 +1,9 @@ >>   # SPDX-License-Identifier: GPL-2.0+ >>   +ifdef CONFIG_PHYS_64BIT >> +DTC_FLAGS += -a 0x8 > > By looking into the dtc source this looks like to make sure the *size* > of the DTB is 8-byte aligned, is that the intention here, or even > useful? If it is, it should apply unconditionally, not only to 64-bit > systems. The question is correct. I did it mostly for being safe that DTBs start and end is 64bit aligned. I didn't hit any issue with not aligned end and maybe it is not useful to do it. It was just more convenient for me to work with also 64bit aligned image size. Thanks, Michal