From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v7 1/6] bus: fix driver registration
Date: Wed, 5 Jul 2017 18:33:49 +0530
Message-ID: <5f57b162-b414-a5c7-1f62-3303d8cc9b02@nxp.com>
References: <cover.1499127915.git.gaetan.rivet@6wind.com>
 <cover.1499211317.git.gaetan.rivet@6wind.com>
 <1e7116a3deaa5c9280b765e29fec355b8ad0165b.1499211317.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0057.outbound.protection.outlook.com [104.47.34.57])
 by dpdk.org (Postfix) with ESMTP id 0C4001094
 for <dev@dpdk.org>; Wed,  5 Jul 2017 14:54:46 +0200 (CEST)
In-Reply-To: <1e7116a3deaa5c9280b765e29fec355b8ad0165b.1499211317.git.gaetan.rivet@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 05 July 2017 05:25 AM, Gaetan Rivet wrote:
> From: Thomas Monjalon <thomas@monjalon.net>
> 
> The bus name was stored with embedded double quotes.
> Indeed the bus name is given with a string in a macro,
> which is not used elsewhere.
> These macros are useless because the buses are drivers,
> so they must not have any API for the application writer.
> The registration can be done with a hardcoded value without quotes.
> 
> There is another (small) benefit of not using macros for driver names:
> it is to have a meaningful constructor function name.
> For instance, it was businitfn_PCI_BUS_NAME instead of businitfn_pci.
> 
> The bus registration macro is also changed to use
> the new RTE_INIT_PRIO macro, similar to RTE_INIT used for other drivers.
> The priority is the highest (101) in order to be sure that the bus driver
> is registered before its device drivers.
> 
> Fixes: 0fd1a0eaae19 ("pci: add bus driver")
> Fixes: fea892e35f21 ("bus/vdev: use standard bus registration")
> Fixes: 7e7df6d0a41d ("bus/fslmc: introduce fsl-mc bus driver")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Though I had already acked it in v6,
(from DPAA2 (bus/fslmc) perspective, as well as generically):

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

-
Shreyansh