All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org
Cc: Glenn Washburn <development@efficientek.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	Patrick Steinhardt <ps@pks.im>
Subject: [CRYPTO-LUKS v1 04/19] cryptodisk: Add more verbosity when reading/writing cryptodisks.
Date: Fri, 31 Jul 2020 07:01:45 -0500	[thread overview]
Message-ID: <5f5bd512648568065ccb2631628cc4ff4117bfbe.1596196383.git.development@efficientek.com> (raw)
In-Reply-To: <cover.1596196383.git.development@efficientek.com>

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 grub-core/disk/cryptodisk.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
index 2791a4870..c21be7d52 100644
--- a/grub-core/disk/cryptodisk.c
+++ b/grub-core/disk/cryptodisk.c
@@ -753,8 +753,10 @@ grub_cryptodisk_read (grub_disk_t disk, grub_disk_addr_t sector,
 
   grub_dprintf ("cryptodisk",
 		"Reading %" PRIuGRUB_SIZE " sectors from sector 0x%"
-		PRIxGRUB_UINT64_T " with offset of %" PRIuGRUB_UINT64_T "\n",
-		size, sector, dev->offset);
+		PRIxGRUB_UINT64_T " with offset of %" PRIuGRUB_UINT64_T
+		" sectors and sector size of %u on disk (%s)\n",
+		size, sector, dev->offset, 1U << disk->log_sector_size,
+		dev->source_disk->name);
 
   err = grub_disk_read (dev->source_disk,
 			((sector + dev->offset) << (disk->log_sector_size
@@ -803,8 +805,10 @@ grub_cryptodisk_write (grub_disk_t disk, grub_disk_addr_t sector,
 
   grub_dprintf ("cryptodisk",
 		"Writing %" PRIuGRUB_SIZE " sectors to sector 0x%"
-		PRIxGRUB_UINT64_T " with offset of %" PRIuGRUB_UINT64_T "\n",
-		size, sector, dev->offset);
+		PRIxGRUB_UINT64_T " with offset of %" PRIuGRUB_UINT64_T
+		" sectors and sector size of %u on disk (%s)\n",
+		size, sector, dev->offset, 1U << disk->log_sector_size,
+		dev->source_disk->name);
 
   gcry_err = grub_cryptodisk_endecrypt (dev, (grub_uint8_t *) tmp,
 					size << disk->log_sector_size,
-- 
2.25.1



  parent reply	other threads:[~2020-07-31 12:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 12:01 [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2 and a few other things Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 01/19] configure: Add Ubuntu dejavu font path Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 02/19] cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain' Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 03/19] cryptodisk: Incorrect calculation of start sector for grub_disk_read in grub_cryptodisk_read Glenn Washburn
2020-08-23 10:39   ` Patrick Steinhardt
2020-08-24  4:31     ` Glenn Washburn
2020-08-24  5:10       ` Patrick Steinhardt
2020-08-24 23:42         ` [CRYPTO-LUKS v2 03/19] cryptodisk: Incorrect calculation of sector in grub_cryptodisk_read/write Glenn Washburn
2020-08-25  2:09           ` Glenn Washburn
2020-08-24 23:58         ` [CRYPTO-LUKS v1 03/19] cryptodisk: Incorrect calculation of start sector for grub_disk_read in grub_cryptodisk_read Glenn Washburn
2020-08-25  2:39         ` [CRYPTO-LUKS v3 " Glenn Washburn
2020-07-31 12:01 ` Glenn Washburn [this message]
2020-07-31 12:01 ` [CRYPTO-LUKS v1 05/19] luks2: Add support for LUKS2 in (proc)/luks_script Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 06/19] luks2: Rename source disk variabled named 'disk' to 'source' as in luks.c Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 07/19] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors Glenn Washburn
2020-08-23 10:20   ` Patrick Steinhardt
2020-07-31 12:01 ` [CRYPTO-LUKS v1 08/19] cryptodisk, luks: Allow special processing for comparing UUIDs Glenn Washburn
2020-07-31 15:34   ` Patrick Steinhardt
2020-07-31 12:01 ` [CRYPTO-LUKS v1 09/19] cryptodisk: Unregister cryptomount command when removing module Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 10/19] fs: Fix block lists not being able to address to end of disk sometimes Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 11/19] cryptodisk: Properly handle non-512 byte sized sectors Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 12/19] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 13/19] fs: Allow number of blocks in block list to be optional, where length will be defaulted to the length of the device Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 14/19] loopback: Add procfs entry 'loopbacks' to output configured loopback devices Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 15/19] cryptodisk, luks2: Add header line to procfs entry and crypto and source device names Glenn Washburn
2020-07-31 15:37   ` [CRYPTO-LUKS v1 15/19] cryptodisk,luks2: " Patrick Steinhardt
2020-07-31 16:22     ` Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 16/19] cryptodisk: Add a couple comments noting the usage of a couple fields in grub_cryptodisk_t as is done for grub_disk_t Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 17/19] luks2: Ensure that bit fields of grub_luks2_digest_t in luks2_parse_digest are initialized before returning Glenn Washburn
2020-07-31 12:01 ` [CRYPTO-LUKS v1 18/19] luks2: Fix use of incorrect index and some error messages Glenn Washburn
2020-07-31 12:02 ` [CRYPTO-LUKS v1 19/19] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors to improve readability Glenn Washburn
2020-07-31 15:59 ` [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2 and a few other things Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f5bd512648568065ccb2631628cc4ff4117bfbe.1596196383.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.