This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning. Test Result: checkpatch Failed Outputs: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/bluetooth.h', please use '/*' instead #94: FILE: obexd/client/bluetooth.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #94: FILE: obexd/client/bluetooth.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/driver.h', please use '/*' instead #112: FILE: obexd/client/driver.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #112: FILE: obexd/client/driver.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/ftp.h', please use '/*' instead #130: FILE: obexd/client/ftp.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #130: FILE: obexd/client/ftp.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/manager.h', please use '/*' instead #148: FILE: obexd/client/manager.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #148: FILE: obexd/client/manager.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/map-event.h', please use '/*' instead #166: FILE: obexd/client/map-event.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #166: FILE: obexd/client/map-event.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/map.h', please use '/*' instead #184: FILE: obexd/client/map.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #184: FILE: obexd/client/map.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/opp.h', please use '/*' instead #211: FILE: obexd/client/opp.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #211: FILE: obexd/client/opp.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/pbap.h', please use '/*' instead #229: FILE: obexd/client/pbap.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #229: FILE: obexd/client/pbap.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/session.h', please use '/*' instead #247: FILE: obexd/client/session.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #247: FILE: obexd/client/session.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/sync.h', please use '/*' instead #265: FILE: obexd/client/sync.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #265: FILE: obexd/client/sync.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/transfer.h', please use '/*' instead #283: FILE: obexd/client/transfer.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #283: FILE: obexd/client/transfer.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/transport.h', please use '/*' instead #301: FILE: obexd/client/transport.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #301: FILE: obexd/client/transport.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/filesystem.h', please use '/*' instead #328: FILE: obexd/plugins/filesystem.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #328: FILE: obexd/plugins/filesystem.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/ftp.h', please use '/*' instead #346: FILE: obexd/plugins/ftp.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #346: FILE: obexd/plugins/ftp.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/messages.h', please use '/*' instead #391: FILE: obexd/plugins/messages.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #391: FILE: obexd/plugins/messages.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/phonebook.h', please use '/*' instead #454: FILE: obexd/plugins/phonebook.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #454: FILE: obexd/plugins/phonebook.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/vcard.h', please use '/*' instead #481: FILE: obexd/plugins/vcard.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #481: FILE: obexd/plugins/vcard.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/log.h', please use '/*' instead #499: FILE: obexd/src/log.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #499: FILE: obexd/src/log.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/manager.h', please use '/*' instead #526: FILE: obexd/src/manager.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #526: FILE: obexd/src/manager.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/map_ap.h', please use '/*' instead #535: FILE: obexd/src/map_ap.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #535: FILE: obexd/src/map_ap.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/mimetype.h', please use '/*' instead #553: FILE: obexd/src/mimetype.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #553: FILE: obexd/src/mimetype.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/obex-priv.h', please use '/*' instead #562: FILE: obexd/src/obex-priv.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #562: FILE: obexd/src/obex-priv.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/obex.h', please use '/*' instead #580: FILE: obexd/src/obex.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #580: FILE: obexd/src/obex.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/obexd.h', please use '/*' instead #589: FILE: obexd/src/obexd.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #589: FILE: obexd/src/obexd.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/plugin.h', please use '/*' instead #607: FILE: obexd/src/plugin.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #607: FILE: obexd/src/plugin.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/server.h', please use '/*' instead #625: FILE: obexd/src/server.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #625: FILE: obexd/src/server.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/service.h', please use '/*' instead #643: FILE: obexd/src/service.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #643: FILE: obexd/src/service.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/transport.h', please use '/*' instead #661: FILE: obexd/src/transport.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #661: FILE: obexd/src/transport.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later - total: 0 errors, 56 warnings, 260 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --- Regards, Linux Bluetooth