From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH RESEND 2/2] memory: Add tracepoint for dirty sync
Date: Tue, 17 Aug 2021 18:07:02 +0200 [thread overview]
Message-ID: <5f6066fb-79be-e369-5d05-8bd22db8864d@redhat.com> (raw)
In-Reply-To: <YRveXqqR+DELQVSe@t490s>
On 17.08.21 18:05, Peter Xu wrote:
> On Tue, Aug 17, 2021 at 09:25:56AM +0200, David Hildenbrand wrote:
>> On 17.08.21 03:37, Peter Xu wrote:
>>> Trace at memory_region_sync_dirty_bitmap() for log_sync() or global_log_sync()
>>> on memory regions. One trace line should suffice when it finishes, so as to
>>> estimate the time used for each log sync process.
>>
>> I wonder if a start/finish would be even nicer. At least it wouldn't really
>> result in significantly more code changes :)
>
> Note that the "name"s I added is not only for not using start/end, it's about
> knowing which memory listener is slow. Start/end won't achieve that if we
> don't have a name for them. So far I just wanted to identify majorly kvm,
> vhost and kvm-smram, however it'll always be good when some log_sync is missed
> when tracing.
>
> I'm also wondering whether kvm-smram needs a whole bitmap as I don't know what
> RAM would be touched within system manager mode (as I thought it should only
> touch a very limited range and should be defined somewhere), but that's
> off-topic.
>
> If we want to make it start/end pair, I can do that too. But the 1st patch
> will still be wanted.
Yeah, absolutely, not complaining about the name, it will be valuable to
have!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-08-17 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 1:35 [PATCH RESEND 0/2] memory: Add tracepoints for log_sync Peter Xu
2021-08-17 1:35 ` [PATCH RESEND 1/2] memory: Name all the memory listeners Peter Xu
2021-08-17 7:24 ` David Hildenbrand
2021-08-17 1:37 ` [PATCH RESEND 2/2] memory: Add tracepoint for dirty sync Peter Xu
2021-08-17 7:25 ` David Hildenbrand
2021-08-17 16:05 ` Peter Xu
2021-08-17 16:07 ` David Hildenbrand [this message]
2021-09-20 13:01 ` Paolo Bonzini
2021-09-20 12:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f6066fb-79be-e369-5d05-8bd22db8864d@redhat.com \
--to=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.