On 04/24/2018 04:45 PM, Laszlo Ersek wrote: > We'll soon need an enumeration type that lists all the softmmu targets > that QEMU (the project) supports. Introduce @SysEmuTarget to > "common.json". > > Cc: "Daniel P. Berrange" > Cc: David Gibson > Cc: Eric Blake > Cc: Gerd Hoffmann > Cc: Kashyap Chamarthy > Cc: Markus Armbruster > Cc: Paolo Bonzini > Cc: Thomas Huth > Signed-off-by: Laszlo Ersek > Reviewed-by: Markus Armbruster > Reviewed-by: Kashyap Chamarthy > --- > > +## > +{ 'enum' : 'SysEmuTarget', > + 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32', > + 'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64', > + 'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc', > + 'ppc64', 'ppcemb', 'riscv32', 'riscv64', 's390x', 'sh4', > + 'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32', > + 'x86_64', 'xtensa', 'xtensaeb' ] } x86_64 doesn't match our typical conventions of preferring '-' over '_'; also, wikipedia mentions both spellings but under the page name 'x86-64'. Is it worth switching that enum constant? https://en.wikipedia.org/wiki/X86-64 -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org