From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH net 00/13] cls_u32 cleanups and fixes. Date: Sun, 9 Sep 2018 08:58:50 -0400 Message-ID: <5f835727-3f86-1532-889f-d11ae17e16d4@mojatatu.com> References: <20180909013132.3222-1-viro@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Cong Wang , Jiri Pirko To: Al Viro , netdev@vger.kernel.org Return-path: Received: from mail-qt0-f170.google.com ([209.85.216.170]:40353 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbeIIRs3 (ORCPT ); Sun, 9 Sep 2018 13:48:29 -0400 Received: by mail-qt0-f170.google.com with SMTP id h4-v6so21237954qtj.7 for ; Sun, 09 Sep 2018 05:58:52 -0700 (PDT) In-Reply-To: <20180909013132.3222-1-viro@ZenIV.linux.org.uk> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Since you have the momentum here: i noticed something unusual while i was trying to craft a test that would vet some of your changes. This has nothing to do with your changes, same happens on my stock debian laptop with kernel: 4.17.0-0.bpo.3-amd64 #1 SMP Debian 4.17.17-1~bpo9+1 (2018-08-27) Looking at git - possibly introduced around the time u32 lockless was being introduced and maybe even earlier than that. Unfortunately i dont have time to dig further. To reproduce what i am referring to, here's a setup: $tc filter add dev eth0 parent ffff: protocol ip prio 102 u32 \ classid 1:2 match ip src 192.168.8.0/8 $tc filter replace dev eth0 parent ffff: protocol ip prio 102 \ handle 800:0:800 u32 classid 1:2 match ip src 1.1.0.0/24 u32_change() code path should have allowed changing of the keynode. cheers, jamal