All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Shawn Guo <shawn.guo@linaro.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 8/9] PCI: qcom: Drop unnecessary root_bus_nr setting
Date: Wed, 9 May 2018 18:46:06 +0300	[thread overview]
Message-ID: <5f93be0d-7ad2-70ca-a2b5-4fa5b9b482a3@mm-sol.com> (raw)
In-Reply-To: <1525844386-5433-8-git-send-email-shawn.guo@linaro.org>

Hi Shawn,

Thanks for the patch!

On 05/09/2018 08:39 AM, Shawn Guo wrote:
> The root_bus_nr initialization has already been done in function
> dw_pcie_host_init().  The -1 assignment in platform driver before
> calling into dw_pcie_host_init() is not really needed.  Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
>  drivers/pci/dwc/pcie-qcom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 5897af7d3355..a32aa024e907 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -1247,7 +1247,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &qcom_pcie_dw_ops;
>  
>  	if (IS_ENABLED(CONFIG_PCI_MSI)) {
> 

Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>

-- 
regards,
Stan

  reply	other threads:[~2018-05-09 15:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09  5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
2018-05-09  5:39 ` [PATCH 2/9] PCI: imx6: " Shawn Guo
2018-05-09  5:39 ` [PATCH 3/9] PCI: keystone: " Shawn Guo
2018-05-09  5:39 ` [PATCH 4/9] PCI: armada8k: " Shawn Guo
2018-05-09  7:29   ` Thomas Petazzoni
2018-05-09  7:52     ` Shawn Guo
2018-05-09  5:39 ` [PATCH 5/9] PCI: artpec6: " Shawn Guo
2018-05-09  5:39 ` [PATCH 6/9] PCI: designware-plat: " Shawn Guo
2018-05-09  5:39 ` [PATCH 7/9] PCI: histb: " Shawn Guo
2018-05-09  5:39 ` [PATCH 8/9] PCI: qcom: " Shawn Guo
2018-05-09 15:46   ` Stanimir Varbanov [this message]
2018-05-09  5:39 ` [PATCH 9/9] PCI: spear13xx: " Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f93be0d-7ad2-70ca-a2b5-4fa5b9b482a3@mm-sol.com \
    --to=svarbanov@mm-sol.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.