Re: [PATCH v2 4/6] rockchip: mkimage: Update init size limit

From: Jonas Karlman <jonas@kwiboo.se>
To: Kever Yang <kever.yang@rock-chips.com>,
	Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Joseph Chen <chenjh@rock-chips.com>,
	Alper Nebi Yasak <alpernebiyasak@gmail.com>
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Jagan Teki <jagan@edgeble.ai>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v2 4/6] rockchip: mkimage: Update init size limit
Date: Thu, 16 Feb 2023 14:36:40 +0000 (UTC)	[thread overview]
Message-ID: <5f9f46d7-b8e9-18be-09b7-8f589715f16b@kwiboo.se> (raw)
In-Reply-To: <c53380e2-1770-9f38-86b2-1671199e4780@rock-chips.com>

Hi Kever,

On 2023-02-16 08:59, Kever Yang wrote:
> Hi Jonas,
> 
> On 2023/2/14 18:33, Jonas Karlman wrote:
>> Sync init size limit from vendor u-boot and the SRAM size specified in a
>> SoCs TRM. Size is typically defined using the following expression:
>> <SRAM size> - <BootRom stack size>
> 
> Although most of SoC follow this rule, but not for all.
> 
> So please just do the sync from vendor u-boot, but not extra modify 
> under this rule.

Sure, I will only sync from vendor u-boot.

After such sync init size limit changes for:
px30: +2KiB -> 12KiB
rk3066: +2KiB -> 32KiB
rk3328: +2KiB -> 30KiB
rk3568: -16KiB -> 60KiB

Regards,
Jonas

> 
> Thanks,
> 
> - Kever
> 
>>
>> This makes it possible to use latest vendor TPL with RK3328 without
>> getting a size limit error running the mkimage command.
>>
>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>> ---
>> v2:
>> - new patch
>>
>>   tools/rkcommon.c | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/tools/rkcommon.c b/tools/rkcommon.c
>> index 1f1eaa16752b..7ad4780daf31 100644
>> --- a/tools/rkcommon.c
>> +++ b/tools/rkcommon.c
>> @@ -121,20 +121,20 @@ struct spl_info {
>>   };
>>   
>>   static struct spl_info spl_infos[] = {
>> -	{ "px30", "RK33", 0x2800, false, RK_HEADER_V1 },
>> -	{ "rk3036", "RK30", 0x1000, false, RK_HEADER_V1 },
>> +	{ "px30", "RK33", 0x4000 - 0x1000, false, RK_HEADER_V1 },
>> +	{ "rk3036", "RK30", 0x2000 - 0x1000, false, RK_HEADER_V1 },
>>   	{ "rk3066", "RK30", 0x8000 - 0x800, true, RK_HEADER_V1 },
>> -	{ "rk3128", "RK31", 0x1800, false, RK_HEADER_V1 },
>> +	{ "rk3128", "RK31", 0x2000 - 0x800, false, RK_HEADER_V1 },
>>   	{ "rk3188", "RK31", 0x8000 - 0x800, true, RK_HEADER_V1 },
>>   	{ "rk322x", "RK32", 0x8000 - 0x1000, false, RK_HEADER_V1 },
>> -	{ "rk3288", "RK32", 0x8000, false, RK_HEADER_V1 },
>> +	{ "rk3288", "RK32", 0x18000 - 0x1000, false, RK_HEADER_V1 },
>>   	{ "rk3308", "RK33", 0x40000 - 0x1000, false, RK_HEADER_V1 },
>> -	{ "rk3328", "RK32", 0x8000 - 0x1000, false, RK_HEADER_V1 },
>> -	{ "rk3368", "RK33", 0x8000 - 0x1000, false, RK_HEADER_V1 },
>> +	{ "rk3328", "RK32", 0x8000 - 0x800, false, RK_HEADER_V1 },
>> +	{ "rk3368", "RK33", 0x10000 - 0x1000, false, RK_HEADER_V1 },
>>   	{ "rk3399", "RK33", 0x30000 - 0x2000, false, RK_HEADER_V1 },
>> -	{ "rv1108", "RK11", 0x1800, false, RK_HEADER_V1 },
>> +	{ "rv1108", "RK11", 0x2000 - 0x800, false, RK_HEADER_V1 },
>>   	{ "rv1126", "110B", 0x10000 - 0x1000, false, RK_HEADER_V1 },
>> -	{ "rk3568", "RK35", 0x14000 - 0x1000, false, RK_HEADER_V2 },
>> +	{ "rk3568", "RK35", 0x10000 - 0x1000, false, RK_HEADER_V2 },
>>   };
>>   
>>   /**