From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3] net/vhost: fix segfault when creating vdev dynamically Date: Fri, 30 Mar 2018 09:35:28 +0200 Message-ID: <5fae9b23-ab90-9dc0-56b6-999e639dac64@redhat.com> References: <20180329153544.270488-1-junjie.j.chen@intel.com> <20180330065831.107558-1-junjie.j.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Junjie Chen , jianfeng.tan@intel.com, mtetsuyah@gmail.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id ADF604B4B for ; Fri, 30 Mar 2018 09:35:33 +0200 (CEST) In-Reply-To: <20180330065831.107558-1-junjie.j.chen@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Junjie, On 03/30/2018 08:58 AM, Junjie Chen wrote: > When creating vdev dynamically, vhost pmd driver starts directly without > checking TX/RX queues are ready or not, and thus causes segmentation fault > when vhost library accesses queues. This patch adds a flag to check whether > queues are setup or not, and adds queues setup into dev_start function to > allow user to start them after setting up. > > Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop") > Signed-off-by: Chen, Junjie > --- > Changes in v3: > - Update commit log, refine duplicated code > Changes in v2: > - Check queues status in new_device, create queue in dev_start if not setup yet > > drivers/net/vhost/rte_eth_vhost.c | 69 ++++++++++++++++++++++++++------------- > 1 file changed, 46 insertions(+), 23 deletions(-) Nice patch! Thanks for having handled the changes that quickly. Reviewed-by: Maxime Coquelin Maxime