From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3023861-1524769959-2-11782058832744157413 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: cc='ISO-8859-1', cc='UTF-8', plain='UTF-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1524769958; b=FGoTV9TGAC+/l6nUpQWq9Be3J0YYh0XIjwumQoV1nsHTkNaaEe EjQxgm8j553SKZEoXoGEXmERW+nrnoKjVWm5U/2cd0IKQOwfxPReHFzd0UxOWM2V HGd0PAicsABgm/DVIcIPIvunzNqclU08NhTHO6gCHiVTzVzUi0xB8jt1LpsB6z8J 5I47f6JG6tA5BDBY0vwiWLFz2W5piLU/PDVpTG9A6KwxYAO3HrNRb7r8A6qBzKdi 5fecv/vmikJI7b+8GqPpepX7es3dl+2k6kibvc+RMgC9EpXMqzx78AC2/9eXwOkX uCYBCWBpmLonlSxPgjERM6X5jBe+LzrYizPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=message-id:subject:from:to:cc:date :in-reply-to:references:content-type:mime-version :content-transfer-encoding:sender:list-id; s=fm2; t=1524769958; bh=KRGkDhre8xSPtX78yxDStnAj0ZsTf8x4HSsddJ5jRrc=; b=S5hXHBVojEE8 RwM8Nd4uxXSJTa3/CYZX4eJLh5vP6KSL+uInYoN6OfKcpxpqcyY3z/+Z+Uhc26j8 E9r9QKlew/5/kgaBlEV2nvznAd5ZJQ6R5quXWPU2wWQy0mksratAXy/OjdGNaPIa R8AcGyEX6RMJsQzARvb7G0lDIw/rOfpXeiGQBT5dJFsgcFNaDu8OVXscrufi6sRO Mgd+I9fQD/HDavsHCZ/6Plhc5u5QYleppDBcGnRvC0C96w/vdZWwC1amHlOU5exp SXKbPSHH9RpFuGD5KHbXMkmAuxG20DdEv5VGhjCJDKMdOoB7bK/1xJP2cOfbbsNs oifwCNDhOg== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=redhat.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=redhat.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=redhat.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=redhat.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfDKF935u41O3IvMr4ANU1mMPhgoLxO/JjFEi+LG5g2nXBXqYtUiXDMEx8yvRkqws8+bM3OvjLR0FHHc4CEg46pLFmoyv0bW+6ltYuwkt7HHPaiikbwYM 45btut69UsCMoCyu8wHEgHT7Fd6kAe6yoGOGSa+w+TC/JdyeUJPImhNEn/9XfErgkRcelmc0L/04H+f75BGGotg518zCfgfysq9YfEsR2cItE8fobzuKNXe9 X-CM-Analysis: v=2.3 cv=Tq3Iegfh c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=FXlSwSmEOOAvhsM-sakA:9 a=QEXdDO2ut3YA:10 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbeDZTMh (ORCPT ); Thu, 26 Apr 2018 15:12:37 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751262AbeDZTMg (ORCPT ); Thu, 26 Apr 2018 15:12:36 -0400 Message-ID: <5fb0b88573985caeb5ce2732ae217f60fbcfe965.camel@redhat.com> Subject: Re: [PATCH] USB: serial: option: adding support for ublox R410M From: Dan Williams To: Johan Hovold , Lars Melin Cc: =?ISO-8859-1?Q?Bj=F8rn?= Mork , SZ Lin =?UTF-8?Q?=28=E6=9E=97=E4=B8=8A=E6=99=BA=29?= , stable , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 26 Apr 2018 14:12:32 -0500 In-Reply-To: <20180426162921.GB335@localhost> References: <20180426062831.320-1-sz.lin@moxa.com> <20180426070927.GT4615@localhost> <72c63853-aa2d-e74c-1112-36d54ef52a85@gmail.com> <20180426081403.GA335@localhost> <87r2n25i6i.fsf@miraculix.mork.no> <3895ed90-bbb9-e7ce-34c0-a1654646cf83@gmail.com> <98b50ae7-b889-6811-476e-9cdc8a62a484@gmail.com> <20180426161228.GW4615@localhost> <09866ede-25cf-3ca1-1be6-e720b4b5dd23@gmail.com> <20180426162921.GB335@localhost> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote: > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > > On 4/26/2018 23:12, Johan Hovold wrote: > > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > > > > On 4/26/2018 18:39, Lars Melin wrote: > > > > > On 4/26/2018 18:19, Bjørn Mork wrote: > > > > > > Anyway, Qualcomm based designs are definitely handled by > > > > > > both drivers. > > > > > > Using qcserial only makes sense if the interface layout > > > > > > matches one of > > > > > > the defined shared schemes, which currently are: > > > > > > > > > > > > QCSERIAL_G2K = 0, /* Gobi 2000 */ > > > > > > QCSERIAL_G1K = 1, /* Gobi 1000 */ > > > > > > QCSERIAL_SWI = 2, /* Sierra Wireless */ > > > > > > QCSERIAL_HWI = 3, /* Huawei */ > > > > > > > > > > It seems to me that this Quectel device matches the interface > > > > > layout for > > > > > Gobi1K: > > > Yeah, but qcserial appears to select a different altsetting for > > > the DM > > > port for Gobi 1000, an altsetting which this particular device > > > does not > > > have. > > > > > > I didn't re-read the full thread I referred to earlier, but I > > > think in > > > it, Dan mentioned Gobi 1000 device requiring firmware to be > > > loaded too. > > > > > > So if it's not a G1K device, we probably shouldn't be using > > > qcserial > > > even if the interface layout happens to match. > > Good point, I forgot about the required firmware loading for > > Gobi1K. > > So this device should be handled by the option driver. > > Yeah, we probably should document all of this at some point. :) > > I didn't include the patch in this weeks -rc updates, but I've queued > it > up for the next batch. Option is likely the right driver for this device. qcaux was mainly for mobile phones that have a TTY (often cdc-acm) as the modem port and a secondary DIAG/DM port driven by qcaux. The DM port doesn't have an interrupt endpoint thus it's not a normal modem port requiring the larger buffers of option and its control signaling. qcserial (as Bjorn mentioned) is only for actual Gobi-type devices with the specific layouts and the firmware loading requirement where the 1K and 2K devices start in a special 1-port mode waiting for firmware and then become 4-port devices on firmware reboot. Dan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: adding support for ublox R410M From: Dan Williams Message-Id: <5fb0b88573985caeb5ce2732ae217f60fbcfe965.camel@redhat.com> Date: Thu, 26 Apr 2018 14:12:32 -0500 To: Johan Hovold , Lars Melin Cc: =?ISO-8859-1?Q?Bj=F8rn?= Mork , SZ Lin =?UTF-8?Q?=28=E6=9E=97=E4=B8=8A=E6=99=BA=29?= , stable , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVGh1LCAyMDE4LTA0LTI2IGF0IDE4OjI5ICswMjAwLCBKb2hhbiBIb3ZvbGQgd3JvdGU6Cj4g T24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMTE6MjI6MjVQTSArMDcwMCwgTGFycyBNZWxpbiB3cm90 ZToKPiA+IE9uIDQvMjYvMjAxOCAyMzoxMiwgSm9oYW4gSG92b2xkIHdyb3RlOgo+ID4gPiBPbiBU aHUsIEFwciAyNiwgMjAxOCBhdCAwNjo0MDo0NlBNICswNzAwLCBMYXJzIE1lbGluIHdyb3RlOgo+ ID4gPiA+IE9uIDQvMjYvMjAxOCAxODozOSwgTGFycyBNZWxpbiB3cm90ZToKPiA+ID4gPiA+IE9u IDQvMjYvMjAxOCAxODoxOSwgQmrDuHJuIE1vcmsgd3JvdGU6Cj4gPiA+ID4gPiA+IEFueXdheSwg UXVhbGNvbW0gYmFzZWQgZGVzaWducyBhcmUgZGVmaW5pdGVseSBoYW5kbGVkIGJ5Cj4gPiA+ID4g PiA+IGJvdGggZHJpdmVycy4KPiA+ID4gPiA+ID4gVXNpbmcgcWNzZXJpYWwgb25seSBtYWtlcyBz ZW5zZSBpZiB0aGUgaW50ZXJmYWNlIGxheW91dAo+ID4gPiA+ID4gPiBtYXRjaGVzIG9uZSBvZgo+ ID4gPiA+ID4gPiB0aGUgZGVmaW5lZCBzaGFyZWQgc2NoZW1lcywgd2hpY2ggY3VycmVudGx5IGFy ZToKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ICAgICAgUUNTRVJJQUxfRzJLID0gMCwgICAgLyog R29iaSAyMDAwICovCj4gPiA+ID4gPiA+ICAgICAgUUNTRVJJQUxfRzFLID0gMSwgICAgLyogR29i aSAxMDAwICovCj4gPiA+ID4gPiA+ICAgICAgUUNTRVJJQUxfU1dJID0gMiwgICAgLyogU2llcnJh IFdpcmVsZXNzICovCj4gPiA+ID4gPiA+ICAgICAgUUNTRVJJQUxfSFdJID0gMywgICAgLyogSHVh d2VpICovCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEl0IHNlZW1zIHRvIG1lIHRoYXQgdGhpcyBRdWVj dGVsIGRldmljZSBtYXRjaGVzIHRoZSBpbnRlcmZhY2UKPiA+ID4gPiA+IGxheW91dCBmb3IKPiA+ ID4gPiA+IEdvYmkxSzoKPiA+ID4gWWVhaCwgYnV0IHFjc2VyaWFsIGFwcGVhcnMgdG8gc2VsZWN0 IGEgZGlmZmVyZW50IGFsdHNldHRpbmcgZm9yCj4gPiA+IHRoZSBETQo+ID4gPiBwb3J0IGZvciBH b2JpIDEwMDAsIGFuIGFsdHNldHRpbmcgd2hpY2ggdGhpcyBwYXJ0aWN1bGFyIGRldmljZQo+ID4g PiBkb2VzIG5vdAo+ID4gPiBoYXZlLgo+ID4gPiAKPiA+ID4gSSBkaWRuJ3QgcmUtcmVhZCB0aGUg ZnVsbCB0aHJlYWQgSSByZWZlcnJlZCB0byBlYXJsaWVyLCBidXQgSQo+ID4gPiB0aGluayBpbgo+ ID4gPiBpdCwgRGFuIG1lbnRpb25lZCBHb2JpIDEwMDAgZGV2aWNlIHJlcXVpcmluZyBmaXJtd2Fy ZSB0byBiZQo+ID4gPiBsb2FkZWQgdG9vLgo+ID4gPiAKPiA+ID4gU28gaWYgaXQncyBub3QgYSBH MUsgZGV2aWNlLCB3ZSBwcm9iYWJseSBzaG91bGRuJ3QgYmUgdXNpbmcKPiA+ID4gcWNzZXJpYWwK PiA+ID4gZXZlbiBpZiB0aGUgaW50ZXJmYWNlIGxheW91dCBoYXBwZW5zIHRvIG1hdGNoLgo+ID4g R29vZCBwb2ludCwgSSBmb3Jnb3QgYWJvdXQgdGhlIHJlcXVpcmVkIGZpcm13YXJlIGxvYWRpbmcg Zm9yCj4gPiBHb2JpMUsuCj4gPiBTbyB0aGlzIGRldmljZSBzaG91bGQgYmUgaGFuZGxlZCBieSB0 aGUgb3B0aW9uIGRyaXZlci4KPiAKPiBZZWFoLCB3ZSBwcm9iYWJseSBzaG91bGQgZG9jdW1lbnQg YWxsIG9mIHRoaXMgYXQgc29tZSBwb2ludC4gOikKPiAKPiBJIGRpZG4ndCBpbmNsdWRlIHRoZSBw YXRjaCBpbiB0aGlzIHdlZWtzIC1yYyB1cGRhdGVzLCBidXQgSSd2ZSBxdWV1ZWQKPiBpdAo+IHVw IGZvciB0aGUgbmV4dCBiYXRjaC4KCk9wdGlvbiBpcyBsaWtlbHkgdGhlIHJpZ2h0IGRyaXZlciBm b3IgdGhpcyBkZXZpY2UuCgpxY2F1eCB3YXMgbWFpbmx5IGZvciBtb2JpbGUgcGhvbmVzIHRoYXQg aGF2ZSBhIFRUWSAob2Z0ZW4gY2RjLWFjbSkgYXMKdGhlIG1vZGVtIHBvcnQgYW5kIGEgc2Vjb25k YXJ5IERJQUcvRE0gcG9ydCBkcml2ZW4gYnkgcWNhdXguICBUaGUgRE0KcG9ydCBkb2Vzbid0IGhh dmUgYW4gaW50ZXJydXB0IGVuZHBvaW50IHRodXMgaXQncyBub3QgYSBub3JtYWwgbW9kZW0KcG9y dCByZXF1aXJpbmcgdGhlIGxhcmdlciBidWZmZXJzIG9mIG9wdGlvbiBhbmQgaXRzIGNvbnRyb2wg c2lnbmFsaW5nLgoKcWNzZXJpYWwgKGFzIEJqb3JuIG1lbnRpb25lZCkgaXMgb25seSBmb3IgYWN0 dWFsIEdvYmktdHlwZSBkZXZpY2VzIHdpdGgKdGhlIHNwZWNpZmljIGxheW91dHMgYW5kIHRoZSBm aXJtd2FyZSBsb2FkaW5nIHJlcXVpcmVtZW50IHdoZXJlIHRoZSAxSwphbmQgMksgZGV2aWNlcyBz dGFydCBpbiBhIHNwZWNpYWwgMS1wb3J0IG1vZGUgd2FpdGluZyBmb3IgZmlybXdhcmUgYW5kCnRo ZW4gYmVjb21lIDQtcG9ydCBkZXZpY2VzIG9uIGZpcm13YXJlIHJlYm9vdC4KCkRhbgotLS0KVG8g dW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxp bnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5l bC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpv cmRvbW8taW5mby5odG1sCg==