All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Greg KH <gregkh@linuxfoundation.org>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Sanan Hasanov <sanan.hasanov@knights.ucf.edu>
Subject: Re: [PATCHv2] fbcon: Check font dimension limits
Date: Sat, 4 Feb 2023 14:31:22 +0100	[thread overview]
Message-ID: <5fcd25ee-07bb-6eab-3e73-22680a0104bf@gmx.de> (raw)
In-Reply-To: <Y9kq4ZoBs8LkEtqs@kroah.com>

On 1/31/23 15:51, Greg KH wrote:
> On Sun, Jan 29, 2023 at 04:17:40PM +0100, Samuel Thibault wrote:
>> blit_x and blit_y are u32, so fbcon currently cannot support fonts
>> larger than 32x32.
>>
>> The 32x32 case also needs shifting an unsigned int, to properly set bit
>> 31, otherwise we get "UBSAN: shift-out-of-bounds in fbcon_set_font",
>> as reported on:
>>
>> http://lore.kernel.org/all/IA1PR07MB98308653E259A6F2CE94A4AFABCE9@IA1PR07MB9830.namprd07.prod.outlook.com
>> Kernel Branch: 6.2.0-rc5-next-20230124
>> Kernel config: https://drive.google.com/file/d/1F-LszDAizEEH0ZX0HcSR06v5q8FPl2Uv/view?usp=sharing
>> Reproducer: https://drive.google.com/file/d/1mP1jcLBY7vWCNM60OMf-ogw-urQRjNrm/view?usp=sharing
>>
>> Reported-by: Sanan Hasanov <sanan.hasanov@Knights.ucf.edu>
>> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> Fixes: 2d2699d98492 ("fbcon: font setting should check limitation of driver")
>> Cc: stable@vger.kernel.org
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

applied to fbdev git tree.

Thanks!
Helge

      reply	other threads:[~2023-02-04 13:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 15:17 [PATCHv2] fbcon: Check font dimension limits Samuel Thibault
2023-01-29 15:17 ` Samuel Thibault
2023-01-29 17:09 ` Miko Larsson
2023-01-29 17:09   ` Miko Larsson
2023-01-31 14:51 ` Greg KH
2023-02-04 13:31   ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fcd25ee-07bb-6eab-3e73-22680a0104bf@gmx.de \
    --to=deller@gmx.de \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sanan.hasanov@knights.ucf.edu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.