From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754596AbdBHOe7 (ORCPT ); Wed, 8 Feb 2017 09:34:59 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:10157 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752714AbdBHOev (ORCPT ); Wed, 8 Feb 2017 09:34:51 -0500 X-AuditID: cbfec7f1-f793f6d000007796-5f-589b269fe418 Subject: Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface To: Joerg Roedel Cc: Will Deacon , Robin Murphy , Lorenzo Pieralisi , Alex Williamson , David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Marek Szyprowski Message-id: <5fef7241-bb87-54ed-2516-d3207334274d@samsung.com> Date: Wed, 08 Feb 2017 15:09:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-version: 1.0 In-reply-to: <20170208135742.GE7339@8bytes.org> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsWy7djPc7rz1WZHGBz+yWXx7X8Pm8XElZOZ LRbst7bonL2B3WLyqblMFpseX2O1uLxrDpvFjPP7mCze/H7BbnHwwxNWi5cfT7A4cHs8OTiP yWPNvDWMHptXaHlsXlLvMfnGckaP9/uusnlsPl3t8XmTXABHFJdNSmpOZllqkb5dAlfG89tf mAsec1Vc2bGBrYHxPUcXIyeHhICJxK+9f1khbDGJC/fWs3UxcnEICSxllNi49hEjhPOZUaL9 2g8WmI6GoweYIRLLGCVaj16GannOKDGxqQusSlggTOLC0fOMILaIgJLE9c+trCBFzAKNzBI3 9zSwgSTYBAwlut52gdm8AnYSU3ramEFsFgFVif7WY2C2qECMRO+macwQNYISPybfA1vAKaAv sXH7abBeZgEriWf/WlkhbHmJzWvegp0nIXCJXeLorlagBg4gR1Zi0wFmiBdcJHoOrYJ6R1ji 1fEt7BC2jERnx0EmCLufUaKpVRvCnsEoce4tL4RtLXH4+EWoXXwSk7ZNZ4YYzyvR0SYEYXpI HH2aAlHtKLH+2AR2SPgsYZJY+u8m4wRG+VlIvpmF5INZSD5YwMi8ilEktbQ4Nz212EivODG3 uDQvXS85P3cTIzAdnf53/OMOxvcnrA4xCnAwKvHwXoiaFSHEmlhWXJl7iFGCg1lJhDdKdXaE EG9KYmVValF+fFFpTmrxIUZpDhYlcd49C66ECwmkJ5akZqemFqQWwWSZODilGhgnyvhLzla4 92qmoMAf0QjWltazX2wrS6w23rnxe92hNawreLY2H9j3Vvh/wFXWrPS80P7HO8rEvY4bNESs FhU69jVh/USZaymrXmyWshPWWLix7DVL/e0qxf+yqr3MHrGCKyIrvmafWc0eHr/OZZ2jtDyL lN4DhhfHtm5TNnTnV43Y/PZ0f4gSS3FGoqEWc1FxIgDXetAEQwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsVy+t/xy7ov1WZHGHSc5bb49r+HzWLiysnM Fgv2W1t0zt7AbjH51Fwmi02Pr7FaXN41h81ixvl9TBZvfr9gtzj44QmrxcuPJ1gcuD2eHJzH 5LFm3hpGj80rtDw2L6n3mHxjOaPH+31X2Tw2n672+LxJLoAjys0mIzUxJbVIITUvOT8lMy/d Vik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Zz29/YS54zFVxZccG tgbG9xxdjJwcEgImEg1HDzBD2GISF+6tZ+ti5OIQEljCKPF46XsmCOc5o8Tb662MIFXCAmES F46eB7NFBJQkrn9uZYXqYJL42/ieFSTBLNDILPFysQSIzSZgKNH1tosNxOYVsJOY0tMGto5F QFWiv/UYmC0qECOxt/8+E0SNoMSPyfdYQGxOAX2JjdtPs0HMNJP48vIw1Hx5ic1r3jJPYBSY haRlFpKyWUjKFjAyr2IUSS0tzk3PLTbUK07MLS7NS9dLzs/dxAiMzm3Hfm7ewXhpY/AhRgEO RiUe3gtRsyKEWBPLiitzDzFKcDArifBGqc6OEOJNSaysSi3Kjy8qzUktPsRoCvTERGYp0eR8 YOLIK4k3NDE0tzQ0MrawMDcyUhLnLflwJVxIID2xJDU7NbUgtQimj4mDU6qBMSBLNGj5z1WZ jj//M/q82rx85cv5HExZ51Z/9ytd9etQfvycL4l90xQnK5x5c7X14Cehqduv5TIduubMHemv 5RVhuMhTmyH7SL+ZSU73ir0f5rHf0L3cu4Q/TCM04OietxenbjGeuFGM9WD7iona2Q/m2h14 YzlxXwvHse9PoqSf/e862nw394USS3FGoqEWc1FxIgB2I5yX5AIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170208140934eucas1p1034e933c08f7a9f38f4d2053650836d6 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170206161330epcas3p185c7719afc89ab2ad87e55e9f62ccfa1 X-RootMTR: 20170206161330epcas3p185c7719afc89ab2ad87e55e9f62ccfa1 References: <1486397429-29327-1-git-send-email-joro@8bytes.org> <1486397429-29327-10-git-send-email-joro@8bytes.org> <3e4709a7-2231-7c76-18bd-6e2d6b802b8e@samsung.com> <20170208135742.GE7339@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On 2017-02-08 14:57, Joerg Roedel wrote: > On Tue, Feb 07, 2017 at 01:36:15PM +0100, Marek Szyprowski wrote: >>> + ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, >>> + "sysmmu.%pa", &ioaddr); >> Can we stick to the common name across the /sysfs and use >> dev_name(data->sysmmu) >> or even dev_name(dev) here? >> >> ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, >> dev_name(dev)); > That means that we have multiple 'struct device' with the same name, > no? I think will lead to confusion when using dev_printk, as its not > clear anymore which device is refered to in the message. Each sysmmu device has unique name, like every other platform device instantiated from device tree. Here is an example from the OdroidXU3 (Exynos5422 based): # ls -1 /sys/bus/platform/devices/ | grep sysmmu 10a60000.sysmmu 10a70000.sysmmu 11200000.sysmmu 11210000.sysmmu 11d40000.sysmmu 11f10000.sysmmu 11f20000.sysmmu 12880000.sysmmu 12890000.sysmmu 128a0000.sysmmu 128c0000.sysmmu 128d0000.sysmmu 128e0000.sysmmu 13e80000.sysmmu 13e90000.sysmmu 14640000.sysmmu 14650000.sysmmu 14680000.sysmmu IMHO there is no need for open coding new unique names if device name, which already contains the base address, can be used instead. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface Date: Wed, 08 Feb 2017 15:09:33 +0100 Message-ID: <5fef7241-bb87-54ed-2516-d3207334274d@samsung.com> References: <1486397429-29327-1-git-send-email-joro@8bytes.org> <1486397429-29327-10-git-send-email-joro@8bytes.org> <3e4709a7-2231-7c76-18bd-6e2d6b802b8e@samsung.com> <20170208135742.GE7339@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20170208135742.GE7339-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: David Woodhouse , Will Deacon , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joerg Roedel , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org Hi Joerg, On 2017-02-08 14:57, Joerg Roedel wrote: > On Tue, Feb 07, 2017 at 01:36:15PM +0100, Marek Szyprowski wrote: >>> + ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, >>> + "sysmmu.%pa", &ioaddr); >> Can we stick to the common name across the /sysfs and use >> dev_name(data->sysmmu) >> or even dev_name(dev) here? >> >> ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, >> dev_name(dev)); > That means that we have multiple 'struct device' with the same name, > no? I think will lead to confusion when using dev_printk, as its not > clear anymore which device is refered to in the message. Each sysmmu device has unique name, like every other platform device instantiated from device tree. Here is an example from the OdroidXU3 (Exynos5422 based): # ls -1 /sys/bus/platform/devices/ | grep sysmmu 10a60000.sysmmu 10a70000.sysmmu 11200000.sysmmu 11210000.sysmmu 11d40000.sysmmu 11f10000.sysmmu 11f20000.sysmmu 12880000.sysmmu 12890000.sysmmu 128a0000.sysmmu 128c0000.sysmmu 128d0000.sysmmu 128e0000.sysmmu 13e80000.sysmmu 13e90000.sysmmu 14640000.sysmmu 14650000.sysmmu 14680000.sysmmu IMHO there is no need for open coding new unique names if device name, which already contains the base address, can be used instead. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Wed, 08 Feb 2017 15:09:33 +0100 Subject: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface In-Reply-To: <20170208135742.GE7339@8bytes.org> References: <1486397429-29327-1-git-send-email-joro@8bytes.org> <1486397429-29327-10-git-send-email-joro@8bytes.org> <3e4709a7-2231-7c76-18bd-6e2d6b802b8e@samsung.com> <20170208135742.GE7339@8bytes.org> Message-ID: <5fef7241-bb87-54ed-2516-d3207334274d@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joerg, On 2017-02-08 14:57, Joerg Roedel wrote: > On Tue, Feb 07, 2017 at 01:36:15PM +0100, Marek Szyprowski wrote: >>> + ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, >>> + "sysmmu.%pa", &ioaddr); >> Can we stick to the common name across the /sysfs and use >> dev_name(data->sysmmu) >> or even dev_name(dev) here? >> >> ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, >> dev_name(dev)); > That means that we have multiple 'struct device' with the same name, > no? I think will lead to confusion when using dev_printk, as its not > clear anymore which device is refered to in the message. Each sysmmu device has unique name, like every other platform device instantiated from device tree. Here is an example from the OdroidXU3 (Exynos5422 based): # ls -1 /sys/bus/platform/devices/ | grep sysmmu 10a60000.sysmmu 10a70000.sysmmu 11200000.sysmmu 11210000.sysmmu 11d40000.sysmmu 11f10000.sysmmu 11f20000.sysmmu 12880000.sysmmu 12890000.sysmmu 128a0000.sysmmu 128c0000.sysmmu 128d0000.sysmmu 128e0000.sysmmu 13e80000.sysmmu 13e90000.sysmmu 14640000.sysmmu 14650000.sysmmu 14680000.sysmmu IMHO there is no need for open coding new unique names if device name, which already contains the base address, can be used instead. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland