From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Martin Ågren" <martin.agren@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: Thomas Ackermann via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Thomas Ackermann <th.acker@arcor.de>
Subject: Re: [PATCH] doc: fix some typos
Date: Sat, 02 Jan 2021 17:40:17 -0600 [thread overview]
Message-ID: <5ff1046161825_b3a4208be@natae.notmuch> (raw)
In-Reply-To: <CAN0heSq3q1X8jJqBkHtrTxaxJ4xfw5kQtH+b8GG9OWRXHExt+g@mail.gmail.com>
Martin Ågren wrote:
> On Sat, 2 Jan 2021 at 23:26, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > Martin Ågren wrote:
> > > #if 0
> > > #error might or mightn't work
> > > #endif
> >
> > But this works:
> >
> > #error "might or mightn't work"
[...]
> And now I ended up laying out my thoughts anyway. :-) Of course, others
> may well disagree with me about this being code churn.
Either way it's not integral to the rest of the patch. The change can
be dropped, or fixed properly. It probably doesn't matter much.
--
Felipe Contreras
next prev parent reply other threads:[~2021-01-02 23:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 17:40 [PATCH] doc: fix some typos Thomas Ackermann via GitGitGadget
2021-01-02 21:53 ` Martin Ågren
2021-01-02 22:26 ` Felipe Contreras
2021-01-02 22:59 ` Martin Ågren
2021-01-02 23:40 ` Felipe Contreras [this message]
2021-01-03 14:50 ` Chris Torek
2021-01-03 14:25 ` [PATCH v2] " Thomas Ackermann via GitGitGadget
2021-01-03 17:06 ` Martin Ågren
2021-01-06 6:05 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2020-06-16 21:03 [PATCH] " Luc Van Oostenryck
2016-09-01 11:02 Juergen Gross
2016-09-02 8:30 ` Wei Liu
2016-09-02 8:57 ` Wei Liu
2013-09-14 3:49 Xishi Qiu
2013-09-14 16:49 ` Randy Dunlap
2013-09-16 1:42 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff1046161825_b3a4208be@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=th.acker@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.