Re: [PATCH v2 2/2] pmic: pca9450: Add regulator driver

[Marek Vasut <marex@denx.de>]

On 5/20/22 00:24, Tim Harvey wrote:

[...]

>> diff --git a/include/power/pca9450.h b/include/power/pca9450.h
>> index 27703bb1f91..b714fc3477d 100644
>> --- a/include/power/pca9450.h
>> +++ b/include/power/pca9450.h
>> @@ -56,4 +56,15 @@ enum {
>>
>>   int power_pca9450_init(unsigned char bus, unsigned char addr);
>>
>> +enum {
>> +       NXP_CHIP_TYPE_PCA9450A = 0,
>> +       NXP_CHIP_TYPE_PCA9450BC,
>> +       NXP_CHIP_TYPE_AMOUNT
>> +};
>> +
>> +#define DVS_BUCK_RUN_MASK              0x7f
> 
> Marek,
> 
> Looks like DVS_BUCK_RUN_MASK is a bad choice of names and should be
> something like PCA9450_DVS_BUCK_RUN_MASK.
> 
> It's defined differently in include/power/bd71837.h (where it should
> also likely be changed to something that doesn't collide)
> $ git grep DVS_BUCK_RUN_MASK include/
> include/power/bd71837.h:#define DVS_BUCK_RUN_MASK               0x3f
> include/power/pca9450.h:#define DVS_BUCK_RUN_MASK               0x7f
> 
> Granted, board/gateworks/venice/spl.c is the only file I see that
> includes both of those.
> 
> Is this merged yet?

No, I am eagerly waiting for this to be merged.

I sent V3, that should address the ventana .