From: Wenlin Kang <wenlin.kang@windriver.com>
To: Richard Leitner <richard.leitner@skidata.com>,
<openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-java][PATCH 2/2] openjdk-8: combine the -dbg package
Date: Fri, 8 Jun 2018 17:02:38 +0800 [thread overview]
Message-ID: <5ffe90b0-c8ab-dfe4-99c4-d63d53edc8ec@windriver.com> (raw)
In-Reply-To: <2dae9a9a-a6e4-1c01-d167-0dc92f9e1bbf@skidata.com>
On 2018年06月08日 15:39, Richard Leitner wrote:
> Hi,
> thank you for you patch!
>
> On 06/07/2018 11:24 AM, Wenlin Kang wrote:
>> One recipe should only have one -dbg package, because OE only picks
>> up all .debug file into the last one -dbg package listed in variable
>> PACKAGES.
> Why should one recipe, altough it conains multiple packages have only
> one dbg package? Shouldn't the openjdk-8-demo-dbg package contain the
> debug information for the openjdk-8-demo package?
This may be OE's policy, if one recipe contain multiple -dbg package ,
other -dbg packages all will be
a empty pacakge, only have one will contain all .debug file, you can
see the source "meta/classes/package.bbclass"
1129 python populate_packages () {
1130 import glob, re
1156 for pkg in packages.split():
1157 if pkg in package_list:
1158 msg = "%s is listed in PACKAGES multiple times, this
leads to packaging errors." % pkg
1159 package_qa_handle_error("packages-list", msg, d)
1160 # If debug-with-srcpkg mode is enabled then the src package
will have
1161 # priority over dbg package when assigning the files.
1162 # This allows src package to include source files and
remove them from dbg.
1163 elif split_source_package and pkg.endswith("-src"):
1164 package_list.insert(0, pkg)
1165 elif autodebug and pkg.endswith("-dbg") and not
split_source_package: <==============
1166 package_list.insert(0, pkg)
1167 else:
1168 package_list.append(pkg)
1169 d.setVar('PACKAGES', ' '.join(package_list))
1170 pkgdest = d.getVar('PKGDEST')
...
1177 debug = []
1178 for root, dirs, files in cpath.walk(dvar):
1179 dir = root[len(dvar):]
1180 if not dir:
1181 dir = os.sep
1182 for f in (files + dirs):
1183 path = "." + os.path.join(dir, f)
1184 if "/.debug/" in path or path.endswith("/.debug"):
<==============
1185 debug.append(path)
1186
>
> Nonehteless according to my first quick test the demo-dbg package
> contains lots of other debug information too...
> So maybe it would be the better way to fix the content of the different
> dbg packages rather than removing one?
I also thought this, but after discussing with the other guys, the
result is a recipe can only have
a -dbg package, and this is OE's policy.
>
> But I'm of course open for discussions ;-)
>
>> Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com>
>> ---
>> recipes-core/openjdk/openjdk-8_16xbyy.bb | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
> regards;Richard.L
--
Thanks,
Wenlin Kang
next prev parent reply other threads:[~2018-06-08 9:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 9:24 [meta-java][PATCH 1/2] openjdk-8: remove debuglink Wenlin Kang
2018-06-07 9:24 ` [meta-java][PATCH 2/2] openjdk-8: combine the -dbg package Wenlin Kang
2018-06-08 7:39 ` Richard Leitner
2018-06-08 9:02 ` Wenlin Kang [this message]
2018-06-08 9:10 ` Wenlin Kang
2018-06-08 10:07 ` Richard Leitner
2018-06-11 6:31 ` Robert Yang
2018-06-12 7:59 ` Richard Leitner
2018-06-11 6:49 ` Wenlin Kang
2018-06-12 8:01 ` Richard Leitner
2018-06-12 10:59 ` Wenlin Kang
2018-06-12 11:09 ` Richard Leitner
2018-06-12 11:14 ` Wenlin Kang
2018-06-12 11:09 ` [meta-java][PATCH 1/2] openjdk-8: remove debuglink Richard Leitner
2018-06-12 11:35 ` Wenlin Kang
2018-06-12 12:02 ` Wenlin Kang
2018-06-12 12:47 ` Richard Leitner
2018-06-13 6:35 ` Wenlin Kang
2018-06-13 6:43 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ffe90b0-c8ab-dfe4-99c4-d63d53edc8ec@windriver.com \
--to=wenlin.kang@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.