From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494C423B8 for ; Wed, 16 Feb 2022 10:38:06 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id k1so2687938wrd.8 for ; Wed, 16 Feb 2022 02:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kynesim-co-uk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:references:in-reply-to :user-agent:mime-version:content-transfer-encoding; bh=APHlIlTusvMgXPnzCwNHewW1Pmh8VQG7NFIzezTRaNc=; b=7SAEIHiNv/S2j8S85O0RqIFmpOnK9JmFy6fZZy/cWWitNEJvmTtqRpcFZOTR41jMmh /xyqhwRwGsBJgWACzWbu9Qe+No/2QrimVxSWe0vXZi1P2OqcV4RUZx80PlrLc8svLplb Gi1gvZogG1XZogoQfHf4LHE9sypz4p1TTIYGOrSxXl3+7pni49tpT7ZwG2dxP36hRx4z B3M/bF7e4XKFPaFZE1dTnkjWokWarDsnWkn2gkY5En+aPjHyYiWc02HTV9VH2mwQIUGD 9BqvmwGsOvay1iOZXkzHjslH4hiqYlcZOdtvpOiezB/05AotqJRMyk/inF5oEUZG91TG nEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:references :in-reply-to:user-agent:mime-version:content-transfer-encoding; bh=APHlIlTusvMgXPnzCwNHewW1Pmh8VQG7NFIzezTRaNc=; b=6UZ3CeDlyg9DMeLkdIjiRBGoGAsThLenYFqSBNr9ZZbwjXp/fqh9ekGflxqYXkZsOM g40J79NyGvmkAot4n+aPOkS5XhDpQNWVaf/fXSCnHx20NcOB1od0I2q0Ftc9D1K+meMN lMKgJcMwtBeLvwgE+1JlOYYagg2XVARJ7hrOw2e6ZpErcVDR0ZqNURsNg+8busWoujRq iCL0AnsVLr0F5oNP83kBXOovtkx+F0m7P/JLq7C0NYdT0vbkmsnvuwqR6F13rsuU7iV0 LPLr1MwXT4cIUhMxF3I1SZ17+GDf3YEWKtm7GulTJX01kK969DQblWF53S0qr2C9HO0v W9Pg== X-Gm-Message-State: AOAM531aM7067Xtw2EEXwP4/k7NESiEor7ynaSTZRuhpvbfJNOF8d38m ZVh53KsMRsDPNYh22zKdPcG1BA== X-Google-Smtp-Source: ABdhPJyOXVhasI5kNN4XMRmvxSGVY64NlM3BrwNXdHZ73Xkozk0MQxwjPk9APXEqNUpZuolRZ9eeKg== X-Received: by 2002:a5d:518d:0:b0:1e5:8cc9:5aa4 with SMTP id k13-20020a5d518d000000b001e58cc95aa4mr1733704wrv.119.1645007884357; Wed, 16 Feb 2022 02:38:04 -0800 (PST) Received: from CTHALPA.outer.uphall.net (cpc1-cmbg20-2-0-cust759.5-4.cable.virginm.net. [86.21.218.248]) by smtp.gmail.com with ESMTPSA id r11sm13099446wmb.19.2022.02.16.02.38.03 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 16 Feb 2022 02:38:03 -0800 (PST) From: John Cox To: =?utf-8?Q?Jernej_=C5=A0krabec?= Cc: Nicolas Dufresne , Benjamin Gaignard , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, hverkuil-cisco@xs4all.nl, jonas@kwiboo.se, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com Subject: Re: [RFC v2 6/8] media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params Date: Wed, 16 Feb 2022 10:38:02 +0000 Message-ID: <5nkp0htimo1d7tip46id5pmvt69sqakdrm@4ax.com> References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> <2071229.OBFZWjSADL@kista> <3tkn0ht1cjbpr3meuputqpuvpfcq3gkrd5@4ax.com> <11921127.O9o76ZdvQC@kista> In-Reply-To: <11921127.O9o76ZdvQC@kista> User-Agent: ForteAgent/8.00.32.1272 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 15 Feb 2022 21:27:30 +0100, you wrote: >Dne torek, 15. februar 2022 ob 17:31:28 CET je John Cox napisal(a): >> On Tue, 15 Feb 2022 17:11:12 +0100, you wrote: >>=20 >> >Dne torek, 15. februar 2022 ob 17:00:33 CET je John Cox napisal(a): >> >> On Tue, 15 Feb 2022 10:28:55 -0500, you wrote: >> >>=20 >> >> >Le mardi 15 f=C3=A9vrier 2022 =C3=A0 14:50 +0000, John Cox a = =C3=A9crit : >> >> >> On Tue, 15 Feb 2022 15:35:12 +0100, you wrote: >> >> >>=20 >> >> >> >=20 >> >> >> > Le 15/02/2022 =C3=A0 15:17, John Cox a =C3=A9crit : >> >> >> > > Hi >> >> >> > >=20 >> >> >> > > > The bit size of the slice could be deduced from the buffer= =20 >payload >> >> >> > > > so remove bit_size field to avoid duplicated the = information. >> >> >> > > I think this is a bad idea. In the future we are (I hope) = going to=20 >> >want >> >> >> > > to have an array (variable) of slice headers all referring = to the=20 >> >same >> >> >> > > bit buffer. When we do that we will need this field. >> >> >> >=20 >> >> >> > I wonder if that could be considering like another decode mode= and=20 >so >> >> >> > use an other control ? >> >> >>=20 >> >> >> I, personally, would be in favour of making the slice header = control a >> >> >> variable array just as it is. If userland can't cope with = multiple >> >> >> entries then just send them one at a time and the code looks = exactly >> >> >> like it does at the moment and if the driver can't then set max = array >> >> >> entries to 1. >> >> >>=20 >> >> >> Having implemented this in rpi port of ffmpeg and the RPi V4L2 = driver I >> >> >> can say with experience that the code and effort overhead is = very low. >> >> >>=20 >> >> >> Either way having a multiple slice header control in the UAPI is >> >> >> important for efficiency. >> >> > >> >> >Just to clarify the idea, we would have a single slice controls, = always=20 >> >dynamic: >> >> > >> >> >1. For sliced based decoder >> >> > >> >> >The dynamic array slice control is implemented by the driver and = its=20 >size=20 >> >must >> >> >be 1. >> >>=20 >> >> Yes >> >>=20 >> >> >2. For frame based decoder that don't care for slices >> >> > >> >> >The dynamic array slice controls is not implement. Userland = detects that=20 >at >> >> >runtime, similar to the VP9 compressed headers. >> >>=20 >> >> If the driver parses all the slice header then that seems plausible >> >>=20 >> >> >3. For frame based decoders that needs slices (or driver that = supports=20 >> >offset >> >> >and can gain performance with such mode) >> >> > >> >> >The dynamic array slice controls is implemented, and should = contain all=20 >the >> >> >slices found in the OUTPUT buffer. >> >> > >> >> >So the reason for this bit_size (not sure why its bits though, = perhaps=20 >> >someone >> >> >can educate me ?) >> >>=20 >> >> RPi doesn't need bits and would be happy with bytes however >> >> slice_segment data isn't byte aligned at the end so its possible = that >> >> there might be decoders out there that want an accurate length for = that. >> > >> >There are two fields, please don't mix them up: >> > >> >__u32 bit_size; >> >__u32 data_bit_offset; (changed to data_byte_offset in this series) >> > >> >data_bit_offset/data_byte_offset is useful, while bit_size is IMO = not. If you=20 >> >have multiple slices in array, you only need to know start of the = slice=20 >data=20 >> >and that offset is always offset from start of the buffer (absolute, = it's not=20 >> >relative to previous slice data). >>=20 >> No... or at least I think not. RPi needs the start and end of the >> slice_segment_data elements of each slice.=20 > >It would be good to know if size needs to be exact or can overshoot, = like=20 >using end of buffer for that. > >Cedrus also wants to know slice data size, but it turns out that bigger = than=20 >necessary size doesn't pose any problems. If that's not the case, then=20 >bit_size needs stay in for sure. RPi needs the exact size (bytes will do - but I don't see the harm in specifying it in bits in case some future h/w wants the extra precision as long as we nail down exactly which bit we mean) Regards JC >Best regards, >Jernej > >> If slices are arranged in the >> buffer with slice_segment_headers attached then I don't see how I get = to >> know that. Also if the OUTPUT buffer is just a bit of bitstream, = which >> might well be very convienient for some userspace, then it is = legitimate >> to have SEIs between slice headers so you can't even guarantee that = your >> coded slice segments are contiguous. >>=20 >> Regards >>=20 >> JC >>=20 >> >Best regards, >> >Jernej >> > >> >>=20 >> >> > Would be to let the driver offset inside the the single >> >> >OUTPUT/bitstream buffer in case this is not automatically found by= the=20 >> >driver >> >> >(or that no start-code is needed). Is that last bit correct ? If = so,=20 >should=20 >> >we >> >> >change it to an offset rather then a size ? Shall we allow using = offesets=20 >> >inside >> >> >larger buffer (e.g. to avoid some memory copies) for the Sliced = Base=20 >cases ? >> >>=20 >> >> I use (in the current structure) data_bit_offset to find the start = of >> >> each slice's slice_segment_data within the OUTPUT buffer and = bit_size to >> >> find the end. RPi doesn't / can't parse the slice_header and so = wants >> >> all of that. Decoders that do parse the header might plausably = want >> >> header offsets too and it would facilitate zero copy of the bit = buffer. >> >>=20 >> >> =20 >> >> >> Regards >> >> >>=20 >> >> >> John Cox >> >> >>=20 >> >> >> > > > Signed-off-by: Benjamin Gaignard=20 > >> >> >> > > > --- >> >> >> > > > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 3= --- >> >> >> > > > drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 11= +++ >> >+------- >> >> >> > > > include/uapi/linux/v4l2-controls.h | 3= +-- >> >> >> > > > 3 files changed, 5 insertions(+), 12 deletions(-) >> >> >> > > >=20 >> >> >> > > > diff --git = a/Documentation/userspace-api/media/v4l/ext-ctrls- >> >codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> >> >> > > > index 3296ac3b9fca..c3ae97657fa7 100644 >> >> >> > > > --- = a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> >> >> > > > +++ = b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> >> >> > > > @@ -2965,9 +2965,6 @@ enum=20 >v4l2_mpeg_video_hevc_size_of_length_field=20 >> >- >> >> >> > > > :stub-columns: 0 >> >> >> > > > :widths: 1 1 2 >> >> >> > > >=20 >> >> >> > > > - * - __u32 >> >> >> > > > - - ``bit_size`` >> >> >> > > > - - Size (in bits) of the current slice data. >> >> >> > > > * - __u32 >> >> >> > > > - ``data_bit_offset`` >> >> >> > > > - Offset (in bits) to the video data in the current= slice=20 >> >data. >> >> >> > > > diff --git = a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c b/ >> >drivers/staging/media/sunxi/cedrus/cedrus_h265.c >> >> >> > > > index 8ab2d9c6f048..db8c7475eeb8 100644 >> >> >> > > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c >> >> >> > > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c >> >> >> > > > @@ -312,8 +312,8 @@ static void cedrus_h265_setup(struct=20 >cedrus_ctx=20 >> >*ctx, >> >> >> > > > const struct v4l2_hevc_pred_weight_table=20 >*pred_weight_table; >> >> >> > > > unsigned int width_in_ctb_luma, ctb_size_luma; >> >> >> > > > unsigned int log2_max_luma_coding_block_size; >> >> >> > > > + size_t slice_bytes; >> >> >> > > > dma_addr_t src_buf_addr; >> >> >> > > > - dma_addr_t src_buf_end_addr; >> >> >> > > > u32 chroma_log2_weight_denom; >> >> >> > > > u32 output_pic_list_index; >> >> >> > > > u32 pic_order_cnt[2]; >> >> >> > > > @@ -370,8 +370,8 @@ static void cedrus_h265_setup(struct=20 >cedrus_ctx=20 >> >*ctx, >> >> >> > > >=20 >> >> >> > > > cedrus_write(dev, VE_DEC_H265_BITS_OFFSET, 0); >> >> >> > > >=20 >> >> >> > > > - reg =3D slice_params->bit_size; >> >> >> > > > - cedrus_write(dev, VE_DEC_H265_BITS_LEN, reg); >> >> >> > > > + slice_bytes =3D vb2_get_plane_payload(&run->src- >>vb2_buf, 0); >> >> >> > > > + cedrus_write(dev, VE_DEC_H265_BITS_LEN, slice_bytes); >> >> >> > > I think one of these must be wrong. bit_size is in bits, >> >> >> > > vb2_get_plane_payload is in bytes? >> >> >> >=20 >> >> >> > You are right it should be vb2_get_plane_payload() * 8 to get = the=20 >size=20 >> >in bits. >> >> >> >=20 >> >> >> > I will change that in v3. >> >> >> >=20 >> >> >> > >=20 >> >> >> > > Regards >> >> >> > >=20 >> >> >> > > John Cox >> >> >> > > =20 >> >> >> > > > /* Source beginning and end addresses. */ >> >> >> > > >=20 >> >> >> > > > @@ -384,10 +384,7 @@ static void cedrus_h265_setup(struct=20 >> >cedrus_ctx *ctx, >> >> >> > > >=20 >> >> >> > > > cedrus_write(dev, VE_DEC_H265_BITS_ADDR, reg); >> >> >> > > >=20 >> >> >> > > > - src_buf_end_addr =3D src_buf_addr + >> >> >> > > > - DIV_ROUND_UP(slice_params- >>bit_size,=20 >> >8); >> >> >> > > > - >> >> >> > > > - reg =3D=20 >VE_DEC_H265_BITS_END_ADDR_BASE(src_buf_end_addr); >> >> >> > > > + reg =3D VE_DEC_H265_BITS_END_ADDR_BASE(src_buf_addr +=20 >slice_bytes); >> >> >> > > > cedrus_write(dev, VE_DEC_H265_BITS_END_ADDR, reg); >> >> >> > > >=20 >> >> >> > > > /* Coding tree block address */ >> >> >> > > > diff --git a/include/uapi/linux/v4l2-controls.h = b/include/uapi/ >> >linux/v4l2-controls.h >> >> >> > > > index b1a3dc05f02f..27f5d272dc43 100644 >> >> >> > > > --- a/include/uapi/linux/v4l2-controls.h >> >> >> > > > +++ b/include/uapi/linux/v4l2-controls.h >> >> >> > > > @@ -2457,7 +2457,6 @@ struct v4l2_hevc_pred_weight_table { >> >> >> > > > #define = V4L2_HEVC_SLICE_PARAMS_FLAG_DEPENDENT_SLICE_SEGMENT=09 >> >(1ULL << 9) >> >> >> > > >=20 >> >> >> > > > struct v4l2_ctrl_hevc_slice_params { >> >> >> > > > - __u32 bit_size; >> >> >> > > > __u32 data_bit_offset; >> >> >> > > >=20 >> >> >> > > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: NAL unit header=20 >*/ >> >> >> > > > @@ -2484,7 +2483,7 @@ struct v4l2_ctrl_hevc_slice_params { >> >> >> > > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: Picture timing=20 >SEI message=20 >> >*/ >> >> >> > > > __u8 pic_struct; >> >> >> > > >=20 >> >> >> > > > - __u8 reserved; >> >> >> > > > + __u8 reserved[5]; >> >> >> > > >=20 >> >> >> > > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: General slice=20 >segment=20 >> >header */ >> >> >> > > > __u32 slice_segment_addr; >> >>=20 >> > >>=20 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76136C433EF for ; Wed, 16 Feb 2022 10:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7d9Ks8maC13cvQFZx7aS7JlFsmdKAWQtU/vOQWzZl28=; b=Njr0WdkFH/SCnX 8bR2EvuHY8nT46R5m/E2wP7P1wm8EDhyYBVzVl/LZ/9HryQ/nkFWqQZyzB6fj/WBLQWBXGNx8ARsV h75wHgZZKKNnzt6LSyYQvhEmWF1aposayb4h8M5KBIXRgV3VgHPvvZ3UiVMACRXNRdlvg1DDwMCa+ D/r3WfnljdeJu939tiKpuzp0GAmcUh/UUvIRc83RSmpvex6s5O8jfbNhjijI+zDkkohzJBCtZIfgr MtN1bRNtlwaWEsq0g0xt8jU1Zox87MtHjqdh/QJHCQcb0seeWo7xb22XBHSuao0jsFT7tahQKVBct SII1RBwldWUJaqalesBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKHhN-006Zwo-5q; Wed, 16 Feb 2022 10:38:13 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKHhG-006ZvO-BZ for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 10:38:10 +0000 Received: by mail-wr1-x42a.google.com with SMTP id p9so2655255wra.12 for ; Wed, 16 Feb 2022 02:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kynesim-co-uk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:references:in-reply-to :user-agent:mime-version:content-transfer-encoding; bh=APHlIlTusvMgXPnzCwNHewW1Pmh8VQG7NFIzezTRaNc=; b=7SAEIHiNv/S2j8S85O0RqIFmpOnK9JmFy6fZZy/cWWitNEJvmTtqRpcFZOTR41jMmh /xyqhwRwGsBJgWACzWbu9Qe+No/2QrimVxSWe0vXZi1P2OqcV4RUZx80PlrLc8svLplb Gi1gvZogG1XZogoQfHf4LHE9sypz4p1TTIYGOrSxXl3+7pni49tpT7ZwG2dxP36hRx4z B3M/bF7e4XKFPaFZE1dTnkjWokWarDsnWkn2gkY5En+aPjHyYiWc02HTV9VH2mwQIUGD 9BqvmwGsOvay1iOZXkzHjslH4hiqYlcZOdtvpOiezB/05AotqJRMyk/inF5oEUZG91TG nEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:references :in-reply-to:user-agent:mime-version:content-transfer-encoding; bh=APHlIlTusvMgXPnzCwNHewW1Pmh8VQG7NFIzezTRaNc=; b=b22xDAcPE6OK7akR/l/iApQTV4V/AZc024+zPqEprWOxpeaY7zYYv/KDG7xzhQpAY8 1FL0rlbnI9lWHoP6VGIP+5QreDqg7ReLOKJ5n5YdIEhqQOVY59Jk6sPaEyiLM2XSidRL O255uo738EYwuCP0tfc3eGLdITURb6r9ju55J+/fnzd8tVCQ04QmMtVaEWbznKS9qcNl Y1eR8jQUYP+c86JWjqiOyxgGxYyyBttjYYyIQz+vESw6H8s1uy8GMF/AV+s84WDVUZja uQvkYXOMFhUFWKDFEnRKH83OrRxuOcfHdbATwvkM//xn8jiwFxmfX14aPSgSLwASSqA5 ytbQ== X-Gm-Message-State: AOAM531AdZvJZsArKGS+Fv3KgyrYa14V7thkaqW1LtAp8xkBZMGKB0SM tw+7hQIFsYDu5oE7N4f6GWaw5w== X-Google-Smtp-Source: ABdhPJyOXVhasI5kNN4XMRmvxSGVY64NlM3BrwNXdHZ73Xkozk0MQxwjPk9APXEqNUpZuolRZ9eeKg== X-Received: by 2002:a5d:518d:0:b0:1e5:8cc9:5aa4 with SMTP id k13-20020a5d518d000000b001e58cc95aa4mr1733704wrv.119.1645007884357; Wed, 16 Feb 2022 02:38:04 -0800 (PST) Received: from CTHALPA.outer.uphall.net (cpc1-cmbg20-2-0-cust759.5-4.cable.virginm.net. [86.21.218.248]) by smtp.gmail.com with ESMTPSA id r11sm13099446wmb.19.2022.02.16.02.38.03 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 16 Feb 2022 02:38:03 -0800 (PST) From: John Cox To: =?utf-8?Q?Jernej_=C5=A0krabec?= Cc: Nicolas Dufresne , Benjamin Gaignard , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, hverkuil-cisco@xs4all.nl, jonas@kwiboo.se, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com Subject: Re: [RFC v2 6/8] media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params Date: Wed, 16 Feb 2022 10:38:02 +0000 Message-ID: <5nkp0htimo1d7tip46id5pmvt69sqakdrm@4ax.com> References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> <2071229.OBFZWjSADL@kista> <3tkn0ht1cjbpr3meuputqpuvpfcq3gkrd5@4ax.com> <11921127.O9o76ZdvQC@kista> In-Reply-To: <11921127.O9o76ZdvQC@kista> User-Agent: ForteAgent/8.00.32.1272 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_023806_492273_309A6199 X-CRM114-Status: GOOD ( 46.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxNSBGZWIgMjAyMiAyMToyNzozMCArMDEwMCwgeW91IHdyb3RlOgoKPkRuZSB0b3Jl aywgMTUuIGZlYnJ1YXIgMjAyMiBvYiAxNzozMToyOCBDRVQgamUgSm9obiBDb3ggbmFwaXNhbChh KToKPj4gT24gVHVlLCAxNSBGZWIgMjAyMiAxNzoxMToxMiArMDEwMCwgeW91IHdyb3RlOgo+PiAK Pj4gPkRuZSB0b3JlaywgMTUuIGZlYnJ1YXIgMjAyMiBvYiAxNzowMDozMyBDRVQgamUgSm9obiBD b3ggbmFwaXNhbChhKToKPj4gPj4gT24gVHVlLCAxNSBGZWIgMjAyMiAxMDoyODo1NSAtMDUwMCwg eW91IHdyb3RlOgo+PiA+PiAKPj4gPj4gPkxlIG1hcmRpIDE1IGbDqXZyaWVyIDIwMjIgw6AgMTQ6 NTAgKzAwMDAsIEpvaG4gQ294IGEgw6ljcml0IDoKPj4gPj4gPj4gT24gVHVlLCAxNSBGZWIgMjAy MiAxNTozNToxMiArMDEwMCwgeW91IHdyb3RlOgo+PiA+PiA+PiAKPj4gPj4gPj4gPiAKPj4gPj4g Pj4gPiBMZSAxNS8wMi8yMDIyIMOgIDE1OjE3LCBKb2huIENveCBhIMOpY3JpdCA6Cj4+ID4+ID4+ ID4gPiBIaQo+PiA+PiA+PiA+ID4gCj4+ID4+ID4+ID4gPiA+IFRoZSBiaXQgc2l6ZSBvZiB0aGUg c2xpY2UgY291bGQgYmUgZGVkdWNlZCBmcm9tIHRoZSBidWZmZXIgCj5wYXlsb2FkCj4+ID4+ID4+ ID4gPiA+IHNvIHJlbW92ZSBiaXRfc2l6ZSBmaWVsZCB0byBhdm9pZCBkdXBsaWNhdGVkIHRoZSBp bmZvcm1hdGlvbi4KPj4gPj4gPj4gPiA+IEkgdGhpbmsgdGhpcyBpcyBhIGJhZCBpZGVhLiBJbiB0 aGUgZnV0dXJlIHdlIGFyZSAoSSBob3BlKSBnb2luZyB0byAKPj4gPndhbnQKPj4gPj4gPj4gPiA+ IHRvIGhhdmUgYW4gYXJyYXkgKHZhcmlhYmxlKSBvZiBzbGljZSBoZWFkZXJzIGFsbCByZWZlcnJp bmcgdG8gdGhlIAo+PiA+c2FtZQo+PiA+PiA+PiA+ID4gYml0IGJ1ZmZlci4gIFdoZW4gd2UgZG8g dGhhdCB3ZSB3aWxsIG5lZWQgdGhpcyBmaWVsZC4KPj4gPj4gPj4gPiAKPj4gPj4gPj4gPiBJIHdv bmRlciBpZiB0aGF0IGNvdWxkIGJlIGNvbnNpZGVyaW5nIGxpa2UgYW5vdGhlciBkZWNvZGUgbW9k ZSBhbmQgCj5zbwo+PiA+PiA+PiA+IHVzZSBhbiBvdGhlciBjb250cm9sID8KPj4gPj4gPj4gCj4+ ID4+ID4+IEksIHBlcnNvbmFsbHksIHdvdWxkIGJlIGluIGZhdm91ciBvZiBtYWtpbmcgdGhlIHNs aWNlIGhlYWRlciBjb250cm9sIGEKPj4gPj4gPj4gdmFyaWFibGUgYXJyYXkganVzdCBhcyBpdCBp cy4gIElmIHVzZXJsYW5kIGNhbid0IGNvcGUgd2l0aCBtdWx0aXBsZQo+PiA+PiA+PiBlbnRyaWVz IHRoZW4ganVzdCBzZW5kIHRoZW0gb25lIGF0IGEgdGltZSBhbmQgdGhlIGNvZGUgbG9va3MgZXhh Y3RseQo+PiA+PiA+PiBsaWtlIGl0IGRvZXMgYXQgdGhlIG1vbWVudCBhbmQgaWYgdGhlIGRyaXZl ciBjYW4ndCB0aGVuIHNldCBtYXggYXJyYXkKPj4gPj4gPj4gZW50cmllcyB0byAxLgo+PiA+PiA+ PiAKPj4gPj4gPj4gSGF2aW5nIGltcGxlbWVudGVkIHRoaXMgaW4gcnBpIHBvcnQgb2YgZmZtcGVn IGFuZCB0aGUgUlBpIFY0TDIgZHJpdmVyIEkKPj4gPj4gPj4gY2FuIHNheSB3aXRoIGV4cGVyaWVu Y2UgdGhhdCB0aGUgY29kZSBhbmQgZWZmb3J0IG92ZXJoZWFkIGlzIHZlcnkgbG93Lgo+PiA+PiA+ PiAKPj4gPj4gPj4gRWl0aGVyIHdheSBoYXZpbmcgYSBtdWx0aXBsZSBzbGljZSBoZWFkZXIgY29u dHJvbCBpbiB0aGUgVUFQSSBpcwo+PiA+PiA+PiBpbXBvcnRhbnQgZm9yIGVmZmljaWVuY3kuCj4+ ID4+ID4KPj4gPj4gPkp1c3QgdG8gY2xhcmlmeSB0aGUgaWRlYSwgd2Ugd291bGQgaGF2ZSBhIHNp bmdsZSBzbGljZSBjb250cm9scywgYWx3YXlzIAo+PiA+ZHluYW1pYzoKPj4gPj4gPgo+PiA+PiA+ MS4gRm9yIHNsaWNlZCBiYXNlZCBkZWNvZGVyCj4+ID4+ID4KPj4gPj4gPlRoZSBkeW5hbWljIGFy cmF5IHNsaWNlIGNvbnRyb2wgaXMgaW1wbGVtZW50ZWQgYnkgdGhlIGRyaXZlciBhbmQgaXRzIAo+ c2l6ZSAKPj4gPm11c3QKPj4gPj4gPmJlIDEuCj4+ID4+IAo+PiA+PiBZZXMKPj4gPj4gCj4+ID4+ ID4yLiBGb3IgZnJhbWUgYmFzZWQgZGVjb2RlciB0aGF0IGRvbid0IGNhcmUgZm9yIHNsaWNlcwo+ PiA+PiA+Cj4+ID4+ID5UaGUgZHluYW1pYyBhcnJheSBzbGljZSBjb250cm9scyBpcyBub3QgaW1w bGVtZW50LiBVc2VybGFuZCBkZXRlY3RzIHRoYXQgCj5hdAo+PiA+PiA+cnVudGltZSwgc2ltaWxh ciB0byB0aGUgVlA5IGNvbXByZXNzZWQgaGVhZGVycy4KPj4gPj4gCj4+ID4+IElmIHRoZSBkcml2 ZXIgcGFyc2VzIGFsbCB0aGUgc2xpY2UgaGVhZGVyIHRoZW4gdGhhdCBzZWVtcyBwbGF1c2libGUK Pj4gPj4gCj4+ID4+ID4zLiBGb3IgZnJhbWUgYmFzZWQgZGVjb2RlcnMgdGhhdCBuZWVkcyBzbGlj ZXMgKG9yIGRyaXZlciB0aGF0IHN1cHBvcnRzIAo+PiA+b2Zmc2V0Cj4+ID4+ID5hbmQgY2FuIGdh aW4gcGVyZm9ybWFuY2Ugd2l0aCBzdWNoIG1vZGUpCj4+ID4+ID4KPj4gPj4gPlRoZSBkeW5hbWlj IGFycmF5IHNsaWNlIGNvbnRyb2xzIGlzIGltcGxlbWVudGVkLCBhbmQgc2hvdWxkIGNvbnRhaW4g YWxsIAo+dGhlCj4+ID4+ID5zbGljZXMgZm91bmQgaW4gdGhlIE9VVFBVVCBidWZmZXIuCj4+ID4+ ID4KPj4gPj4gPlNvIHRoZSByZWFzb24gZm9yIHRoaXMgYml0X3NpemUgKG5vdCBzdXJlIHdoeSBp dHMgYml0cyB0aG91Z2gsIHBlcmhhcHMgCj4+ID5zb21lb25lCj4+ID4+ID5jYW4gZWR1Y2F0ZSBt ZSA/KQo+PiA+PiAKPj4gPj4gUlBpIGRvZXNuJ3QgbmVlZCBiaXRzIGFuZCB3b3VsZCBiZSBoYXBw eSB3aXRoIGJ5dGVzIGhvd2V2ZXIKPj4gPj4gc2xpY2Vfc2VnbWVudCBkYXRhIGlzbid0IGJ5dGUg YWxpZ25lZCBhdCB0aGUgZW5kIHNvIGl0cyBwb3NzaWJsZSB0aGF0Cj4+ID4+IHRoZXJlIG1pZ2h0 IGJlIGRlY29kZXJzIG91dCB0aGVyZSB0aGF0IHdhbnQgYW4gYWNjdXJhdGUgbGVuZ3RoIGZvciB0 aGF0Lgo+PiA+Cj4+ID5UaGVyZSBhcmUgdHdvIGZpZWxkcywgcGxlYXNlIGRvbid0IG1peCB0aGVt IHVwOgo+PiA+Cj4+ID5fX3UzMgliaXRfc2l6ZTsKPj4gPl9fdTMyCWRhdGFfYml0X29mZnNldDsg KGNoYW5nZWQgdG8gZGF0YV9ieXRlX29mZnNldCBpbiB0aGlzIHNlcmllcykKPj4gPgo+PiA+ZGF0 YV9iaXRfb2Zmc2V0L2RhdGFfYnl0ZV9vZmZzZXQgaXMgdXNlZnVsLCB3aGlsZSBiaXRfc2l6ZSBp cyBJTU8gbm90LiBJZiB5b3UgCj4+ID5oYXZlIG11bHRpcGxlIHNsaWNlcyBpbiBhcnJheSwgeW91 IG9ubHkgbmVlZCB0byBrbm93IHN0YXJ0IG9mIHRoZSBzbGljZSAKPmRhdGEgCj4+ID5hbmQgdGhh dCBvZmZzZXQgaXMgYWx3YXlzIG9mZnNldCBmcm9tIHN0YXJ0IG9mIHRoZSBidWZmZXIgKGFic29s dXRlLCBpdCdzIG5vdCAKPj4gPnJlbGF0aXZlIHRvIHByZXZpb3VzIHNsaWNlIGRhdGEpLgo+PiAK Pj4gTm8uLi4gb3IgYXQgbGVhc3QgSSB0aGluayBub3QuIFJQaSBuZWVkcyB0aGUgc3RhcnQgYW5k IGVuZCBvZiB0aGUKPj4gc2xpY2Vfc2VnbWVudF9kYXRhIGVsZW1lbnRzIG9mIGVhY2ggc2xpY2Uu IAo+Cj5JdCB3b3VsZCBiZSBnb29kIHRvIGtub3cgaWYgc2l6ZSBuZWVkcyB0byBiZSBleGFjdCBv ciBjYW4gb3ZlcnNob290LCBsaWtlIAo+dXNpbmcgZW5kIG9mIGJ1ZmZlciBmb3IgdGhhdC4KPgo+ Q2VkcnVzIGFsc28gd2FudHMgdG8ga25vdyBzbGljZSBkYXRhIHNpemUsIGJ1dCBpdCB0dXJucyBv dXQgdGhhdCBiaWdnZXIgdGhhbiAKPm5lY2Vzc2FyeSBzaXplIGRvZXNuJ3QgcG9zZSBhbnkgcHJv YmxlbXMuIElmIHRoYXQncyBub3QgdGhlIGNhc2UsIHRoZW4gCj5iaXRfc2l6ZSBuZWVkcyBzdGF5 IGluIGZvciBzdXJlLgoKUlBpIG5lZWRzIHRoZSBleGFjdCBzaXplIChieXRlcyB3aWxsIGRvIC0g YnV0IEkgZG9uJ3Qgc2VlIHRoZSBoYXJtIGluCnNwZWNpZnlpbmcgaXQgaW4gYml0cyBpbiBjYXNl IHNvbWUgZnV0dXJlIGgvdyB3YW50cyB0aGUgZXh0cmEgcHJlY2lzaW9uCmFzIGxvbmcgYXMgd2Ug bmFpbCBkb3duIGV4YWN0bHkgd2hpY2ggYml0IHdlIG1lYW4pCgpSZWdhcmRzCgpKQwoKPkJlc3Qg cmVnYXJkcywKPkplcm5lago+Cj4+IElmIHNsaWNlcyBhcmUgYXJyYW5nZWQgaW4gdGhlCj4+IGJ1 ZmZlciB3aXRoIHNsaWNlX3NlZ21lbnRfaGVhZGVycyBhdHRhY2hlZCB0aGVuIEkgZG9uJ3Qgc2Vl IGhvdyBJIGdldCB0bwo+PiBrbm93IHRoYXQuICBBbHNvIGlmIHRoZSBPVVRQVVQgYnVmZmVyIGlz IGp1c3QgYSBiaXQgb2YgYml0c3RyZWFtLCB3aGljaAo+PiBtaWdodCB3ZWxsIGJlIHZlcnkgY29u dmllbmllbnQgZm9yIHNvbWUgdXNlcnNwYWNlLCB0aGVuIGl0IGlzIGxlZ2l0aW1hdGUKPj4gdG8g aGF2ZSBTRUlzIGJldHdlZW4gc2xpY2UgaGVhZGVycyBzbyB5b3UgY2FuJ3QgZXZlbiBndWFyYW50 ZWUgdGhhdCB5b3VyCj4+IGNvZGVkIHNsaWNlIHNlZ21lbnRzIGFyZSBjb250aWd1b3VzLgo+PiAK Pj4gUmVnYXJkcwo+PiAKPj4gSkMKPj4gCj4+ID5CZXN0IHJlZ2FyZHMsCj4+ID5KZXJuZWoKPj4g Pgo+PiA+PiAKPj4gPj4gPiBXb3VsZCBiZSB0byBsZXQgdGhlIGRyaXZlciBvZmZzZXQgaW5zaWRl IHRoZSB0aGUgc2luZ2xlCj4+ID4+ID5PVVRQVVQvYml0c3RyZWFtIGJ1ZmZlciBpbiBjYXNlIHRo aXMgaXMgbm90IGF1dG9tYXRpY2FsbHkgZm91bmQgYnkgdGhlIAo+PiA+ZHJpdmVyCj4+ID4+ID4o b3IgdGhhdCBubyBzdGFydC1jb2RlIGlzIG5lZWRlZCkuIElzIHRoYXQgbGFzdCBiaXQgY29ycmVj dCA/IElmIHNvLCAKPnNob3VsZCAKPj4gPndlCj4+ID4+ID5jaGFuZ2UgaXQgdG8gYW4gb2Zmc2V0 IHJhdGhlciB0aGVuIGEgc2l6ZSA/IFNoYWxsIHdlIGFsbG93IHVzaW5nIG9mZmVzZXRzIAo+PiA+ aW5zaWRlCj4+ID4+ID5sYXJnZXIgYnVmZmVyIChlLmcuIHRvIGF2b2lkIHNvbWUgbWVtb3J5IGNv cGllcykgZm9yIHRoZSBTbGljZWQgQmFzZSAKPmNhc2VzID8KPj4gPj4gCj4+ID4+IEkgdXNlIChp biB0aGUgY3VycmVudCBzdHJ1Y3R1cmUpIGRhdGFfYml0X29mZnNldCB0byBmaW5kIHRoZSBzdGFy dCBvZgo+PiA+PiBlYWNoIHNsaWNlJ3Mgc2xpY2Vfc2VnbWVudF9kYXRhIHdpdGhpbiB0aGUgT1VU UFVUIGJ1ZmZlciBhbmQgYml0X3NpemUgdG8KPj4gPj4gZmluZCB0aGUgZW5kLiAgUlBpIGRvZXNu J3QgLyBjYW4ndCBwYXJzZSB0aGUgc2xpY2VfaGVhZGVyIGFuZCBzbyB3YW50cwo+PiA+PiBhbGwg b2YgdGhhdC4gIERlY29kZXJzIHRoYXQgZG8gcGFyc2UgdGhlIGhlYWRlciBtaWdodCBwbGF1c2Fi bHkgd2FudAo+PiA+PiBoZWFkZXIgb2Zmc2V0cyB0b28gYW5kIGl0IHdvdWxkIGZhY2lsaXRhdGUg emVybyBjb3B5IG9mIHRoZSBiaXQgYnVmZmVyLgo+PiA+PiAKPj4gPj4gIAo+PiA+PiA+PiBSZWdh cmRzCj4+ID4+ID4+IAo+PiA+PiA+PiBKb2huIENveAo+PiA+PiA+PiAKPj4gPj4gPj4gPiA+ID4g U2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgCj48YmVuamFtaW4uZ2FpZ25hcmRAY29s bGFib3JhLmNvbT4KPj4gPj4gPj4gPiA+ID4gLS0tCj4+ID4+ID4+ID4gPiA+IC4uLi91c2Vyc3Bh Y2UtYXBpL21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0ICAgICAgIHwgIDMgLS0tCj4+ID4+ ID4+ID4gPiA+IGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9zdW54aS9jZWRydXMvY2VkcnVzX2gyNjUu YyAgICAgIHwgMTEgKysrCj4+ID4rLS0tLS0tLQo+PiA+PiA+PiA+ID4gPiBpbmNsdWRlL3VhcGkv bGludXgvdjRsMi1jb250cm9scy5oICAgICAgICAgICAgICAgICAgICB8ICAzICstLQo+PiA+PiA+ PiA+ID4gPiAzIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0p Cj4+ID4+ID4+ID4gPiA+IAo+PiA+PiA+PiA+ID4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlv bi91c2Vyc3BhY2UtYXBpL21lZGlhL3Y0bC9leHQtY3RybHMtCj4+ID5jb2RlYy5yc3QgYi9Eb2N1 bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2RlYy5yc3QKPj4g Pj4gPj4gPiA+ID4gaW5kZXggMzI5NmFjM2I5ZmNhLi5jM2FlOTc2NTdmYTcgMTAwNjQ0Cj4+ID4+ ID4+ID4gPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvZXh0 LWN0cmxzLWNvZGVjLnJzdAo+PiA+PiA+PiA+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9uL3VzZXJz cGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2RlYy5yc3QKPj4gPj4gPj4gPiA+ID4gQEAg LTI5NjUsOSArMjk2NSw2IEBAIGVudW0gCj52NGwyX21wZWdfdmlkZW9faGV2Y19zaXplX29mX2xl bmd0aF9maWVsZCAKPj4gPi0KPj4gPj4gPj4gPiA+ID4gICAgICA6c3R1Yi1jb2x1bW5zOiAwCj4+ ID4+ID4+ID4gPiA+ICAgICAgOndpZHRoczogICAgICAgMSAxIDIKPj4gPj4gPj4gPiA+ID4gCj4+ ID4+ID4+ID4gPiA+IC0gICAgKiAtIF9fdTMyCj4+ID4+ID4+ID4gPiA+IC0gICAgICAtIGBgYml0 X3NpemVgYAo+PiA+PiA+PiA+ID4gPiAtICAgICAgLSBTaXplIChpbiBiaXRzKSBvZiB0aGUgY3Vy cmVudCBzbGljZSBkYXRhLgo+PiA+PiA+PiA+ID4gPiAgICAgICogLSBfX3UzMgo+PiA+PiA+PiA+ ID4gPiAgICAgICAgLSBgYGRhdGFfYml0X29mZnNldGBgCj4+ID4+ID4+ID4gPiA+ICAgICAgICAt IE9mZnNldCAoaW4gYml0cykgdG8gdGhlIHZpZGVvIGRhdGEgaW4gdGhlIGN1cnJlbnQgc2xpY2Ug Cj4+ID5kYXRhLgo+PiA+PiA+PiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL21l ZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5jIGIvCj4+ID5kcml2ZXJzL3N0YWdpbmcvbWVk aWEvc3VueGkvY2VkcnVzL2NlZHJ1c19oMjY1LmMKPj4gPj4gPj4gPiA+ID4gaW5kZXggOGFiMmQ5 YzZmMDQ4Li5kYjhjNzQ3NWVlYjggMTAwNjQ0Cj4+ID4+ID4+ID4gPiA+IC0tLSBhL2RyaXZlcnMv c3RhZ2luZy9tZWRpYS9zdW54aS9jZWRydXMvY2VkcnVzX2gyNjUuYwo+PiA+PiA+PiA+ID4gPiAr KysgYi9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvc3VueGkvY2VkcnVzL2NlZHJ1c19oMjY1LmMKPj4g Pj4gPj4gPiA+ID4gQEAgLTMxMiw4ICszMTIsOCBAQCBzdGF0aWMgdm9pZCBjZWRydXNfaDI2NV9z ZXR1cChzdHJ1Y3QgCj5jZWRydXNfY3R4IAo+PiA+KmN0eCwKPj4gPj4gPj4gPiA+ID4gCWNvbnN0 IHN0cnVjdCB2NGwyX2hldmNfcHJlZF93ZWlnaHRfdGFibGUgCj4qcHJlZF93ZWlnaHRfdGFibGU7 Cj4+ID4+ID4+ID4gPiA+IAl1bnNpZ25lZCBpbnQgd2lkdGhfaW5fY3RiX2x1bWEsIGN0Yl9zaXpl X2x1bWE7Cj4+ID4+ID4+ID4gPiA+IAl1bnNpZ25lZCBpbnQgbG9nMl9tYXhfbHVtYV9jb2Rpbmdf YmxvY2tfc2l6ZTsKPj4gPj4gPj4gPiA+ID4gKwlzaXplX3Qgc2xpY2VfYnl0ZXM7Cj4+ID4+ID4+ ID4gPiA+IAlkbWFfYWRkcl90IHNyY19idWZfYWRkcjsKPj4gPj4gPj4gPiA+ID4gLQlkbWFfYWRk cl90IHNyY19idWZfZW5kX2FkZHI7Cj4+ID4+ID4+ID4gPiA+IAl1MzIgY2hyb21hX2xvZzJfd2Vp Z2h0X2Rlbm9tOwo+PiA+PiA+PiA+ID4gPiAJdTMyIG91dHB1dF9waWNfbGlzdF9pbmRleDsKPj4g Pj4gPj4gPiA+ID4gCXUzMiBwaWNfb3JkZXJfY250WzJdOwo+PiA+PiA+PiA+ID4gPiBAQCAtMzcw LDggKzM3MCw4IEBAIHN0YXRpYyB2b2lkIGNlZHJ1c19oMjY1X3NldHVwKHN0cnVjdCAKPmNlZHJ1 c19jdHggCj4+ID4qY3R4LAo+PiA+PiA+PiA+ID4gPiAKPj4gPj4gPj4gPiA+ID4gCWNlZHJ1c193 cml0ZShkZXYsIFZFX0RFQ19IMjY1X0JJVFNfT0ZGU0VULCAwKTsKPj4gPj4gPj4gPiA+ID4gCj4+ ID4+ID4+ID4gPiA+IC0JcmVnID0gc2xpY2VfcGFyYW1zLT5iaXRfc2l6ZTsKPj4gPj4gPj4gPiA+ ID4gLQljZWRydXNfd3JpdGUoZGV2LCBWRV9ERUNfSDI2NV9CSVRTX0xFTiwgcmVnKTsKPj4gPj4g Pj4gPiA+ID4gKwlzbGljZV9ieXRlcyA9IHZiMl9nZXRfcGxhbmVfcGF5bG9hZCgmcnVuLT5zcmMt Cj4+dmIyX2J1ZiwgMCk7Cj4+ID4+ID4+ID4gPiA+ICsJY2VkcnVzX3dyaXRlKGRldiwgVkVfREVD X0gyNjVfQklUU19MRU4sIHNsaWNlX2J5dGVzKTsKPj4gPj4gPj4gPiA+IEkgdGhpbmsgb25lIG9m IHRoZXNlIG11c3QgYmUgd3JvbmcuIGJpdF9zaXplIGlzIGluIGJpdHMsCj4+ID4+ID4+ID4gPiB2 YjJfZ2V0X3BsYW5lX3BheWxvYWQgaXMgaW4gYnl0ZXM/Cj4+ID4+ID4+ID4gCj4+ID4+ID4+ID4g WW91IGFyZSByaWdodCBpdCBzaG91bGQgYmUgdmIyX2dldF9wbGFuZV9wYXlsb2FkKCkgKiA4IHRv IGdldCB0aGUgCj5zaXplIAo+PiA+aW4gYml0cy4KPj4gPj4gPj4gPiAKPj4gPj4gPj4gPiBJIHdp bGwgY2hhbmdlIHRoYXQgaW4gdjMuCj4+ID4+ID4+ID4gCj4+ID4+ID4+ID4gPiAKPj4gPj4gPj4g PiA+IFJlZ2FyZHMKPj4gPj4gPj4gPiA+IAo+PiA+PiA+PiA+ID4gSm9obiBDb3gKPj4gPj4gPj4g PiA+ICAgCj4+ID4+ID4+ID4gPiA+IAkvKiBTb3VyY2UgYmVnaW5uaW5nIGFuZCBlbmQgYWRkcmVz c2VzLiAqLwo+PiA+PiA+PiA+ID4gPiAKPj4gPj4gPj4gPiA+ID4gQEAgLTM4NCwxMCArMzg0LDcg QEAgc3RhdGljIHZvaWQgY2VkcnVzX2gyNjVfc2V0dXAoc3RydWN0IAo+PiA+Y2VkcnVzX2N0eCAq Y3R4LAo+PiA+PiA+PiA+ID4gPiAKPj4gPj4gPj4gPiA+ID4gCWNlZHJ1c193cml0ZShkZXYsIFZF X0RFQ19IMjY1X0JJVFNfQUREUiwgcmVnKTsKPj4gPj4gPj4gPiA+ID4gCj4+ID4+ID4+ID4gPiA+ IC0Jc3JjX2J1Zl9lbmRfYWRkciA9IHNyY19idWZfYWRkciArCj4+ID4+ID4+ID4gPiA+IC0JCQkg ICBESVZfUk9VTkRfVVAoc2xpY2VfcGFyYW1zLQo+PmJpdF9zaXplLCAKPj4gPjgpOwo+PiA+PiA+ PiA+ID4gPiAtCj4+ID4+ID4+ID4gPiA+IC0JcmVnID0gCj5WRV9ERUNfSDI2NV9CSVRTX0VORF9B RERSX0JBU0Uoc3JjX2J1Zl9lbmRfYWRkcik7Cj4+ID4+ID4+ID4gPiA+ICsJcmVnID0gVkVfREVD X0gyNjVfQklUU19FTkRfQUREUl9CQVNFKHNyY19idWZfYWRkciArIAo+c2xpY2VfYnl0ZXMpOwo+ PiA+PiA+PiA+ID4gPiAJY2VkcnVzX3dyaXRlKGRldiwgVkVfREVDX0gyNjVfQklUU19FTkRfQURE UiwgcmVnKTsKPj4gPj4gPj4gPiA+ID4gCj4+ID4+ID4+ID4gPiA+IAkvKiBDb2RpbmcgdHJlZSBi bG9jayBhZGRyZXNzICovCj4+ID4+ID4+ID4gPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkv bGludXgvdjRsMi1jb250cm9scy5oIGIvaW5jbHVkZS91YXBpLwo+PiA+bGludXgvdjRsMi1jb250 cm9scy5oCj4+ID4+ID4+ID4gPiA+IGluZGV4IGIxYTNkYzA1ZjAyZi4uMjdmNWQyNzJkYzQzIDEw MDY0NAo+PiA+PiA+PiA+ID4gPiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvdjRsMi1jb250cm9s cy5oCj4+ID4+ID4+ID4gPiA+ICsrKyBiL2luY2x1ZGUvdWFwaS9saW51eC92NGwyLWNvbnRyb2xz LmgKPj4gPj4gPj4gPiA+ID4gQEAgLTI0NTcsNyArMjQ1Nyw2IEBAIHN0cnVjdCB2NGwyX2hldmNf cHJlZF93ZWlnaHRfdGFibGUgewo+PiA+PiA+PiA+ID4gPiAjZGVmaW5lIFY0TDJfSEVWQ19TTElD RV9QQVJBTVNfRkxBR19ERVBFTkRFTlRfU0xJQ0VfU0VHTUVOVAkKPj4gPigxVUxMIDw8IDkpCj4+ ID4+ID4+ID4gPiA+IAo+PiA+PiA+PiA+ID4gPiBzdHJ1Y3QgdjRsMl9jdHJsX2hldmNfc2xpY2Vf cGFyYW1zIHsKPj4gPj4gPj4gPiA+ID4gLQlfX3UzMgliaXRfc2l6ZTsKPj4gPj4gPj4gPiA+ID4g CV9fdTMyCWRhdGFfYml0X29mZnNldDsKPj4gPj4gPj4gPiA+ID4gCj4+ID4+ID4+ID4gPiA+IAkv KiBJU08vSUVDIDIzMDA4LTIsIElUVS1UIFJlYy4gSC4yNjU6IE5BTCB1bml0IGhlYWRlciAKPiov Cj4+ID4+ID4+ID4gPiA+IEBAIC0yNDg0LDcgKzI0ODMsNyBAQCBzdHJ1Y3QgdjRsMl9jdHJsX2hl dmNfc2xpY2VfcGFyYW1zIHsKPj4gPj4gPj4gPiA+ID4gCS8qIElTTy9JRUMgMjMwMDgtMiwgSVRV LVQgUmVjLiBILjI2NTogUGljdHVyZSB0aW1pbmcgCj5TRUkgbWVzc2FnZSAKPj4gPiovCj4+ID4+ ID4+ID4gPiA+IAlfX3U4CXBpY19zdHJ1Y3Q7Cj4+ID4+ID4+ID4gPiA+IAo+PiA+PiA+PiA+ID4g PiAtCV9fdTgJcmVzZXJ2ZWQ7Cj4+ID4+ID4+ID4gPiA+ICsJX191OAlyZXNlcnZlZFs1XTsKPj4g Pj4gPj4gPiA+ID4gCj4+ID4+ID4+ID4gPiA+IAkvKiBJU08vSUVDIDIzMDA4LTIsIElUVS1UIFJl Yy4gSC4yNjU6IEdlbmVyYWwgc2xpY2UgCj5zZWdtZW50IAo+PiA+aGVhZGVyICovCj4+ID4+ID4+ ID4gPiA+IAlfX3UzMglzbGljZV9zZWdtZW50X2FkZHI7Cj4+ID4+IAo+PiA+Cj4+IAo+CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==