From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f4xG8-0006K6-A0 for mharc-grub-devel@gnu.org; Sat, 07 Apr 2018 19:28:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4xG5-0006HP-ND for grub-devel@gnu.org; Sat, 07 Apr 2018 19:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4xG4-0003PG-R0 for grub-devel@gnu.org; Sat, 07 Apr 2018 19:28:33 -0400 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:45310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4xG4-0003P2-KG for grub-devel@gnu.org; Sat, 07 Apr 2018 19:28:32 -0400 Received: by mail-pl0-x241.google.com with SMTP id e22-v6so1090281plj.12 for ; Sat, 07 Apr 2018 16:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:in-reply-to :references; bh=HpJnqbIdCzImnmasuhgHmcwfqQo2YcZpC7XEUkq3zKo=; b=hwCUjnLQhd0waFZS5QnAeR1SMtLQ5PwJFez/YzCyq5QXCvP7ehI21eiRspZ1oA8gnG +X1m8CjMiw0BzfJXQyPHvoWiOyZmbE3ShDVG/Ugth0158kolzKqcERC/ZrFag4OcJzy8 qcqYjgvg2NXHL8a3ASbOgT0FpN9tXq5X161d+9xiC9VNKsPrOGiaU9YuRvU6Osti4zhX VtKXWGymAt3TkAC8ArJFnh3ZlblB0YoRAJnXJfLWdX8yajUd4tyjQLUPRUZAWOKTNVwl RgzwPyy3kKFoB51K3IedIrsQ1RwLLJD7KShTHMnBdWLhOPxk3V6uIZowEGETxxv8V+Lj pxKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=HpJnqbIdCzImnmasuhgHmcwfqQo2YcZpC7XEUkq3zKo=; b=ABbJQFowRjQQwF25KPICtXHce2yCCK/V59lJHo4mQOidoByN3O1AInZitCONu0BkqD nm4RALkv7YhELRKCHZwdhUbjRTd2WR4POlkhg0N2553xFU1K19THoAXvI5qnVD4R79Bg XLZR8GAzfebxW3UfUnQY88a/ilivHfbRFtJxCfYJIiQGAyPC5ROaYjNxhXtNmYz2/Unh uz2eLcdKkqHWivCz3r/0ExEjkPacn6yLqteS23uzbL5nZvrjs5TF4XYZqLR11riQukeV dY4JaZvMmdUVx+42//NCQz7menHWkAm3bi2ZRPPcBiccQlCKwO2NUfUMJcScCDZMWOEz rGzA== X-Gm-Message-State: AElRT7GvWCADJ79FXXfgJ7Eyrkdceitme7Xn6+Y7i/yjpFBD814l94fa su3OBhvDwHTq/NvXZLsrms7R4w== X-Google-Smtp-Source: AIpwx49Jtz0c9aCgNZIW8tO6qni8e977hsx6LWGvi/tegTr4qYIt6a/8SMzlNAARplYAUKQhdGURFg== X-Received: by 2002:a17:902:481:: with SMTP id e1-v6mr32804688ple.377.1523143711350; Sat, 07 Apr 2018 16:28:31 -0700 (PDT) Received: from localhost.localdomain ([2601:602:9c01:e86a:2ec2:3a19:cd81:76ab]) by smtp.googlemail.com with ESMTPSA id 85sm26092944pfz.155.2018.04.07.16.28.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Apr 2018 16:28:30 -0700 (PDT) From: Nicholas Vinson To: grub-devel@gnu.org Subject: [GRUB PARTUUID PATCH V9 5/5] Default to disabling partition UUID support Date: Sat, 7 Apr 2018 16:28:14 -0700 Message-Id: <6000298ccdcbf7ddf61a83015c9f2d52469c7d36.1523131110.git.nvinson234@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::241 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2018 23:28:34 -0000 The addition of GRUB_DISABLE_LINUX_PARTUUID and having it default to 'false' is a breaking change for systems that use GPT partition schemes and Linux kernel version 2.6.37 or older and a breaking change for systems that use MBR partition schemes and Linux kernel version 3.10 or older. This patch updates grub.d/10_linux so that GRUB_DISABLE_LINUX_PARTUUID is set to 'true' if the system has not specified otherwise. Signed-off-by: Nicholas Vinson --- docs/grub.texi | 5 +++-- util/grub.d/10_linux.in | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 06f0afe45..3fcc42e74 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -1426,13 +1426,14 @@ disable the use of UUIDs, set this option to @samp{true}. @item GRUB_DISABLE_LINUX_PARTUUID If @command{grub-mkconfig} cannot identify the root filesystem via its -universally-unique indentifier (UUID), @command{grub-mkconfig} will use the UUID +universally-unique indentifier (UUID), @command{grub-mkconfig} can use the UUID of the partition containing the filesystem to identify the root filesystem to the Linux kernel via a @samp{root=PARTUUID=...} kernel parameter. This is not as reliable as using the filesystem UUID, but is more reliable than using the Linux device names. When enabled, this option requires the Linux kernel version to be greater than 2.6.37 (3.10 for systems using the MSDOS partition scheme) or -newer. To disable the use of partition UUIDs, set this option to @samp{true}. +newer. This option defaults to @samp{true}. To enable the use of partition +UUIDs, set this option to @samp{false}. @item GRUB_DISABLE_RECOVERY If this option is set to @samp{true}, disable the generation of recovery diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in index 6916f1841..146499f22 100644 --- a/util/grub.d/10_linux.in +++ b/util/grub.d/10_linux.in @@ -43,6 +43,10 @@ case ${GRUB_DEVICE} in ;; esac +# Default to disabling partition uuid support to maintian compatibility with +# older kernels. +GRUB_DISABLE_LINUX_PARTUUID=${GRUB_DISABLE_LINUX_PARTUUID-true} + # btrfs may reside on multiple devices. We cannot pass them as value of root= parameter # and mounting btrfs requires user space scanning, so force UUID in this case. if ( [ "x${GRUB_DEVICE_UUID}" = "x" ] && [ "x${GRUB_DEVICE_PARTUUID}" = "x" ) \ -- 2.16.3