From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesus Sanchez-Palencia Subject: Re: [PATCH v1 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready Date: Thu, 28 Jun 2018 10:12:46 -0700 Message-ID: <601480f1-d635-3e35-0222-d7e98eb829b6@intel.com> References: <20180627215950.6719-1-jesus.sanchez-palencia@intel.com> <20180627215950.6719-13-jesus.sanchez-palencia@intel.com> <44770d6b-503c-279f-807f-0b7f11be56cf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: tglx@linutronix.de, jan.altenberg@linutronix.de, vinicius.gomes@intel.com, kurt.kanzenbach@linutronix.de, henrik@austad.us, richardcochran@gmail.com, levi.pearson@harman.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, mlichvar@redhat.com, willemb@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Eric Dumazet , netdev@vger.kernel.org Return-path: Received: from mga18.intel.com ([134.134.136.126]:36404 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbeF1RRi (ORCPT ); Thu, 28 Jun 2018 13:17:38 -0400 In-Reply-To: <44770d6b-503c-279f-807f-0b7f11be56cf@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/27/2018 04:56 PM, Eric Dumazet wrote: > > > On 06/27/2018 02:59 PM, Jesus Sanchez-Palencia wrote: >> Currently, skb_tx_timestamp() is being called before the DMA >> descriptors are prepared in igb_xmit_frame_ring(), which happens >> during either the igb_tso() or igb_tx_csum() calls. >> >> Given that now the skb->tstamp might be used to carry the timestamp >> for SO_TXTIME, we must only call skb_tx_timestamp() after the >> information has been copied into the DMA tx_ring. > > > Since when this skb->tstamp use happened ? > > If this is in patch 11/14 (igb: Add support for ETF offload), then you should either : > > 1) Squash this into 11/14 > > 2) swap 11 and 12 patch, so that this change is done before "igb: Add support for ETF offload" > > Otherwise a bisection could fail badly. OK. Fixed for v2 by swapping patches 11 and 12. Thanks, Jesus