From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fAhPM-0000o0-4I for mharc-grub-devel@gnu.org; Mon, 23 Apr 2018 15:45:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAhPJ-0000ly-A5 for grub-devel@gnu.org; Mon, 23 Apr 2018 15:45:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAhPI-0007Sn-9V for grub-devel@gnu.org; Mon, 23 Apr 2018 15:45:49 -0400 Received: from mail.gw90.de ([2a01:4f8:140:71f5::3]:57802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAhPI-0007Ni-2w for grub-devel@gnu.org; Mon, 23 Apr 2018 15:45:48 -0400 Received: from [2a02:8109:b5bf:f806:2d1f:41f7:fba1:a29f] (helo=mattotaupa) by mail.gw90.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fAhPA-0000xx-Hr for grub-devel@gnu.org; Mon, 23 Apr 2018 19:45:40 +0000 Message-ID: <6015a3c54b12e48c50387beb335e4b5c06ed1df0.camel@users.sourceforge.net> Subject: Re: [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf` From: Paul Menzel To: grub-devel@gnu.org Date: Mon, 23 Apr 2018 21:45:02 +0200 In-Reply-To: <1521620881.7171.736.camel@users.sourceforge.net> References: <1492251954.3639.117.camel@users.sourceforge.net> <1492371090.2561.114.camel@users.sourceforge.net> <1492379105.2561.128.camel@users.sourceforge.net> <1521620881.7171.736.camel@users.sourceforge.net> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-YJGv8SlzWxAHTq3AsBtL" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:140:71f5::3 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 19:45:50 -0000 --=-YJGv8SlzWxAHTq3AsBtL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear GRUB folks, Am Mittwoch, den 21.03.2018, 09:28 +0100 schrieb Paul Menzel: > From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001 > From: Paul Menzel > Date: Sun, 16 Apr 2017 21:02:58 +0200 > Subject: [PATCH] Makefile.am: Add `all_video` to default_payload.elf >=20 > The module `all_video` is used in `util/grub.d/00_header.in`, and > included for grub-pc by default. >=20 > To make it easier to load such a GRUB configuration from disk with a GRUB > coreboot payload, add this module also to `default_payload.elf` by > default. That avoids a missing module error by GRUB, forcing the user to > hit enter during the start process. > --- > v2: Resend and fix typo in commit message. >=20 > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Makefile.am b/Makefile.am > index 7795baeb6..80a787e57 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -424,7 +424,7 @@ bootcheck: $(BOOTCHECKS) > if COND_i386_coreboot > default_payload.elf: grub-mkstandalone grub-mkimage FORCE > test -f $@ && rm $@ || true > - pkgdatadir=3D. ./grub-mkstandalone --grub-mkimage=3D./grub-mkimage -O i= 386-coreboot -o $@ --modules=3D'ahci pata ehci uhci ohci usb_keyboard usbms= part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --instal= l-modules=3D'ls linux search configfile normal cbtime cbls memrw iorw minic= md lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test= serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat= grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts=3D --t= hemes=3D --locales=3D -d grub-core/ /boot/grub/grub.cfg=3D$(srcdir)/coreboo= t.cfg > + pkgdatadir=3D. ./grub-mkstandalone --grub-mkimage=3D./grub-mkimage -O i= 386-coreboot -o $@ --modules=3D'ahci pata ehci uhci ohci usb_keyboard usbms= part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --instal= l-modules=3D'ls linux search configfile normal cbtime cbls memrw iorw minic= md lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test= serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu all_video $= (shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fo= nts=3D --themes=3D --locales=3D -d grub-core/ /boot/grub/grub.cfg=3D$(srcdi= r)/coreboot.cfg > endif > =20 > endif Can you please commit this to the master branch? Thanks, Paul --=-YJGv8SlzWxAHTq3AsBtL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQ8+w9d414FAVARIpk9fVorbA4dWAUCWt43xAAKCRA9fVorbA4d WFqJAJ9Z9lhB6yf3t3SE4/qSzE5DvTofrgCfQsORa3mu16IUUCvIFBSXFZKjMEE= =3tpC -----END PGP SIGNATURE----- --=-YJGv8SlzWxAHTq3AsBtL--