From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: don't bother checking for encryption key in ->write_iter() References: <20170523003945.14279-1-ebiggers3@gmail.com> <20170523003945.14279-5-ebiggers3@gmail.com> From: Chao Yu Message-ID: <6016f168-9c2b-e7a6-4d21-9b40c4cb6edc@kernel.org> Date: Tue, 23 May 2017 21:39:13 +0800 MIME-Version: 1.0 In-Reply-To: <20170523003945.14279-5-ebiggers3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Eric Biggers , linux-fscrypt@vger.kernel.org Cc: Theodore Ts'o , Eric Biggers , linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Jaegeuk Kim , linux-ext4@vger.kernel.org List-ID: On 2017/5/23 8:39, Eric Biggers wrote: > From: Eric Biggers > > Since only an open file can be written to, and we only allow open()ing > an encrypted file when its key is available, there is no need to check > for the key again before permitting each ->write_iter(). > > This code was also broken in that it wouldn't actually have failed if > the key was in fact unavailable. > > Signed-off-by: Eric Biggers Acked-by: Chao Yu Thanks, > --- > fs/f2fs/file.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index ff4db3efc0ac..3ccc63089a47 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -2318,11 +2318,6 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > struct blk_plug plug; > ssize_t ret; > > - if (f2fs_encrypted_inode(inode) && > - !fscrypt_has_encryption_key(inode) && > - fscrypt_get_encryption_info(inode)) > - return -EACCES; > - > inode_lock(inode); > ret = generic_write_checks(iocb, from); > if (ret > 0) { > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 4/4] f2fs: don't bother checking for encryption key in ->write_iter() Date: Tue, 23 May 2017 21:39:13 +0800 Message-ID: <6016f168-9c2b-e7a6-4d21-9b40c4cb6edc@kernel.org> References: <20170523003945.14279-1-ebiggers3@gmail.com> <20170523003945.14279-5-ebiggers3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Theodore Ts'o , Eric Biggers , linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Jaegeuk Kim , linux-ext4@vger.kernel.org To: Eric Biggers , linux-fscrypt@vger.kernel.org Return-path: In-Reply-To: <20170523003945.14279-5-ebiggers3@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-ext4.vger.kernel.org On 2017/5/23 8:39, Eric Biggers wrote: > From: Eric Biggers > > Since only an open file can be written to, and we only allow open()ing > an encrypted file when its key is available, there is no need to check > for the key again before permitting each ->write_iter(). > > This code was also broken in that it wouldn't actually have failed if > the key was in fact unavailable. > > Signed-off-by: Eric Biggers Acked-by: Chao Yu Thanks, > --- > fs/f2fs/file.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index ff4db3efc0ac..3ccc63089a47 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -2318,11 +2318,6 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > struct blk_plug plug; > ssize_t ret; > > - if (f2fs_encrypted_inode(inode) && > - !fscrypt_has_encryption_key(inode) && > - fscrypt_get_encryption_info(inode)) > - return -EACCES; > - > inode_lock(inode); > ret = generic_write_checks(iocb, from); > if (ret > 0) { > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot