From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file Date: Thu, 09 Apr 2015 23:17:48 +0200 Message-ID: <6018110.XP6YK3PMra@wuerfel> References: <1428601031-5366-1-git-send-email-galak@codeaurora.org> <1428601031-5366-5-git-send-email-galak@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.126.130]:55916 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754298AbbDIVR5 (ORCPT ); Thu, 9 Apr 2015 17:17:57 -0400 In-Reply-To: <1428601031-5366-5-git-send-email-galak@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Kumar Gala Cc: linux-arm-msm@vger.kernel.org, Abhimanyu Kapur , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com On Thursday 09 April 2015 12:37:10 Kumar Gala wrote: > From: Abhimanyu Kapur > > Move the secondary_pen_release variable and the secondary_holding_pen > entry function to asm/smp_plat.h so that the other cpu ops implementations > can share them. > > Signed-off-by: Abhimanyu Kapur > Signed-off-by: Kumar Gala > I don't believe your SMP implementation can be so broken to require this. Please fix the code instead to not use a holding pen. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 09 Apr 2015 23:17:48 +0200 Subject: [RFC PATCH 4/5] arm64: smp: move the pen to a header file In-Reply-To: <1428601031-5366-5-git-send-email-galak@codeaurora.org> References: <1428601031-5366-1-git-send-email-galak@codeaurora.org> <1428601031-5366-5-git-send-email-galak@codeaurora.org> Message-ID: <6018110.XP6YK3PMra@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 09 April 2015 12:37:10 Kumar Gala wrote: > From: Abhimanyu Kapur > > Move the secondary_pen_release variable and the secondary_holding_pen > entry function to asm/smp_plat.h so that the other cpu ops implementations > can share them. > > Signed-off-by: Abhimanyu Kapur > Signed-off-by: Kumar Gala > I don't believe your SMP implementation can be so broken to require this. Please fix the code instead to not use a holding pen. Arnd