* [PATCH] extcon: axp288: fix link error
@ 2018-04-16 8:40 Tobias Regnery
2018-04-16 10:02 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Regnery @ 2018-04-16 8:40 UTC (permalink / raw)
To: cw00.choi, myungjoo.ham, wens, hdegoede, linux-kernel; +Cc: Tobias Regnery
With CONFIG_AXP288=y and CONFIG_USB_COMMON=n there is the following link
error:
drivers/extcon/extcon-axp288.o: In function `axp288_put_role_sw':
extcon-axp288.c:(.text+0xa0): undefined reference to `usb_role_switch_put'
drivers/extcon/extcon-axp288.o: In function `axp288_usb_role_work':
extcon-axp288.c:(.text+0xec): undefined reference to `usb_role_switch_get_role'
extcon-axp288.c:(.text+0x12c): undefined reference to `usb_role_switch_set_role'
drivers/extcon/extcon-axp288.o: In function `axp288_extcon_probe':
extcon-axp288.c:(.text+0x59d): undefined reference to `usb_role_switch_get'
The above functions are defined in drivers/usb/common/roles.c, but the build
system only enters the common directory depending on CONFIG_USB_COMMON. Fix
this by selecting the USB_COMMON symbol.
Fixes: d54f063cdbe4 ("extcon: axp288: Set USB role where necessary")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
Hi,
there is another solution for this problem: replace depends on USB_SUPPORT
with depends on USB, but since CONFIG_USB selects other symbols I went
with the minimal fix and select the USB_COMMON symbol.
---
drivers/extcon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index de15bf55895b..0897bee54c2b 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -31,6 +31,7 @@ config EXTCON_ARIZONA
config EXTCON_AXP288
tristate "X-Power AXP288 EXTCON support"
depends on MFD_AXP20X && USB_SUPPORT && X86
+ select USB_COMMON
select USB_ROLE_SWITCH
help
Say Y here to enable support for USB peripheral detection
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: axp288: fix link error
2018-04-16 8:40 [PATCH] extcon: axp288: fix link error Tobias Regnery
@ 2018-04-16 10:02 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-04-16 10:02 UTC (permalink / raw)
To: Tobias Regnery, cw00.choi, myungjoo.ham, wens, linux-kernel
Hi,
On 16-04-18 10:40, Tobias Regnery wrote:
> With CONFIG_AXP288=y and CONFIG_USB_COMMON=n there is the following link
> error:
>
> drivers/extcon/extcon-axp288.o: In function `axp288_put_role_sw':
> extcon-axp288.c:(.text+0xa0): undefined reference to `usb_role_switch_put'
> drivers/extcon/extcon-axp288.o: In function `axp288_usb_role_work':
> extcon-axp288.c:(.text+0xec): undefined reference to `usb_role_switch_get_role'
> extcon-axp288.c:(.text+0x12c): undefined reference to `usb_role_switch_set_role'
> drivers/extcon/extcon-axp288.o: In function `axp288_extcon_probe':
> extcon-axp288.c:(.text+0x59d): undefined reference to `usb_role_switch_get'
>
> The above functions are defined in drivers/usb/common/roles.c, but the build
> system only enters the common directory depending on CONFIG_USB_COMMON. Fix
> this by selecting the USB_COMMON symbol.
>
> Fixes: d54f063cdbe4 ("extcon: axp288: Set USB role where necessary")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
Patch looks good to me, thanks:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> Hi,
>
> there is another solution for this problem: replace depends on USB_SUPPORT
> with depends on USB, but since CONFIG_USB selects other symbols I went
> with the minimal fix and select the USB_COMMON symbol.
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index de15bf55895b..0897bee54c2b 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -31,6 +31,7 @@ config EXTCON_ARIZONA
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> depends on MFD_AXP20X && USB_SUPPORT && X86
> + select USB_COMMON
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-16 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 8:40 [PATCH] extcon: axp288: fix link error Tobias Regnery
2018-04-16 10:02 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.