From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver Date: Fri, 22 Sep 2017 09:35:29 +0200 Message-ID: <60248422.eIQP2pKO6C@xps> References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com> <3516429.Zj0nEJyuAA@xps> <86d8df7b-60f4-b562-a197-6116f9bd0205@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, hemant.agrawal@nxp.com To: Shreyansh Jain Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D7687CB6 for ; Fri, 22 Sep 2017 09:35:31 +0200 (CEST) In-Reply-To: <86d8df7b-60f4-b562-a197-6116f9bd0205@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/09/2017 09:37, Shreyansh Jain: > On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote: > > 22/09/2017 08:47, Shreyansh Jain: > >> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: > >>> 23/08/2017 16:11, Shreyansh Jain: > >>>> --- a/MAINTAINERS > >>>> +++ b/MAINTAINERS > >>>> @@ -409,6 +409,7 @@ NXP dpaa > >>>> M: Hemant Agrawal > >>>> M: Shreyansh Jain > >>>> F: drivers/bus/dpaa/ > >>>> +F: drivers/mempool/dpaa/ > >>>> F: doc/guides/nics/dpaa.rst > >>>> F: doc/guides/nics/features/dpaa.ini > >>> > >>> This kind of patch can be squashed in the first patch introducing > >>> this new directory. > >> > >> Then the patch script (devtools/check-git-log.sh) reports error - I > >> think. That is the primary reason I split them across multiple patches. > >> You sure that doesn't matter? > > > > Which error? > > > > To be clear I suggest to squash with patch 19 where > > drivers/mempool/dpaa/Makefile is introduced. > > Yes, I understand that. > It would report error that the headline is wrong because I am hitting > different directories - "MAINTAINERS" and "drivers/mempool/*" with the > same patch having headline "mempool/*". The test you are talking about has this comment: # check headline prefix when touching only drivers, e.g. net/ If you hit a warning, there is a bug.