From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7176EC3B187 for ; Tue, 11 Feb 2020 14:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52768206DB for ; Tue, 11 Feb 2020 14:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730098AbgBKOvK (ORCPT ); Tue, 11 Feb 2020 09:51:10 -0500 Received: from foss.arm.com ([217.140.110.172]:47298 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727762AbgBKOvK (ORCPT ); Tue, 11 Feb 2020 09:51:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8588030E; Tue, 11 Feb 2020 06:51:09 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D7B6F3F68E; Tue, 11 Feb 2020 06:51:03 -0800 (PST) Subject: Re: [PATCHv9 00/12] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs To: Laurentiu Tudor , Li Yang , Olof Johansson Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Lorenzo Pieralisi , "arnd@arndb.de" , "m.karthikeyan@mobiveil.co.in" , "linux-pci@vger.kernel.org" , "Z.q. Hou" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , "M.h. Lian" , "robh+dt@kernel.org" , Xiaowei Bao , "catalin.marinas@arm.com" , "bhelgaas@google.com" , "andrew.murray@arm.com" , "shawnguo@kernel.org" , Mingkai Hu , "linux-arm-kernel@lists.infradead.org" , Diana Madalina Craciun References: <20191120034451.30102-1-Zhiqiang.Hou@nxp.com> <20200110153347.GA29372@e121166-lin.cambridge.arm.com> <20200210152257.GD25745@shell.armlinux.org.uk> <27e0acfc-0782-bd97-a80e-1143f1315891@nxp.com> From: Robin Murphy Message-ID: <60272422-b4c8-a86a-fa73-c158f723acb4@arm.com> Date: Tue, 11 Feb 2020 14:51:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <27e0acfc-0782-bd97-a80e-1143f1315891@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2020 1:55 pm, Laurentiu Tudor wrote: > > > On 11.02.2020 15:04, Robin Murphy wrote: >> On 2020-02-11 12:13 pm, Laurentiu Tudor wrote: >> [...] >>>> This is a known issue about DPAA2 MC bus not working well with SMMU >>>> based IO mapping.  Adding Laurentiu to the chain who has been looking >>>> into this issue. >>> >>> Yes, I'm closely following the issue. I actually have a workaround >>> (attached) but haven't submitted as it will probably raise a lot of >>> eyebrows. In the mean time I'm following some discussions [1][2][3] >>> on the iommu list which seem to try to tackle what appears to be a >>> similar issue but with framebuffers. My hope is that we will be able >>> to leverage whatever turns out. >> >> Indeed it's more general than framebuffers - in fact there was a >> specific requirement from the IORT side to accommodate network/storage >> controllers with in-memory firmware/configuration data/whatever set up >> by the bootloader that want to be handed off 'live' to Linux because >> the overhead of stopping and restarting them is impractical. Thus this >> DPAA2 setup is very much within scope of the desired solution, so >> please feel free to join in (particularly on the DT parts) :) > > Will sure do. Seems that the 2nd approach (the one with list of > compatibles in arm-smmu) fits really well with our scenario. Will this > be the way to go forward? I'm hoping that Thierry's proposal can be made to work out, since it's closer to how the ACPI version should work, which means we would be able to do a lot more in shared common code rather than baking magic knowledge and duplicated functionality into individual IOMMU drivers. >> As for right now, note that your patch would only be a partial >> mitigation to slightly reduce the fault window but not remove it >> entirely. To be robust the SMMU driver *has* to know about live >> streams before the first arm_smmu_reset() - hence the need for generic >> firmware bindings - so doing anything from the MC driver is already >> too late (and indeed the current iommu_request_dm_for_dev() mechanism >> is itself a microcosm of the same problem). > > I think you might have missed in the patch that it pauses the firmware > at early boot, in its driver init and it resumes it only after > iommu_request_dm_for_dev() has completed. :) Ah, from the context I missed that that was non-modular and relying on initcall trickery... fair enough, in that case I'll downgrade my "it's insufficient" to "it's ugly and somewhat fragile" :P Thanks, Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2022C3B186 for ; Tue, 11 Feb 2020 14:51:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93FA820675 for ; Tue, 11 Feb 2020 14:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CLbbzTsQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93FA820675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gpwgl9xP+DInz40D9oyBFke51HtK7d8PYK7580M5M20=; b=CLbbzTsQyGTkXXinZEdIAKvDp 3uWUkErbJyCaSOY19h5Uxsv/WEvSk8RHjGWcOhnqaAHugveLNL9SQEj5n38/BjRSyHj1vpKg5hGXv kWEYdnGOwjmtFMrziM8zCnlE5kDbWILOCFMyzkyMuLPQv+xWzFrx8D1bKq9DqDFdrN47uFU3NO5xt aWWZaKfGdD6fZfbmIH0/agMul4AE8ClYI7XCyhqHv5WCG5gR8bkTQevPccvw/NfzNrsuoXKc+3jHV oEybgesMuQz1J/Q126CkPRAq9eBp9WcVWSqrTtOTOs1MG8+rlpgJA5ebdMn8LF0LCYkcq/F631bd+ K1yAS8iIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1Wsd-0006D0-Ep; Tue, 11 Feb 2020 14:51:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1Wsa-0006B8-J2 for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 14:51:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8588030E; Tue, 11 Feb 2020 06:51:09 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D7B6F3F68E; Tue, 11 Feb 2020 06:51:03 -0800 (PST) Subject: Re: [PATCHv9 00/12] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs To: Laurentiu Tudor , Li Yang , Olof Johansson References: <20191120034451.30102-1-Zhiqiang.Hou@nxp.com> <20200110153347.GA29372@e121166-lin.cambridge.arm.com> <20200210152257.GD25745@shell.armlinux.org.uk> <27e0acfc-0782-bd97-a80e-1143f1315891@nxp.com> From: Robin Murphy Message-ID: <60272422-b4c8-a86a-fa73-c158f723acb4@arm.com> Date: Tue, 11 Feb 2020 14:51:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <27e0acfc-0782-bd97-a80e-1143f1315891@nxp.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_065112_713536_66F6A744 X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Lorenzo Pieralisi , "arnd@arndb.de" , "m.karthikeyan@mobiveil.co.in" , "linux-pci@vger.kernel.org" , "Z.q. Hou" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , Diana Madalina Craciun , "M.h. Lian" , "robh+dt@kernel.org" , Xiaowei Bao , "catalin.marinas@arm.com" , "bhelgaas@google.com" , "andrew.murray@arm.com" , "shawnguo@kernel.org" , Mingkai Hu , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvMDIvMjAyMCAxOjU1IHBtLCBMYXVyZW50aXUgVHVkb3Igd3JvdGU6Cj4gCj4gCj4gT24g MTEuMDIuMjAyMCAxNTowNCwgUm9iaW4gTXVycGh5IHdyb3RlOgo+PiBPbiAyMDIwLTAyLTExIDEy OjEzIHBtLCBMYXVyZW50aXUgVHVkb3Igd3JvdGU6Cj4+IFsuLi5dCj4+Pj4gVGhpcyBpcyBhIGtu b3duIGlzc3VlIGFib3V0IERQQUEyIE1DIGJ1cyBub3Qgd29ya2luZyB3ZWxsIHdpdGggU01NVQo+ Pj4+IGJhc2VkIElPIG1hcHBpbmcuwqAgQWRkaW5nIExhdXJlbnRpdSB0byB0aGUgY2hhaW4gd2hv IGhhcyBiZWVuIGxvb2tpbmcKPj4+PiBpbnRvIHRoaXMgaXNzdWUuCj4+Pgo+Pj4gWWVzLCBJJ20g Y2xvc2VseSBmb2xsb3dpbmcgdGhlIGlzc3VlLiBJIGFjdHVhbGx5IGhhdmUgYSB3b3JrYXJvdW5k IAo+Pj4gKGF0dGFjaGVkKSBidXQgaGF2ZW4ndCBzdWJtaXR0ZWQgYXMgaXQgd2lsbCBwcm9iYWJs eSByYWlzZSBhIGxvdCBvZiAKPj4+IGV5ZWJyb3dzLiBJbiB0aGUgbWVhbiB0aW1lIEknbSBmb2xs b3dpbmcgc29tZSBkaXNjdXNzaW9ucyBbMV1bMl1bM10gCj4+PiBvbiB0aGUgaW9tbXUgbGlzdCB3 aGljaCBzZWVtIHRvIHRyeSB0byB0YWNrbGUgd2hhdCBhcHBlYXJzIHRvIGJlIGEgCj4+PiBzaW1p bGFyIGlzc3VlIGJ1dCB3aXRoIGZyYW1lYnVmZmVycy4gTXkgaG9wZSBpcyB0aGF0IHdlIHdpbGwg YmUgYWJsZSAKPj4+IHRvIGxldmVyYWdlIHdoYXRldmVyIHR1cm5zIG91dC4KPj4KPj4gSW5kZWVk IGl0J3MgbW9yZSBnZW5lcmFsIHRoYW4gZnJhbWVidWZmZXJzIC0gaW4gZmFjdCB0aGVyZSB3YXMg YSAKPj4gc3BlY2lmaWMgcmVxdWlyZW1lbnQgZnJvbSB0aGUgSU9SVCBzaWRlIHRvIGFjY29tbW9k YXRlIG5ldHdvcmsvc3RvcmFnZSAKPj4gY29udHJvbGxlcnMgd2l0aCBpbi1tZW1vcnkgZmlybXdh cmUvY29uZmlndXJhdGlvbiBkYXRhL3doYXRldmVyIHNldCB1cCAKPj4gYnkgdGhlIGJvb3Rsb2Fk ZXIgdGhhdCB3YW50IHRvIGJlIGhhbmRlZCBvZmYgJ2xpdmUnIHRvIExpbnV4IGJlY2F1c2UgCj4+ IHRoZSBvdmVyaGVhZCBvZiBzdG9wcGluZyBhbmQgcmVzdGFydGluZyB0aGVtIGlzIGltcHJhY3Rp Y2FsLiBUaHVzIHRoaXMgCj4+IERQQUEyIHNldHVwIGlzIHZlcnkgbXVjaCB3aXRoaW4gc2NvcGUg b2YgdGhlIGRlc2lyZWQgc29sdXRpb24sIHNvIAo+PiBwbGVhc2UgZmVlbCBmcmVlIHRvIGpvaW4g aW4gKHBhcnRpY3VsYXJseSBvbiB0aGUgRFQgcGFydHMpIDopCj4gCj4gV2lsbCBzdXJlIGRvLiBT ZWVtcyB0aGF0IHRoZSAybmQgYXBwcm9hY2ggKHRoZSBvbmUgd2l0aCBsaXN0IG9mIAo+IGNvbXBh dGlibGVzIGluIGFybS1zbW11KSBmaXRzIHJlYWxseSB3ZWxsIHdpdGggb3VyIHNjZW5hcmlvLiBX aWxsIHRoaXMgCj4gYmUgdGhlIHdheSB0byBnbyBmb3J3YXJkPwoKSSdtIGhvcGluZyB0aGF0IFRo aWVycnkncyBwcm9wb3NhbCBjYW4gYmUgbWFkZSB0byB3b3JrIG91dCwgc2luY2UgaXQncyAKY2xv c2VyIHRvIGhvdyB0aGUgQUNQSSB2ZXJzaW9uIHNob3VsZCB3b3JrLCB3aGljaCBtZWFucyB3ZSB3 b3VsZCBiZSBhYmxlIAp0byBkbyBhIGxvdCBtb3JlIGluIHNoYXJlZCBjb21tb24gY29kZSByYXRo ZXIgdGhhbiBiYWtpbmcgbWFnaWMgCmtub3dsZWRnZSBhbmQgZHVwbGljYXRlZCBmdW5jdGlvbmFs aXR5IGludG8gaW5kaXZpZHVhbCBJT01NVSBkcml2ZXJzLgoKPj4gQXMgZm9yIHJpZ2h0IG5vdywg bm90ZSB0aGF0IHlvdXIgcGF0Y2ggd291bGQgb25seSBiZSBhIHBhcnRpYWwgCj4+IG1pdGlnYXRp b24gdG8gc2xpZ2h0bHkgcmVkdWNlIHRoZSBmYXVsdCB3aW5kb3cgYnV0IG5vdCByZW1vdmUgaXQg Cj4+IGVudGlyZWx5LiBUbyBiZSByb2J1c3QgdGhlIFNNTVUgZHJpdmVyICpoYXMqIHRvIGtub3cg YWJvdXQgbGl2ZSAKPj4gc3RyZWFtcyBiZWZvcmUgdGhlIGZpcnN0IGFybV9zbW11X3Jlc2V0KCkg LSBoZW5jZSB0aGUgbmVlZCBmb3IgZ2VuZXJpYyAKPj4gZmlybXdhcmUgYmluZGluZ3MgLSBzbyBk b2luZyBhbnl0aGluZyBmcm9tIHRoZSBNQyBkcml2ZXIgaXMgYWxyZWFkeSAKPj4gdG9vIGxhdGUg KGFuZCBpbmRlZWQgdGhlIGN1cnJlbnQgaW9tbXVfcmVxdWVzdF9kbV9mb3JfZGV2KCkgbWVjaGFu aXNtIAo+PiBpcyBpdHNlbGYgYSBtaWNyb2Nvc20gb2YgdGhlIHNhbWUgcHJvYmxlbSkuCj4gCj4g SSB0aGluayB5b3UgbWlnaHQgaGF2ZSBtaXNzZWQgaW4gdGhlIHBhdGNoIHRoYXQgaXQgcGF1c2Vz IHRoZSBmaXJtd2FyZSAKPiBhdCBlYXJseSBib290LCBpbiBpdHMgZHJpdmVyIGluaXQgYW5kIGl0 IHJlc3VtZXMgaXQgb25seSBhZnRlciAKPiBpb21tdV9yZXF1ZXN0X2RtX2Zvcl9kZXYoKSBoYXMg Y29tcGxldGVkLiA6KQoKQWgsIGZyb20gdGhlIGNvbnRleHQgSSBtaXNzZWQgdGhhdCB0aGF0IHdh cyBub24tbW9kdWxhciBhbmQgcmVseWluZyBvbiAKaW5pdGNhbGwgdHJpY2tlcnkuLi4gZmFpciBl bm91Z2gsIGluIHRoYXQgY2FzZSBJJ2xsIGRvd25ncmFkZSBteSAiaXQncyAKaW5zdWZmaWNpZW50 IiB0byAiaXQncyB1Z2x5IGFuZCBzb21ld2hhdCBmcmFnaWxlIiA6UAoKVGhhbmtzLApSb2Jpbi4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK