All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] cpu_hotplug: Add executable file's path
@ 2021-02-23  6:54 zhaogongyi
  2021-02-23  7:54 ` Yang Xu
  0 siblings, 1 reply; 6+ messages in thread
From: zhaogongyi @ 2021-02-23  6:54 UTC (permalink / raw)
  To: ltp

Hi Xu,

In many cases, we set a default path for executable file would be more friendly for user?

And in these cases, it is better to judge return value behind running cpuhotplug_do_spin_loop since the error info has been redirected to /dev/null? 


> 
> Hi Gongyi
> > When env PATH is not include current path, run
> > cpuhotplug_do_disk_write_loop/
> > cpuhotplug_do_spin_loop/cpuhotplug_do_kcompile_loop/
> > cpuhotplug_report_proc_interrupts will fail.
> >
> This patch is useless.
> 
> For shell-script case, usually, runltp will set environment variables.
> or, you need to set environment variables yourself if not want to use
> runltp(more info see[1]).
> For cpuhotplug02 case, we can run as below:
> #export LTPROOT=/opt/ltp
> #export PATH="$PATH:$LTPROOT/testcases/bin"
> #cpuhotplug02.sh -c 1 -l 1
> 
> [1]https://github.com/linux-test-project/ltp/blob/master/README.md
> 
> Best Regards
> Yang Xu
> > For those:
> > 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> > 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> > 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> > 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> >
> > Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
> > ---
> >   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh     | 4
> ++--
> >   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh     | 2
> +-
> >   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh     | 2
> +-
> >   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh     | 2
> +-
> >   4 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git
> > a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> > b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> > index 1ba937cc7..b1c8a9b97 100755
> > --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> > +++
> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> > @@ -137,7 +137,7 @@ cpu_states=$(get_all_cpu_states)
> >   CPU_COUNT=0
> >
> >   # Start up a process that writes to disk; keep track of its PID
> > -cpuhotplug_do_disk_write_loop>  /dev/null 2>&1&
> > +./cpuhotplug_do_disk_write_loop>  /dev/null 2>&1&
> >   WRL_ID=$!
> >
> >   until [ $LOOP_COUNT -gt $HOTPLUG01_LOOPS ] @@ -181,7 +181,7
> @@ do
> >   	# Print out a report showing the changes in IRQs
> >   	echo
> >   	echo
> > -	cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
> > +	./cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
> >   	echo
> >
> >   	sleep $TM_DLY
> > diff --git
> > a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> > b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> > index 792f8cd73..f8a1395c1 100755
> > --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> > +++
> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> > @@ -77,7 +77,7 @@ fi
> >   TST_CLEANUP=do_clean
> >
> >   # Start up a process that just uses CPU cycles
> > -cpuhotplug_do_spin_loop>  /dev/null&
> > +./cpuhotplug_do_spin_loop>  /dev/null&
> >   SPIN_LOOP_PID=$!
> >
> >   sleep 5
> > diff --git
> > a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> > b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> > index 9ea49f0e1..75a05a3c9 100755
> > --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> > +++
> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> > @@ -102,7 +102,7 @@ until [ $LOOP_COUNT -gt
> $HOTPLUG03_LOOPS ]; do
> >   	# so we can kill them later.
> >   	number_of_procs=$((cpus_num*2))
> >   	until [ $number_of_procs -eq 0 ]; do
> > -		cpuhotplug_do_spin_loop>  /dev/null 2>&1&
> > +		./cpuhotplug_do_spin_loop>  /dev/null 2>&1&
> >   		echo $!>>  /var/run/hotplug4_$$.pid
> >   		number_of_procs=$((number_of_procs-1))
> >   	done
> > diff --git
> > a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> > b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> > index 278304618..e8ab78e8c 100755
> > --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> > +++
> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> > @@ -81,7 +81,7 @@ fi
> >
> >   TST_CLEANUP=do_clean
> >
> > -cpuhotplug_do_kcompile_loop $KERNEL_DIR>  /dev/null 2>&1&
> > +./cpuhotplug_do_kcompile_loop $KERNEL_DIR>  /dev/null 2>&1&
> >   KCOMPILE_LOOP_PID=$!
> >
> >   tst_resm TINFO "initial CPU affinity for kernel compile is: \
> > --
> > 2.17.1
> >
> >
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [LTP] [PATCH] cpu_hotplug: Add executable file's path
  2021-02-23  6:54 [LTP] [PATCH] cpu_hotplug: Add executable file's path zhaogongyi
@ 2021-02-23  7:54 ` Yang Xu
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Xu @ 2021-02-23  7:54 UTC (permalink / raw)
  To: ltp

Hi gongyi
> Hi Xu,
>
> In many cases, we set a default path for executable file would be more friendly for user?
I think it is friendly to user. LTP has friendly documentation to 
mention this?

In user-guide.txt
https://github.com/linux-test-project/ltp/blob/master/doc/user-guide.txt

| 'LTPROOT'             | Prefix for installed LTP, the default is 
'/opt/ltp'

| 'PATH'                | It's required to addjust path:
                           `PATH="$PATH:$LTPROOT/testcases/bin"`

In README.md
Each test case has its own executable or script, these can be executed 
directly
$ testcases/bin/abort01
Some have arguments
$ testcases/bin/fork13 -i 37
The vast majority of test cases accept the -h (help) switch
$ testcases/bin/ioctl01 -h
Many require certain environment variables to be set
$ LTPROOT=/opt/ltp PATH="$PATH:$LTPROOT/testcases/bin" testcases/bin/wc01.sh
Most commonly, the path variable needs to be set and also LTPROOT, but 
there are a number of other variables, runltp usually sets these for you.
Note that all shell scripts need the PATH to be set. However this is not 
limited to shell scripts, many C based tests need environment variables 
as well.

Also for some special case, like prctl06.c, we can use resource_files to 
copy some other execute file to some place.

>
> And in these cases, it is better to judge return value behind running cpuhotplug_do_spin_loop since the error info has been redirected to /dev/null?
the cpuhotplug_do_spin_loop function only does a spin loop, IMO, it will 
not fail and here just make the output silent.


Best Regards
Yang Xu
>
>
>>
>> Hi Gongyi
>>> When env PATH is not include current path, run
>>> cpuhotplug_do_disk_write_loop/
>>> cpuhotplug_do_spin_loop/cpuhotplug_do_kcompile_loop/
>>> cpuhotplug_report_proc_interrupts will fail.
>>>
>> This patch is useless.
>>
>> For shell-script case, usually, runltp will set environment variables.
>> or, you need to set environment variables yourself if not want to use
>> runltp(more info see[1]).
>> For cpuhotplug02 case, we can run as below:
>> #export LTPROOT=/opt/ltp
>> #export PATH="$PATH:$LTPROOT/testcases/bin"
>> #cpuhotplug02.sh -c 1 -l 1
>>
>> [1]https://github.com/linux-test-project/ltp/blob/master/README.md
>>
>> Best Regards
>> Yang Xu
>>> For those:
>>> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
>>> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
>>>
>>> Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
>>> ---
>>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh     | 4
>> ++--
>>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh     | 2
>> +-
>>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh     | 2
>> +-
>>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh     | 2
>> +-
>>>    4 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git
>>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> index 1ba937cc7..b1c8a9b97 100755
>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> +++
>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> @@ -137,7 +137,7 @@ cpu_states=$(get_all_cpu_states)
>>>    CPU_COUNT=0
>>>
>>>    # Start up a process that writes to disk; keep track of its PID
>>> -cpuhotplug_do_disk_write_loop>   /dev/null 2>&1&
>>> +./cpuhotplug_do_disk_write_loop>   /dev/null 2>&1&
>>>    WRL_ID=$!
>>>
>>>    until [ $LOOP_COUNT -gt $HOTPLUG01_LOOPS ] @@ -181,7 +181,7
>> @@ do
>>>    	# Print out a report showing the changes in IRQs
>>>    	echo
>>>    	echo
>>> -	cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
>>> +	./cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
>>>    	echo
>>>
>>>    	sleep $TM_DLY
>>> diff --git
>>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
>>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
>>> index 792f8cd73..f8a1395c1 100755
>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
>>> +++
>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
>>> @@ -77,7 +77,7 @@ fi
>>>    TST_CLEANUP=do_clean
>>>
>>>    # Start up a process that just uses CPU cycles
>>> -cpuhotplug_do_spin_loop>   /dev/null&
>>> +./cpuhotplug_do_spin_loop>   /dev/null&
>>>    SPIN_LOOP_PID=$!
>>>
>>>    sleep 5
>>> diff --git
>>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> index 9ea49f0e1..75a05a3c9 100755
>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> +++
>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> @@ -102,7 +102,7 @@ until [ $LOOP_COUNT -gt
>> $HOTPLUG03_LOOPS ]; do
>>>    	# so we can kill them later.
>>>    	number_of_procs=$((cpus_num*2))
>>>    	until [ $number_of_procs -eq 0 ]; do
>>> -		cpuhotplug_do_spin_loop>   /dev/null 2>&1&
>>> +		./cpuhotplug_do_spin_loop>   /dev/null 2>&1&
>>>    		echo $!>>   /var/run/hotplug4_$$.pid
>>>    		number_of_procs=$((number_of_procs-1))
>>>    	done
>>> diff --git
>>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
>>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
>>> index 278304618..e8ab78e8c 100755
>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
>>> +++
>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
>>> @@ -81,7 +81,7 @@ fi
>>>
>>>    TST_CLEANUP=do_clean
>>>
>>> -cpuhotplug_do_kcompile_loop $KERNEL_DIR>   /dev/null 2>&1&
>>> +./cpuhotplug_do_kcompile_loop $KERNEL_DIR>   /dev/null 2>&1&
>>>    KCOMPILE_LOOP_PID=$!
>>>
>>>    tst_resm TINFO "initial CPU affinity for kernel compile is: \
>>> --
>>> 2.17.1
>>>
>>>
>>
>>
>
>
>
> .
>




^ permalink raw reply	[flat|nested] 6+ messages in thread
* [LTP] [PATCH] cpu_hotplug: Add executable file's path
  2021-02-23  9:13 zhaogongyi
@ 2021-02-23 10:14 ` Cyril Hrubis
  0 siblings, 0 replies; 6+ messages in thread
From: Cyril Hrubis @ 2021-02-23 10:14 UTC (permalink / raw)
  To: ltp

Hi!
> Thanks for your review!
> 
> In many embedded system, before running testcases we need type in the following lines:
> 
>     #export LTPROOT=/opt/ltp
>     #export PATH="$PATH:$LTPROOT/testcases/bin"
>     # cpuhotplug02.sh -c 1 -l 1
> 
> It is not convenient for running test after every login.

This is what you have to do if you are not using the runltp script and
that's it. We will not add workarounds into our testcases.


Also nobody stops you from writing a short wrapper script such as:

$ cat run_test.sh

#!/bin/sh

export LTPROOT=/opt/ltp
export PATH="$PATH:$LTPROOT/testcases/bin"

$@

And then using it as:

./run_test.sh cpuhotplug02.sh -c 1 -l 1

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [LTP] [PATCH] cpu_hotplug: Add executable file's path
@ 2021-02-23  9:13 zhaogongyi
  2021-02-23 10:14 ` Cyril Hrubis
  0 siblings, 1 reply; 6+ messages in thread
From: zhaogongyi @ 2021-02-23  9:13 UTC (permalink / raw)
  To: ltp

Hi Xu,

Thanks for your review!

In many embedded system, before running testcases we need type in the following lines:

    #export LTPROOT=/opt/ltp
    #export PATH="$PATH:$LTPROOT/testcases/bin"
    # cpuhotplug02.sh -c 1 -l 1

It is not convenient for running test after every login.

Can we change " cpuhotplug_do_disk_write_loop>   /dev/null 2>&1&" to " {BIN}/cpuhotplug_do_disk_write_loop>   /dev/null 2>&1&" and set BIN at init phase(for example in test.sh)

if [ -e $LTPROOT/testcases/bin ];then
	BIN=$LTPROOT/testcases/bin
else
	BIN=./
fi

So, we can run test like:

    #cd INSTALL_DIR
	#./cpuhotplug02.sh -c 1 -l 1

It is more efficient for testing in embedded system and is more friendly for one who don't know the file cpuhotplug02.sh depending on cpuhotplug_do_disk_write_loop.


And what do u think about this?


> 
> Hi gongyi
> > Hi Xu,
> >
> > In many cases, we set a default path for executable file would be more
> friendly for user?
> I think it is friendly to user. LTP has friendly documentation to mention this?
> 
> In user-guide.txt
> https://github.com/linux-test-project/ltp/blob/master/doc/user-guide.txt
> 
> | 'LTPROOT'             | Prefix for installed LTP, the default is
> '/opt/ltp'
> 
> | 'PATH'                | It's required to addjust path:
>                            `PATH="$PATH:$LTPROOT/testcases/bin"`
> 
> In README.md
> Each test case has its own executable or script, these can be executed
> directly $ testcases/bin/abort01 Some have arguments
> $ testcases/bin/fork13 -i 37 The vast majority of test cases accept the -h
> (help) switch $ testcases/bin/ioctl01 -h Many require certain environment
> variables to be set $ LTPROOT=/opt/ltp
> PATH="$PATH:$LTPROOT/testcases/bin" testcases/bin/wc01.sh Most
> commonly, the path variable needs to be set and also LTPROOT, but there
> are a number of other variables, runltp usually sets these for you.
> Note that all shell scripts need the PATH to be set. However this is not
> limited to shell scripts, many C based tests need environment variables as
> well.
> 
> Also for some special case, like prctl06.c, we can use resource_files to
> copy some other execute file to some place.
> 
> >
> > And in these cases, it is better to judge return value behind running
> cpuhotplug_do_spin_loop since the error info has been redirected to
> /dev/null?
> the cpuhotplug_do_spin_loop function only does a spin loop, IMO, it will
> not fail and here just make the output silent.
> 
> 
> Best Regards
> Yang Xu
> >
> >
> >>
> >> Hi Gongyi
> >>> When env PATH is not include current path, run
> >>> cpuhotplug_do_disk_write_loop/
> >>> cpuhotplug_do_spin_loop/cpuhotplug_do_kcompile_loop/
> >>> cpuhotplug_report_proc_interrupts will fail.
> >>>
> >> This patch is useless.
> >>
> >> For shell-script case, usually, runltp will set environment variables.
> >> or, you need to set environment variables yourself if not want to use
> >> runltp(more info see[1]).
> >> For cpuhotplug02 case, we can run as below:
> >> #export LTPROOT=/opt/ltp
> >> #export PATH="$PATH:$LTPROOT/testcases/bin"
> >> #cpuhotplug02.sh -c 1 -l 1
> >>
> >> [1]https://github.com/linux-test-project/ltp/blob/master/README.md
> >>
> >> Best Regards
> >> Yang Xu
> >>> For those:
> >>>
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> >>>
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> >>>
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> >>>
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> >>>
> >>> Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
> >>> ---
> >>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> | 4
> >> ++--
> >>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> | 2
> >> +-
> >>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> | 2
> >> +-
> >>>    .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> | 2
> >> +-
> >>>    4 files changed, 5 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git
> >>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> >>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> >>> index 1ba937cc7..b1c8a9b97 100755
> >>> ---
> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> >>> +++
> >> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> >>> @@ -137,7 +137,7 @@ cpu_states=$(get_all_cpu_states)
> >>>    CPU_COUNT=0
> >>>
> >>>    # Start up a process that writes to disk; keep track of its PID
> >>> -cpuhotplug_do_disk_write_loop>   /dev/null 2>&1&
> >>> +./cpuhotplug_do_disk_write_loop>   /dev/null 2>&1&
> >>>    WRL_ID=$!
> >>>
> >>>    until [ $LOOP_COUNT -gt $HOTPLUG01_LOOPS ] @@ -181,7
> +181,7
> >> @@ do
> >>>    	# Print out a report showing the changes in IRQs
> >>>    	echo
> >>>    	echo
> >>> -	cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
> >>> +	./cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
> >>>    	echo
> >>>
> >>>    	sleep $TM_DLY
> >>> diff --git
> >>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> >>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> >>> index 792f8cd73..f8a1395c1 100755
> >>> ---
> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> >>> +++
> >> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> >>> @@ -77,7 +77,7 @@ fi
> >>>    TST_CLEANUP=do_clean
> >>>
> >>>    # Start up a process that just uses CPU cycles
> >>> -cpuhotplug_do_spin_loop>   /dev/null&
> >>> +./cpuhotplug_do_spin_loop>   /dev/null&
> >>>    SPIN_LOOP_PID=$!
> >>>
> >>>    sleep 5
> >>> diff --git
> >>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> >>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> >>> index 9ea49f0e1..75a05a3c9 100755
> >>> ---
> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> >>> +++
> >> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> >>> @@ -102,7 +102,7 @@ until [ $LOOP_COUNT -gt
> >> $HOTPLUG03_LOOPS ]; do
> >>>    	# so we can kill them later.
> >>>    	number_of_procs=$((cpus_num*2))
> >>>    	until [ $number_of_procs -eq 0 ]; do
> >>> -		cpuhotplug_do_spin_loop>   /dev/null 2>&1&
> >>> +		./cpuhotplug_do_spin_loop>   /dev/null 2>&1&
> >>>    		echo $!>>   /var/run/hotplug4_$$.pid
> >>>    		number_of_procs=$((number_of_procs-1))
> >>>    	done
> >>> diff --git
> >>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> >>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> >>> index 278304618..e8ab78e8c 100755
> >>> ---
> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> >>> +++
> >> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> >>> @@ -81,7 +81,7 @@ fi
> >>>
> >>>    TST_CLEANUP=do_clean
> >>>
> >>> -cpuhotplug_do_kcompile_loop $KERNEL_DIR>   /dev/null 2>&1&
> >>> +./cpuhotplug_do_kcompile_loop $KERNEL_DIR>   /dev/null 2>&1&
> >>>    KCOMPILE_LOOP_PID=$!
> >>>
> >>>    tst_resm TINFO "initial CPU affinity for kernel compile is: \
> >>> --
> >>> 2.17.1
> >>>
> >>>
> >>
> >>
> >
> >
> >
> > .
> >
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [LTP] [PATCH] cpu_hotplug: Add executable file's path
  2021-02-23  3:37 Zhao Gongyi
@ 2021-02-23  5:15 ` Yang Xu
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Xu @ 2021-02-23  5:15 UTC (permalink / raw)
  To: ltp

Hi Gongyi
> When env PATH is not include current path, run cpuhotplug_do_disk_write_loop/
> cpuhotplug_do_spin_loop/cpuhotplug_do_kcompile_loop/
> cpuhotplug_report_proc_interrupts will fail.
>
This patch is useless.

For shell-script case, usually, runltp will set environment variables. 
or, you need to set environment variables yourself if not want to use 
runltp(more info see[1]).
For cpuhotplug02 case, we can run as below:
#export LTPROOT=/opt/ltp
#export PATH="$PATH:$LTPROOT/testcases/bin"
#cpuhotplug02.sh -c 1 -l 1

[1]https://github.com/linux-test-project/ltp/blob/master/README.md

Best Regards
Yang Xu
> For those:
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> 	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
>
> Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
> ---
>   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh     | 4 ++--
>   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh     | 2 +-
>   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh     | 2 +-
>   .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh     | 2 +-
>   4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> index 1ba937cc7..b1c8a9b97 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> @@ -137,7 +137,7 @@ cpu_states=$(get_all_cpu_states)
>   CPU_COUNT=0
>
>   # Start up a process that writes to disk; keep track of its PID
> -cpuhotplug_do_disk_write_loop>  /dev/null 2>&1&
> +./cpuhotplug_do_disk_write_loop>  /dev/null 2>&1&
>   WRL_ID=$!
>
>   until [ $LOOP_COUNT -gt $HOTPLUG01_LOOPS ]
> @@ -181,7 +181,7 @@ do
>   	# Print out a report showing the changes in IRQs
>   	echo
>   	echo
> -	cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
> +	./cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
>   	echo
>
>   	sleep $TM_DLY
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> index 792f8cd73..f8a1395c1 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
> @@ -77,7 +77,7 @@ fi
>   TST_CLEANUP=do_clean
>
>   # Start up a process that just uses CPU cycles
> -cpuhotplug_do_spin_loop>  /dev/null&
> +./cpuhotplug_do_spin_loop>  /dev/null&
>   SPIN_LOOP_PID=$!
>
>   sleep 5
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> index 9ea49f0e1..75a05a3c9 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> @@ -102,7 +102,7 @@ until [ $LOOP_COUNT -gt $HOTPLUG03_LOOPS ]; do
>   	# so we can kill them later.
>   	number_of_procs=$((cpus_num*2))
>   	until [ $number_of_procs -eq 0 ]; do
> -		cpuhotplug_do_spin_loop>  /dev/null 2>&1&
> +		./cpuhotplug_do_spin_loop>  /dev/null 2>&1&
>   		echo $!>>  /var/run/hotplug4_$$.pid
>   		number_of_procs=$((number_of_procs-1))
>   	done
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> index 278304618..e8ab78e8c 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
> @@ -81,7 +81,7 @@ fi
>
>   TST_CLEANUP=do_clean
>
> -cpuhotplug_do_kcompile_loop $KERNEL_DIR>  /dev/null 2>&1&
> +./cpuhotplug_do_kcompile_loop $KERNEL_DIR>  /dev/null 2>&1&
>   KCOMPILE_LOOP_PID=$!
>
>   tst_resm TINFO "initial CPU affinity for kernel compile is: \
> --
> 2.17.1
>
>




^ permalink raw reply	[flat|nested] 6+ messages in thread
* [LTP] [PATCH] cpu_hotplug: Add executable file's path
@ 2021-02-23  3:37 Zhao Gongyi
  2021-02-23  5:15 ` Yang Xu
  0 siblings, 1 reply; 6+ messages in thread
From: Zhao Gongyi @ 2021-02-23  3:37 UTC (permalink / raw)
  To: ltp

When env PATH is not include current path, run cpuhotplug_do_disk_write_loop/
cpuhotplug_do_spin_loop/cpuhotplug_do_kcompile_loop/
cpuhotplug_report_proc_interrupts will fail.

For those:
	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
	testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh     | 4 ++--
 .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh     | 2 +-
 .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh     | 2 +-
 .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh     | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
index 1ba937cc7..b1c8a9b97 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
@@ -137,7 +137,7 @@ cpu_states=$(get_all_cpu_states)
 CPU_COUNT=0

 # Start up a process that writes to disk; keep track of its PID
-cpuhotplug_do_disk_write_loop > /dev/null 2>&1 &
+./cpuhotplug_do_disk_write_loop > /dev/null 2>&1 &
 WRL_ID=$!

 until [ $LOOP_COUNT -gt $HOTPLUG01_LOOPS ]
@@ -181,7 +181,7 @@ do
 	# Print out a report showing the changes in IRQs
 	echo
 	echo
-	cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
+	./cpuhotplug_report_proc_interrupts "$IRQ_START" "$IRQ_END"
 	echo

 	sleep $TM_DLY
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
index 792f8cd73..f8a1395c1 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh
@@ -77,7 +77,7 @@ fi
 TST_CLEANUP=do_clean

 # Start up a process that just uses CPU cycles
-cpuhotplug_do_spin_loop > /dev/null&
+./cpuhotplug_do_spin_loop > /dev/null&
 SPIN_LOOP_PID=$!

 sleep 5
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
index 9ea49f0e1..75a05a3c9 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
@@ -102,7 +102,7 @@ until [ $LOOP_COUNT -gt $HOTPLUG03_LOOPS ]; do
 	# so we can kill them later.
 	number_of_procs=$((cpus_num*2))
 	until [ $number_of_procs -eq 0 ]; do
-		cpuhotplug_do_spin_loop > /dev/null 2>&1 &
+		./cpuhotplug_do_spin_loop > /dev/null 2>&1 &
 		echo $! >> /var/run/hotplug4_$$.pid
 		number_of_procs=$((number_of_procs-1))
 	done
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
index 278304618..e8ab78e8c 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh
@@ -81,7 +81,7 @@ fi

 TST_CLEANUP=do_clean

-cpuhotplug_do_kcompile_loop $KERNEL_DIR > /dev/null 2>&1 &
+./cpuhotplug_do_kcompile_loop $KERNEL_DIR > /dev/null 2>&1 &
 KCOMPILE_LOOP_PID=$!

 tst_resm TINFO "initial CPU affinity for kernel compile is: \
--
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-23 10:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23  6:54 [LTP] [PATCH] cpu_hotplug: Add executable file's path zhaogongyi
2021-02-23  7:54 ` Yang Xu
  -- strict thread matches above, loose matches on Subject: below --
2021-02-23  9:13 zhaogongyi
2021-02-23 10:14 ` Cyril Hrubis
2021-02-23  3:37 Zhao Gongyi
2021-02-23  5:15 ` Yang Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.