From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C00C43461 for ; Wed, 31 Mar 2021 21:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C62B261056 for ; Wed, 31 Mar 2021 21:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbhCaVAq (ORCPT ); Wed, 31 Mar 2021 17:00:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47246 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhCaVA1 (ORCPT ); Wed, 31 Mar 2021 17:00:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617224427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LQqUVLUZYdl8RcTGPBOfvhnoH130Hf3/RpFvvu9duY=; b=LygfMteufjDOoCwfEYkC2x8VvYk8LX3FbgkDA1/Bs0ggKwf0rqgabZabBpNHe91pELQ7In cqLsUGBosN3suqR7TPJ4wYLbbkD7/VUhgWoRAV6w+oUkpai1uxWYEgUPqh9Et4+ADO6sFc LpFSpHgXv4MBAMEdWAF8IsBmCWncAYA= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-LDHdG4FjPLa7M0MetabUdQ-1; Wed, 31 Mar 2021 17:00:23 -0400 X-MC-Unique: LDHdG4FjPLa7M0MetabUdQ-1 Received: by mail-ej1-f72.google.com with SMTP id p11so1360030eju.2 for ; Wed, 31 Mar 2021 14:00:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2LQqUVLUZYdl8RcTGPBOfvhnoH130Hf3/RpFvvu9duY=; b=ARM1bgxmV/z/hdJc27KSckcMktkw04qHrJg1AErRL8s8uRj6td1M226znsQRdvE5CJ M6qjDDieaOdei9abF0uKUDYnAnnfGO54pBfdEW7DzdWKFfViVgMCfTCL2R/eElq5azcH 13pWRYFmb7vh/Dk2WIeURbi4qAg2gWwhRHxR2byCih1B4xyIDpn5nUhwK/z5KGHKmT8B RpGYNfPmiG9xs5eYQ/peqodGraC3ACacF1bgPl2VENP1sqjF1G08MFu4mdIQMlLQbyvT eLzbhOVE5iUVSE1R8UnNpx7zGewQcfmhpnQhwzXrPrHaxFfDblOjKkRzNkU41uexE1tQ 9GjQ== X-Gm-Message-State: AOAM5327cEHwLbDcx9HMKat+gSyJKX0CYCUIVZjZ4ToQqKUPvG9kNwOL +1cFPNCbPs3jwC8hNo/wB3OiWcFpnwyQJkEDHXnjJ7W5nJTKXem/+0q9GOfrJtOO4H3UeTPKLkj KPZwjCJSE5cxoZG1iSwDS2B1X X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr6104499edr.374.1617224422623; Wed, 31 Mar 2021 14:00:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw50R87T4Vu7z/jVciLQACACQ+dsOT5/iwXfrDvSvIyaxglINHwXnv99OCNOBQhJmcFA6BI0w== X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr6104376edr.374.1617224421543; Wed, 31 Mar 2021 14:00:21 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x21sm2291820eds.53.2021.03.31.14.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 14:00:20 -0700 (PDT) Subject: Re: [PATCH 16/18] KVM: Don't take mmu_lock for range invalidation unless necessary To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-17-seanjc@google.com> <6e7dc7d0-f5dc-85d9-1c50-d23b761b5ff3@redhat.com> From: Paolo Bonzini Message-ID: <60357fd0-d412-fe47-8023-8107a60ade7e@redhat.com> Date: Wed, 31 Mar 2021 23:00:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/21 22:52, Sean Christopherson wrote: > 100% agree with introducing on_lock separately from the conditional locking. > > Not so sure about introducing conditional locking and then converting non-x86 > archs. I'd prefer to keep the conditional locking after arch conversion. > If something does go awry, it would be nice to be able to preciesly bisect to > the conditional locking. Ditto if it needs to be reverted because it breaks an > arch. Ok, that sounds good too. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9DAC433B4 for ; Wed, 31 Mar 2021 21:00:29 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3F15261075 for ; Wed, 31 Mar 2021 21:00:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F15261075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C1BDF4B4FE; Wed, 31 Mar 2021 17:00:28 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e966GOm6Mwtj; Wed, 31 Mar 2021 17:00:27 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BE95B4B4D8; Wed, 31 Mar 2021 17:00:27 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 165344B4D8 for ; Wed, 31 Mar 2021 17:00:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SkvvO5JqBjIi for ; Wed, 31 Mar 2021 17:00:25 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3EF644B494 for ; Wed, 31 Mar 2021 17:00:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617224424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LQqUVLUZYdl8RcTGPBOfvhnoH130Hf3/RpFvvu9duY=; b=XatB7QejBZNsCIdTlnbGqNfhVWokTxeLOX9iNKt5V+JhNXup4AQ1fdSX1vVzrrHeIcUA60 cPTzpFdkfNCslWHuG7pvw2kagXS13Fjtbcu+mDF5ot8AHT/+QCKijTuwlLG7DQnbqgToJV SDCBaoBwyzZjeyCuw3LL8JrX0LknkyU= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-zgx7vI5-Pu2auIahrQwEgw-1; Wed, 31 Mar 2021 17:00:22 -0400 X-MC-Unique: zgx7vI5-Pu2auIahrQwEgw-1 Received: by mail-ej1-f70.google.com with SMTP id r26so1352346eja.22 for ; Wed, 31 Mar 2021 14:00:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2LQqUVLUZYdl8RcTGPBOfvhnoH130Hf3/RpFvvu9duY=; b=DUtZ7uylv6bN4zweya87Jal+Cid5bt/iHSavHEThXJCXfwAYsBjQ7tv78hbKKw0RtO p2OplzymztqgRFE2dyj0PRHCTEpIDAOYe63LlqJRXN4HdBkqe1HtEZcn7Dx/5ttEJy2q ftJ0Kjne5hxF/tGRoc2S99rbZWedLybi0/E0YTkfA8PzI8qA7GlrV2UXUfF63S6GOGBz k/AlQcEjREqvDAHyGhlImh1Lwq7tFf2XvrnEa1Sf/8OArqQ5EwXK6Y5iiMVqFEu6nkt1 NcZBeEuVgvxTqdh2LN2WHR9w8k8Di410iV1rqXl3A6PKkvUNgom51h6pZtbRy+t79xtm o11w== X-Gm-Message-State: AOAM531hp5dc9k1rM83k0mGb3YS0fjwvAIjqoZnHek7vaituu7KXDWPl mAzgrSyEL02vJJ/GJWQVO58BHCa26mzWcMefvnPaKUYVRPpvsRTK5zOohIgC9XJI8jGq+j21lUB 7kWZAwZm9Ci8YVNNsyGr1uxz7 X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr6104413edr.374.1617224421716; Wed, 31 Mar 2021 14:00:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw50R87T4Vu7z/jVciLQACACQ+dsOT5/iwXfrDvSvIyaxglINHwXnv99OCNOBQhJmcFA6BI0w== X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr6104376edr.374.1617224421543; Wed, 31 Mar 2021 14:00:21 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x21sm2291820eds.53.2021.03.31.14.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 14:00:20 -0700 (PDT) Subject: Re: [PATCH 16/18] KVM: Don't take mmu_lock for range invalidation unless necessary To: Sean Christopherson References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-17-seanjc@google.com> <6e7dc7d0-f5dc-85d9-1c50-d23b761b5ff3@redhat.com> From: Paolo Bonzini Message-ID: <60357fd0-d412-fe47-8023-8107a60ade7e@redhat.com> Date: Wed, 31 Mar 2021 23:00:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, Marc Zyngier , Joerg Roedel , Huacai Chen , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Aleksandar Markovic , linux-arm-kernel@lists.infradead.org, Ben Gardon , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 31/03/21 22:52, Sean Christopherson wrote: > 100% agree with introducing on_lock separately from the conditional locking. > > Not so sure about introducing conditional locking and then converting non-x86 > archs. I'd prefer to keep the conditional locking after arch conversion. > If something does go awry, it would be nice to be able to preciesly bisect to > the conditional locking. Ditto if it needs to be reverted because it breaks an > arch. Ok, that sounds good too. Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41402C433B4 for ; Wed, 31 Mar 2021 21:02:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF5D161056 for ; Wed, 31 Mar 2021 21:02:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF5D161056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YgFCTBMH461thPd4ClgaNrQoY2zwcKn9NZ2YqgXRSLQ=; b=JksNxOgdbjmpLcoNt/ARKaQ9N kvaLBNRMGIotBMCdGlkmW6kK1aS/hy3kDFN3xVAs11TeDU1TIZTJ02uqPGI85k9OGsJRcTknv4W2B EWSbk/QOAb/QIx81GR+wighXGCvKyJqV7OvxQqLQPq5ch7U26kgmU24yCnfeaFipovrflo/nlEeE/ +xNy4jUijuswanH5T/t0hhFCEtrQXeyAogl9VUEHou24G0VsALuEQG9yVoQ2qFe+hzO3qtfZ0Ywom oFH/OSBZLkeJSTobJxoL8u6K00GjvJK1TG6r5ZIERMPfbA51wjl18Vf8IPVixSMy153EDZSBtGVbw 8LapKt49w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRhx4-007bed-WF; Wed, 31 Mar 2021 21:00:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRhwx-007bd3-Dy for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 21:00:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617224425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LQqUVLUZYdl8RcTGPBOfvhnoH130Hf3/RpFvvu9duY=; b=aJI/mCTuFXTQ4R9K5aOqHXaoS/Fe6UoCuahgFNQqaRcBfBxKJ7tyMzwMskLYepoBe7/+lh Q5sJ07jUVrD4x2orXZfe0Ten862GK9ZY1m6FjtgWBvJcb2kDdGsGxBPRDPhACZIPU9AceK 3QZCHhhVnLsfXYTvYpK2Gb8/AtpvhjI= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-538-lQ7xJFexM26YEBTzilolTA-1; Wed, 31 Mar 2021 17:00:22 -0400 X-MC-Unique: lQ7xJFexM26YEBTzilolTA-1 Received: by mail-ej1-f71.google.com with SMTP id h14so1363771ejg.7 for ; Wed, 31 Mar 2021 14:00:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2LQqUVLUZYdl8RcTGPBOfvhnoH130Hf3/RpFvvu9duY=; b=bzGufacbvUq2+PMlQM7CRizojd5tWn6WkC8ic8g4wQpEePIXnBY5U6jjafRPHlA/IH qKXR8b373G4/vJWVtaRIcWPZRiR2RaWmuDIaQZi8zNY0ZWUPwloPrdIOiQFS0ddcu5F8 vIdhyBOagE6OHrP6ZNcBtz7j0TcEDyWnRR2OtK0IWaJOHQmLKDZFr3K1zFeCExF3op7v UJm1axI/xZtwgXkICvfJeg3Fr//kBFA/BkagXdG5X252OKxXeuf7tL706yIlnj/pcL1t +jMSWQaqTvJ49rDA4R8XDd+Nw29US5nzdrOa9oLWI896I0GipgJMKvgvYR/sTh+4dmt1 UvHA== X-Gm-Message-State: AOAM531iTTCGGia57TMkk4v52Mlqu0JvMmC75dEeVMNdhhBtJWBwMece F4AJwL1sMgn37Nv8uqtjvFFMCJuDv/4tC8MZMxsWzAljrQyfqp0Qd8pduqyuSTSMGhypEAwMK+a iDLnsVuCq0PpMvcj1pGsU9vWm1tBPk8c9EGs= X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr6104392edr.374.1617224421672; Wed, 31 Mar 2021 14:00:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw50R87T4Vu7z/jVciLQACACQ+dsOT5/iwXfrDvSvIyaxglINHwXnv99OCNOBQhJmcFA6BI0w== X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr6104376edr.374.1617224421543; Wed, 31 Mar 2021 14:00:21 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x21sm2291820eds.53.2021.03.31.14.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 14:00:20 -0700 (PDT) Subject: Re: [PATCH 16/18] KVM: Don't take mmu_lock for range invalidation unless necessary To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-17-seanjc@google.com> <6e7dc7d0-f5dc-85d9-1c50-d23b761b5ff3@redhat.com> From: Paolo Bonzini Message-ID: <60357fd0-d412-fe47-8023-8107a60ade7e@redhat.com> Date: Wed, 31 Mar 2021 23:00:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_220027_877420_08829D5F X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/03/21 22:52, Sean Christopherson wrote: > 100% agree with introducing on_lock separately from the conditional locking. > > Not so sure about introducing conditional locking and then converting non-x86 > archs. I'd prefer to keep the conditional locking after arch conversion. > If something does go awry, it would be nice to be able to preciesly bisect to > the conditional locking. Ditto if it needs to be reverted because it breaks an > arch. Ok, that sounds good too. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Wed, 31 Mar 2021 21:00:19 +0000 Subject: Re: [PATCH 16/18] KVM: Don't take mmu_lock for range invalidation unless necessary Message-Id: <60357fd0-d412-fe47-8023-8107a60ade7e@redhat.com> List-Id: References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-17-seanjc@google.com> <6e7dc7d0-f5dc-85d9-1c50-d23b761b5ff3@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon On 31/03/21 22:52, Sean Christopherson wrote: > 100% agree with introducing on_lock separately from the conditional locking. > > Not so sure about introducing conditional locking and then converting non-x86 > archs. I'd prefer to keep the conditional locking after arch conversion. > If something does go awry, it would be nice to be able to preciesly bisect to > the conditional locking. Ditto if it needs to be reverted because it breaks an > arch. Ok, that sounds good too. Paolo