From: Juergen Gross <jgross@suse.com>
To: stefano@aporeto.com, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 0/2] Remove PAGE_SIZE from public headers
Date: Thu, 20 Oct 2016 07:10:07 +0200 [thread overview]
Message-ID: <6039b130-e26b-c791-92cc-51d99ae2d1d2@suse.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1610191123410.16441@sstabellini-ThinkPad-X260>
On 19/10/16 21:21, stefano@aporeto.com wrote:
> Reference to PAGE_SIZE slipped in to two public header files. QEMU build on
> ARM64 is broken by this. PAGE_SIZE should not be used because it could
> be undefined or it could be defined differently on different operating
> systems.
>
> Stefano Stabellini (2):
> usbif.h: replace PAGE_SIZE with USBIF_RING_SIZE
> vscsiif.h: replace PAGE_SIZE with VSCSIIF_PAGE_SIZE
>
> xen/include/public/io/usbif.h | 5 +++--
> xen/include/public/io/vscsiif.h | 3 ++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
In principle I'm okay with these changes. But wouldn't it be
better to add
#define XEN_RING_PAGE_SIZE 4096
to xen/include/public/io/ring.h instead of having each interface
file its own definition?
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-20 5:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 19:21 [PATCH v2 0/2] Remove PAGE_SIZE from public headers stefano
2016-10-19 19:22 ` [PATCH v2 1/2] usbif.h: replace PAGE_SIZE with USBIF_RING_SIZE Stefano Stabellini
2016-10-19 19:22 ` [PATCH v2 2/2] vscsiif.h: replace PAGE_SIZE with VSCSIIF_PAGE_SIZE Stefano Stabellini
2016-10-20 5:10 ` Juergen Gross [this message]
2016-10-20 19:09 ` [PATCH v2 0/2] Remove PAGE_SIZE from public headers Stefano Stabellini
2016-10-20 19:42 ` Andrew Cooper
2016-10-20 20:04 ` Stefano Stabellini
2016-10-20 20:05 ` Andrew Cooper
2016-10-20 20:38 ` Stefano Stabellini
2016-10-21 9:00 ` Wei Liu
2016-10-21 20:28 ` Stefano Stabellini
2016-10-21 8:59 ` Wei Liu
2016-10-21 20:08 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6039b130-e26b-c791-92cc-51d99ae2d1d2@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.