From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E25AC4743C for ; Mon, 21 Jun 2021 14:54:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AC1460C41 for ; Mon, 21 Jun 2021 14:54:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AC1460C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE2236E19B; Mon, 21 Jun 2021 14:54:09 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 32FC76E19B for ; Mon, 21 Jun 2021 14:54:09 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90D7F1042; Mon, 21 Jun 2021 07:54:08 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3D6E3F694; Mon, 21 Jun 2021 07:54:07 -0700 (PDT) Subject: Re: [PATCH v2 02/12] drm/panfrost: Get rid of the unused JS_STATUS_EVENT_ACTIVE definition To: Boris Brezillon References: <20210621133907.1683899-1-boris.brezillon@collabora.com> <20210621133907.1683899-3-boris.brezillon@collabora.com> <20210621164919.760ca377@collabora.com> From: Steven Price Message-ID: <60453a76-58b4-b1e1-b9d4-e7ebbf7e8689@arm.com> Date: Mon, 21 Jun 2021 15:54:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210621164919.760ca377@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Rob Herring , Robin Murphy , Alyssa Rosenzweig , Tomeu Vizoso Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 21/06/2021 15:49, Boris Brezillon wrote: > On Mon, 21 Jun 2021 15:34:35 +0100 > Steven Price wrote: > >> On 21/06/2021 14:38, Boris Brezillon wrote: >>> Exception types will be defined as an enum in panfrost_drm.h so userspace >>> and use the same definitions if needed. >> >> s/and/can/ ? >> >> While it is (currently) unused in the kernel, this is a hardware value >> so I'm not sure why it's worth removing this and not the other >> (currently) unused values here. This is the value returned from the >> JS_STATUS register when the slot is actively processing a job. > > Hm, what's the point of having the same value defined in 2 places > (DRM_PANFROST_EXCEPTION_ACTIVE defined in patch 3 vs > JS_STATUS_EVENT_ACTIVE here)? I mean, values defined in the > drm_panfrost_exception_type enum apply to the JS_STATUS registers too, > right? Thinking about this more I guess I agree with you: this is an oddity and your following patch adds a (more) complete list. You've convinced me - with my nit above fixed: Reviewed-by: Steven Price