All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Reinoud Zandijk <reinoud@NetBSD.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Kamil Rytarowski <kamil@NetBSD.org>,
	Ryo ONODERA <ryoon@netbsd.org>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support
Date: Fri, 2 Apr 2021 14:51:41 -0700	[thread overview]
Message-ID: <604abe90-5eda-bbbd-fd5a-5fb9c5c4cf9e@linaro.org> (raw)
In-Reply-To: <20210402202535.11550-3-reinoud@NetBSD.org>

On 4/2/21 1:25 PM, Reinoud Zandijk wrote:
> +i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true:
> +  declare_dependency(link_args: ['-lnvmm'])
> +)

You shouldn't be playing with link flags directly.

In patch 1, you found the nvmm library, and assigned it to the variable 'nvmm'. 
  You should just add the library as a dependency and let meson figure out what 
to do.

So I think this should just be

i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: nvmm)


r~


  reply	other threads:[~2021-04-02 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02 20:25 [PATCH v7 0/4] Implements the NetBSD Virtual Machine Monitor accelerator Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 1/4] Add NVMM accelerator: configure and build logic Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support Reinoud Zandijk
2021-04-02 21:51   ` Richard Henderson [this message]
2021-04-07 15:50     ` Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 3/4] Add NVMM accelerator: acceleration enlightenments Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 4/4] Add NVMM Accelerator: add maintainers for NetBSD/NVMM Reinoud Zandijk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=604abe90-5eda-bbbd-fd5a-5fb9c5c4cf9e@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=kamil@NetBSD.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=reinoud@NetBSD.org \
    --cc=ryoon@netbsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.