From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9238FC433FE for ; Wed, 12 Oct 2022 08:39:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbiJLIj1 (ORCPT ); Wed, 12 Oct 2022 04:39:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbiJLIjY (ORCPT ); Wed, 12 Oct 2022 04:39:24 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7232B40D4 for ; Wed, 12 Oct 2022 01:39:21 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id m29-20020a05600c3b1d00b003c6bf423c71so336286wms.0 for ; Wed, 12 Oct 2022 01:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hvXoD/VVs1JfrFZOMMsbQhdRyKbY5BarUuX5aidq38Y=; b=B+dmcHrOFnDJsNByaCqbLwnBYeVR0T8Bbjj3U7qdrXVj+1tlt6etlBxhzxZQD9fV7y ii2Wmb6253awru1Ql/zEWAvmzKzJMSRiDIypHxoeSWnJGwD8p+QROKqnaCRDTv4qm4Wj 6klF17H7g7eUfj4mxwU+iQRgEx9+RUnam1+PgUNhAaIaYPXGydBlz0CP/1CdylTXQTtW 1C9E8U+kkXhHAsPalclwWpNztwrDX3PhoQ8F5Up4H7ZjvVZo8RLx9LFOC9wPOJAVXM9E gmdlfbGdN6qK+2ZDVkRYaSfYvxJwBe5MJ7nkySW7VS4oZ+hN53V5Jo3+ySXIgvJDkEj7 eDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvXoD/VVs1JfrFZOMMsbQhdRyKbY5BarUuX5aidq38Y=; b=r2UFTgyJgRiqBVJK/tDntH/mU7Te7Y5p9vg7w16BhP+pw6DZ+3tYRRLkeJEq5sSfIc HZHBjVZ6GyRTNBNpmhfJVOGO4/s9ly+QWnof9lIgCBQXf7DjBLSObZjJmaD7UbB3DOMI efTd3EV7iILzplqUmuA1znq4Dta6sddM50OraXVOCRPSUkXmyRaoi9W9pcQTAulgayub 5WIlRwBYJMpXMLF0lbACnjs+pKkEnxglnfxR+XrDcLfqJv3eCaHxV62wQE9Bz2TwTItu Y2SFxVfgNbwnsvWtVawwIQUEv1Bdol5aAXs/s850ufLT/mmiT4vG1NBqk4cs4NRvOe/1 U3jg== X-Gm-Message-State: ACrzQf3tg9AAYcHoJHzmievO4qYcRw1frxyOKIIbzZYbRbDSesX7KEe4 gTmwv40oE3x3/nB57ZIcZ+V7ig== X-Google-Smtp-Source: AMsMyM4glDiV7BhepjKeAzqByR/Sam3MmgQWqu5AXGC5xtStDmrfsF0R1HiAZt9kVwUa0NaJu/4VSQ== X-Received: by 2002:a05:600c:46c9:b0:3c6:d853:4cb7 with SMTP id q9-20020a05600c46c900b003c6d8534cb7mr79213wmo.77.1665563960276; Wed, 12 Oct 2022 01:39:20 -0700 (PDT) Received: from [192.168.1.91] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id p1-20020a5d68c1000000b0022cce7689d3sm16438399wrw.36.2022.10.12.01.39.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 01:39:19 -0700 (PDT) Message-ID: <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> Date: Wed, 12 Oct 2022 10:39:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: Krzysztof Kozlowski , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> From: jerome Neanne In-Reply-To: <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2022 16:48, Krzysztof Kozlowski wrote: > On 11/10/2022 10:05, Jerome Neanne wrote: >> This adds defconfig option to support TPS65219 PMIC, MFD, Regulators > > Do not use "This commit/patch". > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > >> and power-button. > > You explained what you did, which is easily visible. You did not explain > why you are doing it. > > Best regards, > Krzysztof > Thanks for pointing me to the detailed guidelines I'm new to upstream and not well aware of all good practices. Would below commit message be more suitable: Add support for the TPS65219 PMIC by enabling MFD, regulator and power-button drivers. All drivers enabled as modules. Best regards Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70B8CC43219 for ; Wed, 12 Oct 2022 08:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UxyVZ91l2gyKhkQtximlpbWack4kKil6YtrcKCoo/AM=; b=jCrRuwOq3iW0fJ OKdhx48k2VWPQTGgn+JOZBoVnRBJoWttngkbk2+R4duxrlZVgRUReP7TpPsJYCwNGvucp+mjtJGLB Hp9tv9qsiiWe3bJz5Msc6htWGqk6PKuB+HrP2oR28H7gXWOZM+Ou5oyb3Vs6717pSJ1yn2Ph0QncG bZL4/MibPQt6P3p2oKAkjD30D3bFVlWTKS+qWf/tkqH7Y2dYIJ5t+tF1pL7chRMv5rZ/xEHtQe4OC xtz7MexiGjnuYiXS5WPQg4oyroXa15M9T4+jVD9jyMW8YNhnlYtMiZlfrCbU6vJoyn01nrifd6VSq uIBBeq2O23WCPvU1JaBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiXH7-007N58-Pe; Wed, 12 Oct 2022 08:39:37 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiXGt-007N00-2g for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 08:39:26 +0000 Received: by mail-wm1-x332.google.com with SMTP id e18so10010190wmq.3 for ; Wed, 12 Oct 2022 01:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hvXoD/VVs1JfrFZOMMsbQhdRyKbY5BarUuX5aidq38Y=; b=B+dmcHrOFnDJsNByaCqbLwnBYeVR0T8Bbjj3U7qdrXVj+1tlt6etlBxhzxZQD9fV7y ii2Wmb6253awru1Ql/zEWAvmzKzJMSRiDIypHxoeSWnJGwD8p+QROKqnaCRDTv4qm4Wj 6klF17H7g7eUfj4mxwU+iQRgEx9+RUnam1+PgUNhAaIaYPXGydBlz0CP/1CdylTXQTtW 1C9E8U+kkXhHAsPalclwWpNztwrDX3PhoQ8F5Up4H7ZjvVZo8RLx9LFOC9wPOJAVXM9E gmdlfbGdN6qK+2ZDVkRYaSfYvxJwBe5MJ7nkySW7VS4oZ+hN53V5Jo3+ySXIgvJDkEj7 eDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvXoD/VVs1JfrFZOMMsbQhdRyKbY5BarUuX5aidq38Y=; b=EQbLI8hm8QMbXZKZWOWG2LDDXhERxhK9tCxFA9NK9qfobeBMgPkZaZFxZUwfwzDzGC lI1uM6jPmItmsefuCQ+m/fhyL5Key7O6JL5aNWkNK0hpzw46N51bePAmO9ckg44G+EcV YpUmttUG07hFnZTq599szkH5PuqcmncgGovU3N8oNoUy6VtEZumLA9pp6jbeOdZl4+fO u8hEMsk8ThEZ/7+sUp4xP7WPaHsAwcr4qd8AbeyefT4nrS31uhVxkkCdbxVMetDLDKbY sUldGO9taiZimBhHDx3C1ppNWyh4VMVeBM3bpzBb9AWXAlnK5zE6HBIjCFLmwvyA+zMA HTRg== X-Gm-Message-State: ACrzQf216gmauSwUroiHx0WW5G/SgxydEX1zyECNO3VuyhxiEWX5+xve s8QcbFcP4bzqKbpW+fJrjZeHqQ== X-Google-Smtp-Source: AMsMyM4glDiV7BhepjKeAzqByR/Sam3MmgQWqu5AXGC5xtStDmrfsF0R1HiAZt9kVwUa0NaJu/4VSQ== X-Received: by 2002:a05:600c:46c9:b0:3c6:d853:4cb7 with SMTP id q9-20020a05600c46c900b003c6d8534cb7mr79213wmo.77.1665563960276; Wed, 12 Oct 2022 01:39:20 -0700 (PDT) Received: from [192.168.1.91] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id p1-20020a5d68c1000000b0022cce7689d3sm16438399wrw.36.2022.10.12.01.39.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 01:39:19 -0700 (PDT) Message-ID: <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> Date: Wed, 12 Oct 2022 10:39:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: Krzysztof Kozlowski , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> From: jerome Neanne In-Reply-To: <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_013923_373041_FFB7A0D1 X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/10/2022 16:48, Krzysztof Kozlowski wrote: > On 11/10/2022 10:05, Jerome Neanne wrote: >> This adds defconfig option to support TPS65219 PMIC, MFD, Regulators > > Do not use "This commit/patch". > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > >> and power-button. > > You explained what you did, which is easily visible. You did not explain > why you are doing it. > > Best regards, > Krzysztof > Thanks for pointing me to the detailed guidelines I'm new to upstream and not well aware of all good practices. Would below commit message be more suitable: Add support for the TPS65219 PMIC by enabling MFD, regulator and power-button drivers. All drivers enabled as modules. Best regards Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel