All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrei Gherzan" <andrei@gherzan.com>
To: "Ross Burton" <Ross.Burton@arm.com>
Cc: "meta-arm@lists.yoctoproject.org"
	<meta-arm@lists.yoctoproject.org>,
	"Andrei Gherzan" <andrei.gherzan@huawei.com>
Subject: Re: [meta-arm] [PATCH] edk2-firmware: Fix configure sed typo
Date: Thu, 15 Sep 2022 19:22:29 +0100	[thread overview]
Message-ID: <6051968b-52d6-4d3c-9d60-5d2c142fbb96@www.fastmail.com> (raw)
In-Reply-To: <3CC222DA-0230-4E52-9FE7-B1D2D9437344@arm.com>

Hi,

On Thu, 15 Sep 2022, at 16:06, Ross Burton wrote:
> On 15 Sep 2022, at 14:15, Andrei Gherzan via lists.yoctoproject.org 
> <andrei=gherzan.com@lists.yoctoproject.org> wrote:
>> -    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
>> +    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
>
> Did this break something for you, or is this a line that can actually 
> be removed?

It is definitely still needed. The template includes hardcoded values. It was breaking for me for arm EFI support.

Andrei


  reply	other threads:[~2022-09-15 18:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 13:15 [PATCH] edk2-firmware: Fix configure sed typo Andrei Gherzan
2022-09-15 15:06 ` [meta-arm] " Ross Burton
2022-09-15 18:22   ` Andrei Gherzan [this message]
2022-09-20 22:36 ` Jon Mason
2022-09-21 14:49   ` Andrei Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6051968b-52d6-4d3c-9d60-5d2c142fbb96@www.fastmail.com \
    --to=andrei@gherzan.com \
    --cc=Ross.Burton@arm.com \
    --cc=andrei.gherzan@huawei.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.