From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbeAPRDj (ORCPT + 1 other); Tue, 16 Jan 2018 12:03:39 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:53210 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbeAPRCx (ORCPT ); Tue, 16 Jan 2018 12:02:53 -0500 Subject: Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight To: Meghana Madhyastha , Lee Jones , Daniel Thompson , Jingoo Han , Thierry Reding , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <87984b3cb205b19d50f3093e34c6dc8d8179b768.1516098341.git.meghana.madhyastha@gmail.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <60567fff-a8ae-3388-fcc2-b2a33b37e1f1@tronnes.org> Date: Tue, 16 Jan 2018 18:02:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <87984b3cb205b19d50f3093e34c6dc8d8179b768.1516098341.git.meghana.madhyastha@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Den 16.01.2018 11.34, skrev Meghana Madhyastha: > Add devm_of_find_backlight and the corresponding release > function because some drivers use devres versions of functions > for acquiring device resources. > > Signed-off-by: Meghana Madhyastha checkpatch complains: -:26: WARNING: Block comments should align the * on each line This one is text so might as well fix it: -:29: WARNING: line over 80 characters With that fixed: Reviewed-by: Noralf Trønnes > --- > drivers/video/backlight/backlight.c | 29 +++++++++++++++++++++++++++++ > include/linux/backlight.h | 7 +++++++ > 2 files changed, 36 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 7e4a5d77d..b3f76945f 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -620,6 +620,35 @@ struct backlight_device *of_find_backlight(struct device *dev) > } > EXPORT_SYMBOL(of_find_backlight); > > +static void devm_backlight_put(void *data) > +{ > + backlight_put(data); > +} > + > +/** > + * devm_of_find_backlight - Resource-managed of_find_backlight() > + * @dev: Device > + * > + * Device managed version of of_find_backlight(). The reference on the backlight > + * device is automatically dropped on driver detach. > + */ > +struct backlight_device *devm_of_find_backlight(struct device *dev) > +{ > + struct backlight_device *bd; > + int ret; > + > + bd = of_find_backlight(dev); > + if (IS_ERR_OR_NULL(bd)) > + return bd; > + ret = devm_add_action(dev, devm_backlight_put, bd); > + if (ret) { > + backlight_put(bd); > + return ERR_PTR(ret); > + } > + return bd; > +} > +EXPORT_SYMBOL(devm_of_find_backlight); > + > static void __exit backlight_class_exit(void) > { > class_destroy(backlight_class); > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index 32ea510da..1d373f5a6 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -215,11 +215,18 @@ of_find_backlight_by_node(struct device_node *node) > > #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > struct backlight_device *of_find_backlight(struct device *dev); > +struct backlight_device *devm_of_find_backlight(struct device *dev); > #else > static inline struct backlight_device *of_find_backlight(struct device *dev) > { > return NULL; > } > + > +static inline struct backlight_device * > +devm_of_find_backlight(struct device *dev) > +{ > + return NULL; > +} > #endif > > #endif From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight Date: Tue, 16 Jan 2018 18:02:50 +0100 Message-ID: <60567fff-a8ae-3388-fcc2-b2a33b37e1f1@tronnes.org> References: <87984b3cb205b19d50f3093e34c6dc8d8179b768.1516098341.git.meghana.madhyastha@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE33A6E28D for ; Tue, 16 Jan 2018 17:02:53 +0000 (UTC) In-Reply-To: <87984b3cb205b19d50f3093e34c6dc8d8179b768.1516098341.git.meghana.madhyastha@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Meghana Madhyastha , Lee Jones , Daniel Thompson , Jingoo Han , Thierry Reding , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAxNi4wMS4yMDE4IDExLjM0LCBza3JldiBNZWdoYW5hIE1hZGh5YXN0aGE6Cj4gQWRkIGRl dm1fb2ZfZmluZF9iYWNrbGlnaHQgYW5kIHRoZSBjb3JyZXNwb25kaW5nIHJlbGVhc2UKPiBmdW5j dGlvbiBiZWNhdXNlIHNvbWUgZHJpdmVycyB1c2UgZGV2cmVzIHZlcnNpb25zIG9mIGZ1bmN0aW9u cwo+IGZvciBhY3F1aXJpbmcgZGV2aWNlIHJlc291cmNlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IE1l Z2hhbmEgTWFkaHlhc3RoYSA8bWVnaGFuYS5tYWRoeWFzdGhhQGdtYWlsLmNvbT4KCmNoZWNrcGF0 Y2ggY29tcGxhaW5zOgotOjI2OiBXQVJOSU5HOiBCbG9jayBjb21tZW50cyBzaG91bGQgYWxpZ24g dGhlICogb24gZWFjaCBsaW5lClRoaXMgb25lIGlzIHRleHQgc28gbWlnaHQgYXMgd2VsbCBmaXgg aXQ6Ci06Mjk6IFdBUk5JTkc6IGxpbmUgb3ZlciA4MCBjaGFyYWN0ZXJzCgpXaXRoIHRoYXQgZml4 ZWQ6ClJldmlld2VkLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KCj4g LS0tCj4gICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9iYWNrbGlnaHQuYyB8IDI5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gICBpbmNsdWRlL2xpbnV4L2JhY2tsaWdodC5oICAgICAg ICAgICB8ICA3ICsrKysrKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2JhY2tsaWdodC5jIGIvZHJp dmVycy92aWRlby9iYWNrbGlnaHQvYmFja2xpZ2h0LmMKPiBpbmRleCA3ZTRhNWQ3N2QuLmIzZjc2 OTQ1ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9iYWNrbGlnaHQuYwo+ ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2JhY2tsaWdodC5jCj4gQEAgLTYyMCw2ICs2 MjAsMzUgQEAgc3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKm9mX2ZpbmRfYmFja2xpZ2h0KHN0cnVj dCBkZXZpY2UgKmRldikKPiAgIH0KPiAgIEVYUE9SVF9TWU1CT0wob2ZfZmluZF9iYWNrbGlnaHQp Owo+ICAgCj4gK3N0YXRpYyB2b2lkIGRldm1fYmFja2xpZ2h0X3B1dCh2b2lkICpkYXRhKQo+ICt7 Cj4gKwliYWNrbGlnaHRfcHV0KGRhdGEpOwo+ICt9Cj4gKwo+ICsvKioKPiArICAqIGRldm1fb2Zf ZmluZF9iYWNrbGlnaHQgLSBSZXNvdXJjZS1tYW5hZ2VkIG9mX2ZpbmRfYmFja2xpZ2h0KCkKPiAr ICAqIEBkZXY6IERldmljZQo+ICsgICoKPiArICAqIERldmljZSBtYW5hZ2VkIHZlcnNpb24gb2Yg b2ZfZmluZF9iYWNrbGlnaHQoKS4gVGhlIHJlZmVyZW5jZSBvbiB0aGUgYmFja2xpZ2h0Cj4gKyAg KiBkZXZpY2UgaXMgYXV0b21hdGljYWxseSBkcm9wcGVkIG9uIGRyaXZlciBkZXRhY2guCj4gKyAg Ki8KPiArc3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKmRldm1fb2ZfZmluZF9iYWNrbGlnaHQoc3Ry dWN0IGRldmljZSAqZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAqYmQ7Cj4g KwlpbnQgcmV0Owo+ICsKPiArCWJkID0gb2ZfZmluZF9iYWNrbGlnaHQoZGV2KTsKPiArCWlmIChJ U19FUlJfT1JfTlVMTChiZCkpCj4gKwkJcmV0dXJuIGJkOwo+ICsJcmV0ID0gZGV2bV9hZGRfYWN0 aW9uKGRldiwgZGV2bV9iYWNrbGlnaHRfcHV0LCBiZCk7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJYmFj a2xpZ2h0X3B1dChiZCk7Cj4gKwkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiArCX0KPiArCXJldHVy biBiZDsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKGRldm1fb2ZfZmluZF9iYWNrbGlnaHQpOwo+ICsK PiAgIHN0YXRpYyB2b2lkIF9fZXhpdCBiYWNrbGlnaHRfY2xhc3NfZXhpdCh2b2lkKQo+ICAgewo+ ICAgCWNsYXNzX2Rlc3Ryb3koYmFja2xpZ2h0X2NsYXNzKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVk ZS9saW51eC9iYWNrbGlnaHQuaCBiL2luY2x1ZGUvbGludXgvYmFja2xpZ2h0LmgKPiBpbmRleCAz MmVhNTEwZGEuLjFkMzczZjVhNiAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L2JhY2tsaWdo dC5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaAo+IEBAIC0yMTUsMTEgKzIxNSwx OCBAQCBvZl9maW5kX2JhY2tsaWdodF9ieV9ub2RlKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSkK PiAgIAo+ICAgI2lmIElTX0VOQUJMRUQoQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UpCj4g ICBzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAqb2ZfZmluZF9iYWNrbGlnaHQoc3RydWN0IGRldmlj ZSAqZGV2KTsKPiArc3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKmRldm1fb2ZfZmluZF9iYWNrbGln aHQoc3RydWN0IGRldmljZSAqZGV2KTsKPiAgICNlbHNlCj4gICBzdGF0aWMgaW5saW5lIHN0cnVj dCBiYWNrbGlnaHRfZGV2aWNlICpvZl9maW5kX2JhY2tsaWdodChzdHJ1Y3QgZGV2aWNlICpkZXYp Cj4gICB7Cj4gICAJcmV0dXJuIE5VTEw7Cj4gICB9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIHN0cnVj dCBiYWNrbGlnaHRfZGV2aWNlICoKPiArZGV2bV9vZl9maW5kX2JhY2tsaWdodChzdHJ1Y3QgZGV2 aWNlICpkZXYpCj4gK3sKPiArCXJldHVybiBOVUxMOwo+ICt9Cj4gICAjZW5kaWYKPiAgIAo+ICAg I2VuZGlmCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK