All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: tj@kernel.org, ast@kernel.org, mark.rutland@arm.com,
	richard@nod.at, sp3485@columbia.edu, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 3/3] bpf: do not test for PCPU_MIN_UNIT_SIZE before percpu allocations
Date: Tue, 17 Oct 2017 09:29:26 -0700	[thread overview]
Message-ID: <6067d705-dcc4-931a-a379-22311bbf0ee5@gmail.com> (raw)
In-Reply-To: <a11e92b8ba4f5270437caa629307c300bca37976.1508251210.git.daniel@iogearbox.net>

On 10/17/2017 07:55 AM, Daniel Borkmann wrote:
> PCPU_MIN_UNIT_SIZE is an implementation detail of the percpu
> allocator. Given we support __GFP_NOWARN now, lets just let
> the allocation request fail naturally instead. The two call
> sites from BPF mistakenly assumed __GFP_NOWARN would work, so
> no changes needed to their actual __alloc_percpu_gfp() calls
> which use the flag already.
> 
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---

Nice cleanup. Thanks!

Acked-by: John Fastabend <john.fastabend@gmail.com>

  parent reply	other threads:[~2017-10-17 16:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 14:55 [PATCH net 0/3] Fix for BPF devmap percpu allocation splat Daniel Borkmann
2017-10-17 14:55 ` [PATCH net 1/3] mm, percpu: add support for __GFP_NOWARN flag Daniel Borkmann
2017-10-17 15:53   ` Alexei Starovoitov
2017-10-17 14:55 ` [PATCH net 2/3] bpf: fix splat for illegal devmap percpu allocation Daniel Borkmann
2017-10-17 15:54   ` Alexei Starovoitov
2017-10-17 16:28   ` John Fastabend
2017-10-17 14:55 ` [PATCH net 3/3] bpf: do not test for PCPU_MIN_UNIT_SIZE before percpu allocations Daniel Borkmann
2017-10-17 15:55   ` Alexei Starovoitov
2017-10-17 16:29   ` John Fastabend [this message]
2017-10-17 15:03 ` [PATCH net 0/3] Fix for BPF devmap percpu allocation splat David Laight
2017-10-17 15:11   ` Daniel Borkmann
2017-10-18 13:25 ` Tejun Heo
2017-10-18 14:03   ` Daniel Borkmann
2017-10-18 14:22     ` Daniel Borkmann
2017-10-18 15:28       ` Alexei Starovoitov
2017-10-18 15:31         ` Daniel Borkmann
2017-10-18 21:45   ` Dennis Zhou
2017-10-21 16:00     ` Tejun Heo
2017-10-19 12:14 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6067d705-dcc4-931a-a379-22311bbf0ee5@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=sp3485@columbia.edu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.