From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBovkXOURfELvPYdUkPFe5MevlkN1XSpf0eEZssSzPT8wcl5AbbzpMqA37aAE/qxdtq/KI4Am ARC-Seal: i=1; a=rsa-sha256; t=1516377512; cv=none; d=google.com; s=arc-20160816; b=kXBgmSgSjNY9D6DB01x8Fg5WFtrms6I+12NLtyhze9ureo2E/lGr4IrV+7sjeF9XFR 3PHYFgj4FG8R+CkIXf+/OD0DD12KQ+NtUEKd24tmdbi2RFU5FII85yuITOstyeRAzY+U gRlep0TpjAeq5LRVRQPZhjyhY/3gR33qyUSNumoKRzHY9zIvAvJgie98qs3WDZc4CjAW EXnOGlAiK0AbhsJuctjMeDgJLNhcgOaTmIEyOEDIX/aLpQfghlOQfRVAke69cmehBH3D kHFIMnVU5TrW4ULVC2ZyVUMH5JAN/hfXD5wASRvWl6HSAxFEkecCPY3kmJhmphC/2Zrv D4Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=poC/QdJ4ndpIn8RqS/uTRNrtvZs0Lxp5pujmt6RbKv0=; b=Np0Rk03CGxrPgnFEjj41RCLMwp2KeuvqPiX+PP3NfTquXU8jQ2fRrkHIf6RUuJonzD 7GM9lvNrKOZ2l5XFA07biIy8diVEUlrkMd5NhhpZWZLYAYYqCr5wT9qhDjEc/hvq2bpg DCBtZwSU1CRGAHM/uL9MZAzXG4/ydhJeT8PHMCqP72C3jc1xnOO6SgRhSMmD04KDY75f vtbGtx111Y1xTi9JHsYHHhtn22RmYfOOplo4etq2sSn0gld3gUMJtK5PP5O7gYI3h8fn kFQ7QdVtX9Wc2QLAqZJuvkhVcpoBHJY4jWnodaqY0auEBpKPCQSGM6h18fxE9syNoNtU JxrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YSJJjttI; dkim=pass header.i=@codeaurora.org header.s=default header.b=YSJJjttI; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YSJJjttI; dkim=pass header.i=@codeaurora.org header.s=default header.b=YSJJjttI; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Jan 2018 21:28:31 +0530 From: poza@codeaurora.org To: Stefan Roese Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci In-Reply-To: References: <1516360204-1586-1-git-send-email-poza@codeaurora.org> <1516360204-1586-8-git-send-email-poza@codeaurora.org> Message-ID: <60704cf1854c539f514e859a1f8adc63@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590018961580197637?= X-GMAIL-MSGID: =?utf-8?q?1590037066261086417?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-19 19:49, Stefan Roese wrote: > On 19.01.2018 12:10, Oza Pawandeep wrote: >> Clients such as pciehp, dpc are using pcie_wait_link_active, which >> waits >> till the link becomes active or inactive. >> >> Made generic function and moved it to drivers/pci/pci.c >> >> Signed-off-by: Oza Pawandeep >> >> diff --git a/drivers/pci/hotplug/pciehp_hpc.c >> b/drivers/pci/hotplug/pciehp_hpc.c >> index 7bab060..26afeff 100644 >> --- a/drivers/pci/hotplug/pciehp_hpc.c >> +++ b/drivers/pci/hotplug/pciehp_hpc.c >> @@ -245,25 +245,12 @@ bool pciehp_check_link_active(struct controller >> *ctrl) >> return ret; >> } >> >> -static void __pcie_wait_link_active(struct controller *ctrl, bool >> active) >> +static bool pcie_wait_link_active(struct controller *ctrl) >> { >> - int timeout = 1000; >> - >> - if (pciehp_check_link_active(ctrl) == active) >> - return; >> - while (timeout > 0) { >> - msleep(10); >> - timeout -= 10; >> - if (pciehp_check_link_active(ctrl) == active) >> - return; >> - } >> - ctrl_dbg(ctrl, "Data Link Layer Link Active not %s in 1000 msec\n", >> - active ? "set" : "cleared"); >> -} >> + struct pci_dev *pdev = ctrl_dev(ctrl); >> + bool active = true; >> >> -static void pcie_wait_link_active(struct controller *ctrl) >> -{ >> - __pcie_wait_link_active(ctrl, true); >> + return pci_wait_for_link(pdev, active); >> } >> >> static bool pci_bus_check_dev(struct pci_bus *bus, int devfn) >> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c >> index 4a7c686..0de83ea 100644 >> --- a/drivers/pci/pci.c >> +++ b/drivers/pci/pci.c >> @@ -2805,7 +2805,7 @@ static void pci_std_enable_acs(struct pci_dev >> *dev) >> pci_read_config_word(dev, pos + PCI_ACS_CTRL, &ctrl); >> >> /* Source Validation */ >> - ctrl |= (cap & PCI_ACS_SV); >> +// ctrl |= (cap & PCI_ACS_SV); > > Could it be, that you missed to fix / clean something up here? > > Thanks, > Stefan yes, will correct this and re-post. Regards, Oza.