From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751707AbdFIMxU (ORCPT ); Fri, 9 Jun 2017 08:53:20 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:44541 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbdFIMxT (ORCPT ); Fri, 9 Jun 2017 08:53:19 -0400 Subject: Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY To: Mark Yao References: CC: , , Kieran Bingham , Laurent Pinchart , Archit Taneja , Andrzej Hajda , "Carlos Palminha" From: Jose Abreu Message-ID: <6071fd12-2cda-cd1f-2607-9a498f588040@synopsys.com> Date: Fri, 9 Jun 2017 13:53:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.59] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 09-06-2017 12:04, Jose Abreu wrote: > Currently HDMI 2.0 PHYs do not have a default configuration function. > > As these PHYs have the same register layout as the 3D PHYs we can > safely use the default configuration function. I may have been a little to fast arriving at this conclusion. I mean most of the registers match but in the configuration function there are registers that do not match. Did you actually test this configuration function with an HDMI 2.0 phy? And did you test with different video modes? From my experience the phy may be wrongly configured and sometimes work anyway. Do please retest with as many video modes as you can and give me your phy ID (read from controller config reg HDMI_CONFIG2_ID). Best regards, Jose Miguel Abreu > If, for some reason, > the PHY is custom this change will not make any impact because > in configuration function we prefer the pdata provided configuration > function over the internal one. > > This patch is based on today's drm-misc-next branch. > > Signed-off-by: Jose Abreu > Cc: Kieran Bingham > Cc: Laurent Pinchart > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Mark Yao > Cc: Carlos Palminha > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index ead1124..10c8d8c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2170,6 +2170,7 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_id) > .name = "DWC HDMI 2.0 TX PHY", > .gen = 2, > .has_svsret = true, > + .configure = hdmi_phy_configure_dwc_hdmi_3d_tx, > }, { > .type = DW_HDMI_PHY_VENDOR_PHY, > .name = "Vendor PHY", From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jose Abreu Subject: Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY Date: Fri, 9 Jun 2017 13:53:12 +0100 Message-ID: <6071fd12-2cda-cd1f-2607-9a498f588040@synopsys.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Mark Yao Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kieran Bingham , Laurent Pinchart , Archit Taneja , Andrzej Hajda , Carlos Palminha List-Id: dri-devel@lists.freedesktop.org Hi Mark, On 09-06-2017 12:04, Jose Abreu wrote: > Currently HDMI 2.0 PHYs do not have a default configuration function. > > As these PHYs have the same register layout as the 3D PHYs we can > safely use the default configuration function. I may have been a little to fast arriving at this conclusion. I mean most of the registers match but in the configuration function there are registers that do not match. Did you actually test this configuration function with an HDMI 2.0 phy? And did you test with different video modes? From my experience the phy may be wrongly configured and sometimes work anyway. Do please retest with as many video modes as you can and give me your phy ID (read from controller config reg HDMI_CONFIG2_ID). Best regards, Jose Miguel Abreu > If, for some reason, > the PHY is custom this change will not make any impact because > in configuration function we prefer the pdata provided configuration > function over the internal one. > > This patch is based on today's drm-misc-next branch. > > Signed-off-by: Jose Abreu > Cc: Kieran Bingham > Cc: Laurent Pinchart > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Mark Yao > Cc: Carlos Palminha > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index ead1124..10c8d8c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2170,6 +2170,7 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_id) > .name = "DWC HDMI 2.0 TX PHY", > .gen = 2, > .has_svsret = true, > + .configure = hdmi_phy_configure_dwc_hdmi_3d_tx, > }, { > .type = DW_HDMI_PHY_VENDOR_PHY, > .name = "Vendor PHY",