From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA490C433EF for ; Fri, 14 Jan 2022 13:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbiANNok (ORCPT ); Fri, 14 Jan 2022 08:44:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30595 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241425AbiANNoh (ORCPT ); Fri, 14 Jan 2022 08:44:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642167877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=eSlalJItA1fAVeZ4lPifC1zKADSLB1XFI24QmLbj/CORxM2iHCkLA/C9iltecnBJ2jvxbV iJ7kVrleBjitaKDkAL+9D7B2XjeuUNWqmSLgOZ4WsU+N/XTLkihUEiQ4q/ogWLOqzu9gze seFz3ufpxA2CKQ+kvZU75+eYUTRf7Es= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-202-QSY6WpR3MViWiHuHd4mlHw-1; Fri, 14 Jan 2022 08:44:35 -0500 X-MC-Unique: QSY6WpR3MViWiHuHd4mlHw-1 Received: by mail-ed1-f70.google.com with SMTP id y18-20020a056402271200b003fa16a5debcso8382208edd.14 for ; Fri, 14 Jan 2022 05:44:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=LXPZ0oEUyW6Yu9xQawMdaj/nIm5V+/dSQQtEqOmG0fSWsqRRwRDAm/H1DOZ36wVjEk 0QInC7oFONgUMu0NwUpODQ8zNliL6281U28dwLw2eDm4g2QOwRq3lHDwAyPOPvB7ARSL TEBKV7hbTGSR5PFGN1VDy5H42q3Nm3c8OGdH4LIm+sMLMKeFnnb9ucU+2sYg3b7I3Kn2 hoVchZz7XNdpqlEuCkd4Je6g0zbkxO3k8iYBKo80law2eaEXJmmi6s1CmAdLr63ZOowj /G3Fbm3Giptap1xx9wcFmTytL/QXsd48e0Wt8Iwpnnn1wXsTR6z4oShiGT2JJdoZ8QL8 AF5w== X-Gm-Message-State: AOAM533MkEvpNE2Cau/2XGrjvZVLp6Q5tnDvuted+tMx2khcfK7sNyML FBgtYDYjhJFF5ROQBxPwBZicSPi7UyRC2JZfuJn/MIN9OVRCpUMujtQ1XhUMteTdjdIBDe3cX0z gAF+19nOolRYDJ7k5jngCx7nc X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115180edu.114.1642167874594; Fri, 14 Jan 2022 05:44:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5OFak9AC/l+A6gU6QqTI2K9zWFX8t7yOZXV50BOSN3qj9pr1cdJHhBXdsT7LCgDNpLjpiDw== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115163edu.114.1642167874354; Fri, 14 Jan 2022 05:44:34 -0800 (PST) Received: from ?IPV6:2003:cb:c701:9d00:ff87:1c9b:108a:9702? (p200300cbc7019d00ff871c9b108a9702.dip0.t-ipconnect.de. [2003:cb:c701:9d00:ff87:1c9b:108a:9702]) by smtp.gmail.com with ESMTPSA id 10sm1861145ejy.174.2022.01.14.05.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 05:44:33 -0800 (PST) Message-ID: <60778775-b5f5-0837-092f-9911cec84854@redhat.com> Date: Fri, 14 Jan 2022 14:44:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size. Content-Language: en-US To: Zi Yan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Marek Szyprowski , Robin Murphy , linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Vlastimil Babka , Mel Gorman , Eric Ren References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-8-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220105214756.91065-8-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_contig_range() now only needs to be aligned to pageblock_order, > drop virtio_mem size requirement that it needs to be the max of > pageblock_order and MAX_ORDER. > > Signed-off-by: Zi Yan > --- > drivers/virtio/virtio_mem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index a6a78685cfbe..2664dc16d0f9 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -2481,8 +2481,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) > * - Is required for now for alloc_contig_range() to work reliably - > * it doesn't properly handle smaller granularity on ZONE_NORMAL. > */ Please also update this comment. -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E968FC433FE for ; Fri, 14 Jan 2022 13:44:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6A08A4051D; Fri, 14 Jan 2022 13:44:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6dkarbiobl9v; Fri, 14 Jan 2022 13:44:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 16627402EB; Fri, 14 Jan 2022 13:44:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5426C002F; Fri, 14 Jan 2022 13:44:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id D0B05C001E for ; Fri, 14 Jan 2022 13:44:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BD7BB40500 for ; Fri, 14 Jan 2022 13:44:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xhbBS6b5X3aT for ; Fri, 14 Jan 2022 13:44:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 026A3402EB for ; Fri, 14 Jan 2022 13:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642167876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=EoNGWjaU2GFwo1XS2eOlMsTulLpubFLWni/ldxfyuZtnP/7YK8aG9QOo2+bbK7RGxDH5HM WxyE6sKLZ0tfiZ1G8VXJu54mveDa0j0AwbUIL1JyPjONCS/viwwgEPVGwKDGs+m7wemLam ++rKVt2FPuRuRfgGD733DuLjo286Q0k= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-100-O8ecglIhNxacYFIF7JRdlA-1; Fri, 14 Jan 2022 08:44:35 -0500 X-MC-Unique: O8ecglIhNxacYFIF7JRdlA-1 Received: by mail-ed1-f70.google.com with SMTP id v18-20020a056402349200b003f8d3b7ee8dso8367960edc.23 for ; Fri, 14 Jan 2022 05:44:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=ogdk/WuzMEYyNMKuxVIC7Gmz2ZRFzZE0P6JtnGhgqCDwLSlHJaTw/yMKc6IsxTS3XG 7FHAPAeCoXE0nV9pJ44yR8FY9LJcSFhSfnnfwF1dy3wzM6/5Op90RXzlwv4UBJCtq9bf YndBfisFoI94kSVBFVNe7Zaql3WA1fQ+zUkS9+IhDfKjDyAI6Rh5ysCBnLM2hitIcKUZ GTZtDTq/ivue4jKoaz6eIakNJCxWBUQAPELv8xKshs9832wQdkoSY3Yu3tGA/yp3tLuK e4CrNjThwJt0BwtmfbAxHBC808QipGuBErg3mBD0je2cg8PnjFJNz1PRNyYnlckJecw4 LohA== X-Gm-Message-State: AOAM53358MwNGfq8mszbUB6ZqZsJblHbc0J+k+1AP8/aFDYVJdZ9y6NG ATcdY0s8jd/ONj24bIOQkPAwX3cuBrmBAxBR0EOT2QQYDsFAEXa7H3sffm2ORdUdB7iCKCLyBxJ Llr0QJRL/kq3VGYUvN3yla6fj7VQr+g== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115182edu.114.1642167874595; Fri, 14 Jan 2022 05:44:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5OFak9AC/l+A6gU6QqTI2K9zWFX8t7yOZXV50BOSN3qj9pr1cdJHhBXdsT7LCgDNpLjpiDw== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115163edu.114.1642167874354; Fri, 14 Jan 2022 05:44:34 -0800 (PST) Received: from ?IPV6:2003:cb:c701:9d00:ff87:1c9b:108a:9702? (p200300cbc7019d00ff871c9b108a9702.dip0.t-ipconnect.de. [2003:cb:c701:9d00:ff87:1c9b:108a:9702]) by smtp.gmail.com with ESMTPSA id 10sm1861145ejy.174.2022.01.14.05.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 05:44:33 -0800 (PST) Message-ID: <60778775-b5f5-0837-092f-9911cec84854@redhat.com> Date: Fri, 14 Jan 2022 14:44:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size. To: Zi Yan , linux-mm@kvack.org References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-8-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220105214756.91065-8-zi.yan@sent.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Mel Gorman , Michael Ellerman , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Eric Ren , virtualization@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , Vlastimil Babka X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_contig_range() now only needs to be aligned to pageblock_order, > drop virtio_mem size requirement that it needs to be the max of > pageblock_order and MAX_ORDER. > > Signed-off-by: Zi Yan > --- > drivers/virtio/virtio_mem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index a6a78685cfbe..2664dc16d0f9 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -2481,8 +2481,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) > * - Is required for now for alloc_contig_range() to work reliably - > * it doesn't properly handle smaller granularity on ZONE_NORMAL. > */ Please also update this comment. -- Thanks, David / dhildenb _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C183C433F5 for ; Fri, 14 Jan 2022 13:44:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0024860F35; Fri, 14 Jan 2022 13:44:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mZoI88vY0ouw; Fri, 14 Jan 2022 13:44:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id A846960B56; Fri, 14 Jan 2022 13:44:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2C549C0072; Fri, 14 Jan 2022 13:44:41 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 84E06C001E for ; Fri, 14 Jan 2022 13:44:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7F9FC402EB for ; Fri, 14 Jan 2022 13:44:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ckbQDveAr-6N for ; Fri, 14 Jan 2022 13:44:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 63841404FD for ; Fri, 14 Jan 2022 13:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642167877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=eSlalJItA1fAVeZ4lPifC1zKADSLB1XFI24QmLbj/CORxM2iHCkLA/C9iltecnBJ2jvxbV iJ7kVrleBjitaKDkAL+9D7B2XjeuUNWqmSLgOZ4WsU+N/XTLkihUEiQ4q/ogWLOqzu9gze seFz3ufpxA2CKQ+kvZU75+eYUTRf7Es= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-149-sJMrKaoiPoqGhj_ZBvTqXw-1; Fri, 14 Jan 2022 08:44:36 -0500 X-MC-Unique: sJMrKaoiPoqGhj_ZBvTqXw-1 Received: by mail-ed1-f72.google.com with SMTP id m8-20020a056402510800b003f9d22c4d48so8370186edd.21 for ; Fri, 14 Jan 2022 05:44:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=avZOTaNihsjEsOtasP2xvLySnE52QT1wSad3Br3lyll7h406FUdk13Uaca1rhvtcme HmjGjoc8SBzsOI5hRt/zC75HKudDlB88k9W5kpQ/IlS/oL9G10hmBM7zQP0kVTHKinv1 iTRjatyuJfOmdJN1JhOGl+8Zrsoz9w0pYNc1h3whGhXaURs1N4xAOnwhWU9wtOkgZHu7 gQ9xjLEej0Rt3XMIsfzGUAF8ZC2RaOHdkgtFQNh+QHhc/JKeCID3eY6+17rJqCBFPMpn DFLvGrMhWzJZ8oprOkAVi8KfThISKFquXXTLbrhCfFnn+t6D25tdlynDw8/mo/RZhwz0 bPYw== X-Gm-Message-State: AOAM532Z223b18VbzahR4zUT5xCYogQyeQDngF+t+s3kP7t+auAMljUX vRSPXxAaQ7oao9+9pZG7+XdNYcOYWiQRXAN+Ij40bxvDSF6prMtGXnSuUmguTYqiSXRz76FBaB/ Y2BDGKEx8/Lpr4AK2+NB/NOGJdEnLziY8EtXuee788Q== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115183edu.114.1642167874595; Fri, 14 Jan 2022 05:44:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5OFak9AC/l+A6gU6QqTI2K9zWFX8t7yOZXV50BOSN3qj9pr1cdJHhBXdsT7LCgDNpLjpiDw== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115163edu.114.1642167874354; Fri, 14 Jan 2022 05:44:34 -0800 (PST) Received: from ?IPV6:2003:cb:c701:9d00:ff87:1c9b:108a:9702? (p200300cbc7019d00ff871c9b108a9702.dip0.t-ipconnect.de. [2003:cb:c701:9d00:ff87:1c9b:108a:9702]) by smtp.gmail.com with ESMTPSA id 10sm1861145ejy.174.2022.01.14.05.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 05:44:33 -0800 (PST) Message-ID: <60778775-b5f5-0837-092f-9911cec84854@redhat.com> Date: Fri, 14 Jan 2022 14:44:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size. To: Zi Yan , linux-mm@kvack.org References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-8-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220105214756.91065-8-zi.yan@sent.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Mel Gorman , Michael Ellerman , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Eric Ren , virtualization@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , Vlastimil Babka , Marek Szyprowski X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_contig_range() now only needs to be aligned to pageblock_order, > drop virtio_mem size requirement that it needs to be the max of > pageblock_order and MAX_ORDER. > > Signed-off-by: Zi Yan > --- > drivers/virtio/virtio_mem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index a6a78685cfbe..2664dc16d0f9 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -2481,8 +2481,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) > * - Is required for now for alloc_contig_range() to work reliably - > * it doesn't properly handle smaller granularity on ZONE_NORMAL. > */ Please also update this comment. -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37A89C433EF for ; Fri, 14 Jan 2022 13:45:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jb2cM3WtNz30hR for ; Sat, 15 Jan 2022 00:45:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eSlalJIt; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eSlalJIt; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eSlalJIt; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eSlalJIt; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jb2bY5Jv8z2yLy for ; Sat, 15 Jan 2022 00:44:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642167877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=eSlalJItA1fAVeZ4lPifC1zKADSLB1XFI24QmLbj/CORxM2iHCkLA/C9iltecnBJ2jvxbV iJ7kVrleBjitaKDkAL+9D7B2XjeuUNWqmSLgOZ4WsU+N/XTLkihUEiQ4q/ogWLOqzu9gze seFz3ufpxA2CKQ+kvZU75+eYUTRf7Es= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642167877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=eSlalJItA1fAVeZ4lPifC1zKADSLB1XFI24QmLbj/CORxM2iHCkLA/C9iltecnBJ2jvxbV iJ7kVrleBjitaKDkAL+9D7B2XjeuUNWqmSLgOZ4WsU+N/XTLkihUEiQ4q/ogWLOqzu9gze seFz3ufpxA2CKQ+kvZU75+eYUTRf7Es= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-LEzT3HmCNYKgBvVakAK6Ww-1; Fri, 14 Jan 2022 08:44:35 -0500 X-MC-Unique: LEzT3HmCNYKgBvVakAK6Ww-1 Received: by mail-ed1-f71.google.com with SMTP id t11-20020aa7d70b000000b004017521782dso854258edq.19 for ; Fri, 14 Jan 2022 05:44:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=vR4b+iVKP1IWM3wMpG042AeWgp7pu1EG+1jQTlxFOwNeKGNN53Qc3MiLTt9VgBbD14 PKdMUHPh22SN2qHZPhysNygiCk/YF+GyhCR+4NCDymX89+P00wT/6dp+2AMd8j31iusI QKr9WN63zFHKv0K0AaD538ufwlmHc9aDrwC7PAwKrxyVnZCiukt2FSAeU0puEf7W68V1 BiublEQGBqQ/lQWsIViMqaji6MihSY4DfrDeXztyxGZUVMfpgAe1H42zIWscnOlNDEVc ohxIycvAD5InVfzg4wgwIllnRnaA3Eqny1+t20FcDeScU1QidsUf3QMFy3EbyOus8pNG YC1w== X-Gm-Message-State: AOAM532fgCwQPipnTG50GZRMC3Flkh+nRqUIwbYjRkxpuJf4oxVX2+FL 7WQXzlVSJXWHc5nlLvJYRAWX40XWFNqJxyfv2emvyEH3/OwprSYQQ0bIfEnDS3HcErvFldJwrwv Thrc1veNaTJUsIXLad28KNZTJug== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115185edu.114.1642167874595; Fri, 14 Jan 2022 05:44:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5OFak9AC/l+A6gU6QqTI2K9zWFX8t7yOZXV50BOSN3qj9pr1cdJHhBXdsT7LCgDNpLjpiDw== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115163edu.114.1642167874354; Fri, 14 Jan 2022 05:44:34 -0800 (PST) Received: from ?IPV6:2003:cb:c701:9d00:ff87:1c9b:108a:9702? (p200300cbc7019d00ff871c9b108a9702.dip0.t-ipconnect.de. [2003:cb:c701:9d00:ff87:1c9b:108a:9702]) by smtp.gmail.com with ESMTPSA id 10sm1861145ejy.174.2022.01.14.05.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 05:44:33 -0800 (PST) Message-ID: <60778775-b5f5-0837-092f-9911cec84854@redhat.com> Date: Fri, 14 Jan 2022 14:44:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size. To: Zi Yan , linux-mm@kvack.org References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-8-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220105214756.91065-8-zi.yan@sent.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mel Gorman , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Eric Ren , virtualization@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , Vlastimil Babka , Marek Szyprowski Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_contig_range() now only needs to be aligned to pageblock_order, > drop virtio_mem size requirement that it needs to be the max of > pageblock_order and MAX_ORDER. > > Signed-off-by: Zi Yan > --- > drivers/virtio/virtio_mem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index a6a78685cfbe..2664dc16d0f9 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -2481,8 +2481,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) > * - Is required for now for alloc_contig_range() to work reliably - > * it doesn't properly handle smaller granularity on ZONE_NORMAL. > */ Please also update this comment. -- Thanks, David / dhildenb