Re: [PATCH v2 11/12] rockchip: lion-rk3368: migrate to u-boot-rockchip.bin

From: Kever Yang <kever.yang@rock-chips.com>
To: quentin.schulz@theobroma-systems.com,
	Quentin Schulz <foss+uboot@0leil.net>,
	sjg@chromium.org, philipp.tomsich@vrull.eu,
	klaus.goger@theobroma-systems.com, knaerzche@gmail.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH v2 11/12] rockchip: lion-rk3368: migrate to u-boot-rockchip.bin
Date: Fri, 21 Oct 2022 09:14:45 +0800	[thread overview]
Message-ID: <60853090-42d6-02f3-b637-e3c6d3934486@rock-chips.com> (raw)
In-Reply-To: <224775e4-d2da-f5cf-087c-7570154f0bf0@theobroma-systems.com>

On 2022/10/19 22:10, quentin.schulz@theobroma-systems.com wrote:
> Hi Kever,
>
> On 10/19/22 2:47 PM, Kever Yang <kever.yang@rock-chips.com> wrote:
>> Hi Quentin,
>>
>>      This is report by the  denx ci system:
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__source.denx.de_u-2Dboot_custodians_u-2Dboot-2Drockchip_-2D_jobs_515913&d=DwIDaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=jlsoDVbl-1nmumJr2buEbP1CHgfZWWOLR9Xh-ycxj-II1AQbLWozSLgCKBSYz-3o&s=dMfyQSyv3NY0elXedC3GxMELp8oSMp8hCy5WZniPV2U&e= 
>>
>
> I cannot see this page, probably a custodian account on that gitlab 
> instance is required?
>
>>      And I can reproduce it with buildman sheep-rk3568
>>
>
> I can reproduce by building for sheep-3368_defconfig indeed.
>
> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR is not defined for this board 
> and it is used in the lion dts.
>
> Since the Lion dts is built for any RK3368-based board, it needs to be 
> defined for all boards based on RK3368 which is not the case for the 
> Sheep board.

The lion dts is only used for this board, the sheep board have its own 
dts, I didn't see any sheep dts include lion dts, but it's strange why 
the sheep-rk3368 fail with lion change.

>
> Was it a deliberate choice to build all DTS from a specific SoC, 
> whatever the board you're building for?
>
> I would have imagined that using CONFIG_TARGET_LION_RK3368 instead of 
> CONFIG_ROCKCHIP_RK3368 in arch/arm/dts/Makefile for deciding whether 
> to build a device tree would make more sense?
>
> For the time being, please just drop this patch, we don't really need 
> it at the moment so I'll have a look on how to do this properly when I 
> have time.

OK, you  can send the follow up patch if we figure out the reason.

Thanks,

- Kever

>
> Thanks!
> Quentin
>
>>
>> Thanks,
>>
>> - Kever
>>
>> On 2022/10/19 20:11, Quentin Schulz wrote:
>> > Hi Kever,
>> >
>> > On 10/19/22 13:28, Kever Yang wrote:
>> >> Hi Quentin,
>> >>
>> >>      I got below error when apply this patch, could you help to check
>> >>
>> >> +Error: arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi:44.16-17 
>> syntax >> error
>> >> +FATAL ERROR: Unable to parse input tree
>> >> +make[3]: *** [arch/arm/dts/rk3368-lion-haikou.dtb] Error 1
>> >> +make[2]: *** [arch-dtbs] Error 2
>> >>
>> >
>> > Did you run make lion-rk3368_defconfig before trying to compile the 
>> DTS?
>> >
>> > I ran:
>> > ```
>> > git checkout 3724ddf157
>> > b4 shazam --add-link --add-my-sob > 
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_u-2Dboot_20220915091432.789294-2D1-2Dfoss-2Buboot-400leil.net_&d=DwIDaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=jlsoDVbl-1nmumJr2buEbP1CHgfZWWOLR9Xh-ycxj-II1AQbLWozSLgCKBSYz-3o&s=lpPi8rny7_X2xST4eJ40go_Uv41ZYqpuCeU46CpJCz4&e= 
>> make CROSS_COMPILE="ccache aarch64-linux-gnu-" lion-rk3368_defconfig
>> > make CROSS_COMPILE="ccache aarch64-linux-gnu-" j`nproc`
>> > ```
>> > and it compiled without any problem.
>> >
>> > Cheers,
>> > Quentin
>>