From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9897AC33CB1 for ; Thu, 16 Jan 2020 06:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18C982087E for ; Thu, 16 Jan 2020 06:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="qf3BehJP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbgAPGzL (ORCPT ); Thu, 16 Jan 2020 01:55:11 -0500 Received: from mo4-p03-ob.smtp.rzone.de ([85.215.255.103]:23013 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbgAPGzL (ORCPT ); Thu, 16 Jan 2020 01:55:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1579157709; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=TuMGu6eCqVUYEoh3TD5lXbSvO6CM/wB9pqQh/ZoBuBY=; b=qf3BehJPpMWMEjAwpc96RMiqDWboEbHi5clMZpC1MST7Yg7oy0iKqTHNK1+9TZyGu/ Hlq9sTs1Li8OBhaQfdEmXDl+zsKtgwHB3k0/g5UPxsWqw0lnt1GYcPtAIe6qIPL6mukG /q4KHUWWqOc1CTaclppIc44Q+NX/91zxdGoUh21ahTYFRfchJzQoip8QcOKMI37YbHMb m1tqcxd20sOGvC8YkaGD6ROPzIytEUOqD0+T1umh1MhgTEdFkdFl/qE8vDrtEt2sE3Qk 1E3r06Yw4kYSdh75YysZ0/YWIkpN0eBsVqkD9kn/yd3zcXpcMnylJm7QSkEEh1SZCDgI qbUw== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXPZJPScHivh" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 46.1.4 DYNA|AUTH) with ESMTPSA id u04585w0G6s1aB2 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 16 Jan 2020 07:54:01 +0100 (CET) From: Stephan Mueller To: Randy Dunlap Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman , Julia Lawall , Dan Carpenter Subject: Re: [PATCH v28 07/12] LRNG - add kernel crypto API PRNG extension Date: Thu, 16 Jan 2020 07:54:00 +0100 Message-ID: <6088699.12EYreDE7o@tauon.chronox.de> In-Reply-To: References: <6157374.ptSnyUpaCn@positron.chronox.de> <526421170.FD02tCEzJt@positron.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Donnerstag, 16. Januar 2020, 01:15:46 CET schrieb Randy Dunlap: Hi Randy, > On 1/15/20 2:34 AM, Stephan M=FCller wrote: > > CC: "Eric W. Biederman" > > CC: "Alexander E. Patrakov" > > CC: "Ahmed S. Darwish" > > CC: "Theodore Y. Ts'o" > > CC: Willy Tarreau > > CC: Matthew Garrett > > CC: Vito Caputo > > CC: Andreas Dilger > > CC: Jan Kara > > CC: Ray Strode > > CC: William Jon McCann > > CC: zhangjs > > CC: Andy Lutomirski > > CC: Florian Weimer > > CC: Lennart Poettering > > CC: Nicolai Stange > > Reviewed-by: Marcelo Henrique Cerri > > Reviewed-by: Roman Drahtmueller > > Tested-by: Roman Drahtm=FCller > > Tested-by: Marcelo Henrique Cerri > > Tested-by: Neil Horman > > Signed-off-by: Stephan Mueller > > --- > >=20 > > drivers/char/lrng/Kconfig | 10 + > > drivers/char/lrng/Makefile | 1 + > > drivers/char/lrng/lrng_kcapi.c | 327 +++++++++++++++++++++++++++++++++ > > 3 files changed, 338 insertions(+) > > create mode 100644 drivers/char/lrng/lrng_kcapi.c > >=20 > > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig > > index 15fb623d9d1f..0d070a3897dd 100644 > > --- a/drivers/char/lrng/Kconfig > > +++ b/drivers/char/lrng/Kconfig > > @@ -80,6 +80,16 @@ config LRNG_DRBG > >=20 > > Enable the SP800-90A DRBG support for the LRNG. Once the > > module is loaded, output from /dev/random, /dev/urandom, > > getrandom(2), or get_random_bytes is provided by a DRBG. > >=20 > > + > > +config LRNG_KCAPI > > + tristate "Kernel Crypto API support for the LRNG" > > + select CRYPTO_RNG >=20 > Don't select CRYPTO_RNG unless you know that CRYPTO is set/enabled. I added "depends on CRYPTO" >=20 > > + help > > + Enable the support for generic pseudo-random number > > + generators offered by the kernel crypto API with the > > + LRNG. Once the module is loaded, output from /dev/random, > > + /dev/urandom, getrandom(2), or get_random_bytes is > > + provided by the selected kernel crypto API RNG. > >=20 > > endif # LRNG_DRNG_SWITCH > > =20 > > endif # LRNG Thank you. Ciao Stephan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Mueller Subject: Re: [PATCH v28 07/12] LRNG - add kernel crypto API PRNG extension Date: Thu, 16 Jan 2020 07:54:00 +0100 Message-ID: <6088699.12EYreDE7o@tauon.chronox.de> References: <6157374.ptSnyUpaCn@positron.chronox.de> <526421170.FD02tCEzJt@positron.chronox.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange List-Id: linux-api@vger.kernel.org Am Donnerstag, 16. Januar 2020, 01:15:46 CET schrieb Randy Dunlap: Hi Randy, > On 1/15/20 2:34 AM, Stephan M=FCller wrote: > > CC: "Eric W. Biederman" > > CC: "Alexander E. Patrakov" > > CC: "Ahmed S. Darwish" > > CC: "Theodore Y. Ts'o" > > CC: Willy Tarreau > > CC: Matthew Garrett > > CC: Vito Caputo > > CC: Andreas Dilger > > CC: Jan Kara > > CC: Ray Strode > > CC: William Jon McCann > > CC: zhangjs > > CC: Andy Lutomirski > > CC: Florian Weimer > > CC: Lennart Poettering > > CC: Nicolai Stange > > Reviewed-by: Marcelo Henrique Cerri > > Reviewed-by: Roman Drahtmueller > > Tested-by: Roman Drahtm=FCller > > Tested-by: Marcelo Henrique Cerri > > Tested-by: Neil Horman > > Signed-off-by: Stephan Mueller > > --- > >=20 > > drivers/char/lrng/Kconfig | 10 + > > drivers/char/lrng/Makefile | 1 + > > drivers/char/lrng/lrng_kcapi.c | 327 +++++++++++++++++++++++++++++++++ > > 3 files changed, 338 insertions(+) > > create mode 100644 drivers/char/lrng/lrng_kcapi.c > >=20 > > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig > > index 15fb623d9d1f..0d070a3897dd 100644 > > --- a/drivers/char/lrng/Kconfig > > +++ b/drivers/char/lrng/Kconfig > > @@ -80,6 +80,16 @@ config LRNG_DRBG > >=20 > > Enable the SP800-90A DRBG support for the LRNG. Once the > > module is loaded, output from /dev/random, /dev/urandom, > > getrandom(2), or get_random_bytes is provided by a DRBG. > >=20 > > + > > +config LRNG_KCAPI > > + tristate "Kernel Crypto API support for the LRNG" > > + select CRYPTO_RNG >=20 > Don't select CRYPTO_RNG unless you know that CRYPTO is set/enabled. I added "depends on CRYPTO" >=20 > > + help > > + Enable the support for generic pseudo-random number > > + generators offered by the kernel crypto API with the > > + LRNG. Once the module is loaded, output from /dev/random, > > + /dev/urandom, getrandom(2), or get_random_bytes is > > + provided by the selected kernel crypto API RNG. > >=20 > > endif # LRNG_DRNG_SWITCH > > =20 > > endif # LRNG Thank you. Ciao Stephan