From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AF4C433B4 for ; Wed, 5 May 2021 12:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D04161222 for ; Wed, 5 May 2021 12:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbhEEMSr (ORCPT ); Wed, 5 May 2021 08:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233365AbhEEMSC (ORCPT ); Wed, 5 May 2021 08:18:02 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD3C5C06134B for ; Wed, 5 May 2021 05:16:00 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id e2so1538194ilr.1 for ; Wed, 05 May 2021 05:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oqHb4rjlMXWPPEjHYTDBWNoZCPN0FDRJBPayCdf1+gU=; b=fC7moJwcexh5klTQU/Qos20CANVJQ0wGYXAyuhaEW/+cMXKHVVnTTnZA1B4VEz51rd CrfH126WMYAtoySakuXD+4WU2iaTZNuWIGHXwdV183CJw/dqRPLFvIFgmvOpFzmcfyT+ FmiDzIYBHig8WTHjxscb43F5miqoZECfetDxI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oqHb4rjlMXWPPEjHYTDBWNoZCPN0FDRJBPayCdf1+gU=; b=cevGfoBWcw71hepqPBOeAZVfyTuIir4YH3+AiG7i/UWCYacdv3smytpqlI8Z3VDDX+ Ys8wH3YwjZqKkdDYXIEOikYNGACAG/O9wT9OLW/peaEXSclAlj8UWcDhmmxWVQLc7g9E WU8yr9hVgQkgy1O168YB4JObGQMgDM5jYfqJ+lohIqcSlkI/Dz+DLMDbUsw8QOq+FND2 TwgKK0DyDNC3F/JKz6+wlpUZUZWKteBJnoHauSDJ2B5D+3yGYmihCjU87MvpVSW4+1XY pwzhIp2l8BlJ9etiEZRduTYgQ/0uDAQTpBTI+VYRvTljnfgYLdj8to+3moSB0mce6G6M QzTg== X-Gm-Message-State: AOAM533NYcYYPqgiOD3Ko98Tg8BxpJ2KF9q/DfeWsPWK/5a0u6yN0Ifl UV626JLAdBGFEYIXiE8AeoToVA== X-Google-Smtp-Source: ABdhPJzNiPFgzrMBLiHXKIJhn5JVROoYmNooEJpyd7zASOShC5srtlvUOLaoqzdp8ODmKU3x1bXjIw== X-Received: by 2002:a05:6e02:969:: with SMTP id q9mr14743719ilt.285.1620216960210; Wed, 05 May 2021 05:16:00 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id 6sm2446098iog.36.2021.05.05.05.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 05:15:59 -0700 (PDT) Subject: Re: [PATCH 22/35] tty: make tty_operations::write_room return uint To: Jiri Slaby , gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Geert Uytterhoeven , "James E.J. Bottomley" , Helge Deller , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Max Filippov , Arnd Bergmann , Samuel Iglesias Gonsalvez , Jens Taprogge , Karsten Keil , Scott Branden , Ulf Hansson , "David S. Miller" , Jakub Kicinski , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , David Lin , Johan Hovold , Alex Elder , Laurentiu Tudor , Jiri Kosina , David Sterba , Shawn Guo , Sascha Hauer , Oliver Neukum , Felipe Balbi , Mathias Nyman , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz References: <20210505091928.22010-1-jslaby@suse.cz> <20210505091928.22010-23-jslaby@suse.cz> From: Alex Elder Message-ID: <608f186f-0c88-1a5d-e612-7f133476f1e3@ieee.org> Date: Wed, 5 May 2021 07:15:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210505091928.22010-23-jslaby@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/21 4:19 AM, Jiri Slaby wrote: > Line disciplines expect a positive value or zero returned from > tty->ops->write_room (invoked by tty_write_room). So make this > assumption explicit by using unsigned int as a return value. Both of > tty->ops->write_room and tty_write_room. > > Signed-off-by: Jiri Slaby > Cc: Richard Henderson > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: Geert Uytterhoeven > Cc: "James E.J. Bottomley" > Cc: Helge Deller > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Chris Zankel > Cc: Max Filippov > Cc: Arnd Bergmann > Cc: Samuel Iglesias Gonsalvez > Cc: Jens Taprogge > Cc: Karsten Keil > Cc: Scott Branden > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: David Lin > Cc: Johan Hovold > Cc: Alex Elder > Cc: Laurentiu Tudor > Cc: Jiri Kosina > Cc: David Sterba > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Oliver Neukum > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Marcel Holtmann > Cc: Johan Hedberg > Cc: Luiz Augusto von Dentz > --- > arch/alpha/kernel/srmcons.c | 2 +- > arch/m68k/emu/nfcon.c | 2 +- > arch/parisc/kernel/pdc_cons.c | 2 +- > arch/um/drivers/line.c | 6 +++--- > arch/um/drivers/line.h | 2 +- > arch/xtensa/platforms/iss/console.c | 2 +- > drivers/char/pcmcia/synclink_cs.c | 2 +- > drivers/char/ttyprintk.c | 2 +- > drivers/ipack/devices/ipoctal.c | 2 +- > drivers/isdn/capi/capi.c | 6 +++--- > drivers/misc/bcm-vk/bcm_vk_tty.c | 2 +- > drivers/mmc/core/sdio_uart.c | 2 +- > drivers/net/usb/hso.c | 4 ++-- > drivers/s390/char/con3215.c | 2 +- > drivers/s390/char/sclp_tty.c | 4 ++-- > drivers/s390/char/sclp_vt220.c | 4 ++-- > drivers/s390/char/tty3270.c | 2 +- > drivers/staging/fwserial/fwserial.c | 6 +++--- > drivers/staging/gdm724x/gdm_tty.c | 2 +- > drivers/staging/greybus/uart.c | 2 +- > drivers/tty/amiserial.c | 2 +- > drivers/tty/ehv_bytechan.c | 4 ++-- > drivers/tty/goldfish.c | 2 +- > drivers/tty/hvc/hvc_console.c | 2 +- > drivers/tty/hvc/hvcs.c | 2 +- > drivers/tty/hvc/hvsi.c | 4 ++-- > drivers/tty/ipwireless/tty.c | 2 +- > drivers/tty/mips_ejtag_fdc.c | 4 ++-- > drivers/tty/moxa.c | 8 ++++---- > drivers/tty/mxser.c | 2 +- > drivers/tty/n_gsm.c | 2 +- > drivers/tty/nozomi.c | 4 ++-- > drivers/tty/pty.c | 2 +- > drivers/tty/serial/kgdb_nmi.c | 2 +- > drivers/tty/serial/serial_core.c | 4 ++-- > drivers/tty/synclink_gt.c | 6 +++--- > drivers/tty/tty_ioctl.c | 2 +- > drivers/tty/ttynull.c | 2 +- > drivers/tty/vcc.c | 4 ++-- > drivers/tty/vt/vt.c | 2 +- > drivers/usb/class/cdc-acm.c | 2 +- > drivers/usb/gadget/function/u_serial.c | 6 +++--- > drivers/usb/host/xhci-dbgtty.c | 4 ++-- > drivers/usb/serial/usb-serial.c | 2 +- > include/linux/tty.h | 2 +- > include/linux/tty_driver.h | 4 ++-- > net/bluetooth/rfcomm/tty.c | 2 +- > 47 files changed, 71 insertions(+), 71 deletions(-) . . . Looks good. Acked-by: Alex Elder diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c > index b1e63f7798b0..529eccb99b6c 100644 > --- a/drivers/staging/greybus/uart.c > +++ b/drivers/staging/greybus/uart.c > @@ -440,7 +440,7 @@ static int gb_tty_write(struct tty_struct *tty, const unsigned char *buf, > return count; > } > > -static int gb_tty_write_room(struct tty_struct *tty) > +static unsigned int gb_tty_write_room(struct tty_struct *tty) > { > struct gb_tty *gb_tty = tty->driver_data; > unsigned long flags; . . .