All of lore.kernel.org
 help / color / mirror / Atom feed
From: Auger Eric <eric.auger@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org,
	eric.auger.pro@gmail.com
Subject: Re: [Qemu-devel] [PATCH 2/2] vfio-pci: Use vfio_register_event_notifier in vfio_intx_enable_kvm
Date: Tue, 15 Jan 2019 14:00:53 +0100	[thread overview]
Message-ID: <60925190-3427-3658-012f-033994661379@redhat.com> (raw)
In-Reply-To: <20190115131243.6f8e51b3.cohuck@redhat.com>

Hi Cornelia,

On 1/15/19 1:12 PM, Cornelia Huck wrote:
> On Fri, 11 Jan 2019 17:58:01 +0100
> Eric Auger <eric.auger@redhat.com> wrote:
> 
>> We can also use vfio_register_event_notifier() helper in
>> vfio_intx_enable_kvm to set the signalling associated to
>> VFIO_PCI_INTX_IRQ_INDEX.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>>  hw/vfio/pci.c | 38 +++++++-------------------------------
>>  1 file changed, 7 insertions(+), 31 deletions(-)
>>
> 
>>  static void vfio_intx_disable(VFIOPCIDevice *vdev)
> 
> I'm wondering why the _disable path can't use the new helper. Ordering
> issues?
> 
Yes the interleaving of actions scared me a little bit. I am going to
study this a little bit further ...

Thanks

Eric

  reply	other threads:[~2019-01-15 13:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 16:57 [Qemu-devel] [PATCH 0/2] vfio-pci: Introduce vfio_register_event_notifier() Eric Auger
2019-01-11 16:58 ` [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper Eric Auger
2019-01-15 12:03   ` Cornelia Huck
2019-01-15 13:00     ` Auger Eric
2019-01-17  3:46   ` Alexey Kardashevskiy
2019-01-17  8:59     ` Cornelia Huck
2019-01-17  9:16     ` Auger Eric
2019-01-18  4:14       ` Alexey Kardashevskiy
2019-01-18  9:08         ` Auger Eric
2019-01-18  9:33           ` Cornelia Huck
2019-01-11 16:58 ` [Qemu-devel] [PATCH 2/2] vfio-pci: Use vfio_register_event_notifier in vfio_intx_enable_kvm Eric Auger
2019-01-15 12:12   ` Cornelia Huck
2019-01-15 13:00     ` Auger Eric [this message]
2019-01-17  3:46   ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60925190-3427-3658-012f-033994661379@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.