All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Al Cooper <alcooperx@gmail.com>,
	Jim Quinlan <james.quinlan@broadcom.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>
Cc: Michael Walle <michael@walle.cc>,
	Jon Hunter <jonathanh@nvidia.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Guenter Roeck <linux@roeck-us.net>,
	kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] Revert "Revert "driver core: Set fw_devlink=on by default""
Date: Mon, 26 Apr 2021 13:51:06 -0700	[thread overview]
Message-ID: <60989b90-7f8a-5306-e7d7-c5461bc9ac68@gmail.com> (raw)
In-Reply-To: <20210302211133.2244281-4-saravanak@google.com>

Hi Saravana,

Adding Sudeep and Christian, Al and Jim.

On 3/2/21 1:11 PM, Saravana Kannan wrote:
> This reverts commit 3e4c982f1ce75faf5314477b8da296d2d00919df.
> 
> Since all reported issues due to fw_devlink=on should be addressed by
> this series, revert the revert. fw_devlink=on Take II.
> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>

This change breaks booting on SCMI-based platforms such as ARCH_BRCMSTB.
If I revert this change or boot with fw_devlink=permissive, then our
systems boot again. From a quick look, the SCMI clock provider was never
probed which means that our UART driver never got a chance to get its
clock and we have no console -> timeout.

Al, AFAICT you had started to analyze this before in the context of
SCMI, do you mind sharing what you had found?

Saravana, is there any debugging output that we can help provide?

Thank you!
-- 
Florian

  parent reply	other threads:[~2021-04-26 20:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 21:11 [PATCH v1 0/3] driver core: Set fw_devlink=on take II Saravana Kannan
2021-03-02 21:11 ` [PATCH v1 1/3] driver core: Avoid pointless deferred probe attempts Saravana Kannan
2021-03-09 23:26   ` Saravana Kannan
2021-03-23 13:58     ` Greg Kroah-Hartman
2021-03-02 21:11 ` [PATCH v1 2/3] driver core: Update device link status properly for device_bind_driver() Saravana Kannan
2021-03-12 16:59   ` Jon Hunter
2021-03-02 21:11 ` [PATCH v1 3/3] Revert "Revert "driver core: Set fw_devlink=on by default"" Saravana Kannan
     [not found]   ` <161670714806.3012082.14889556041667946511@swboyd.mtv.corp.google.com>
2021-03-25 21:59     ` Saravana Kannan
2021-04-26 20:51   ` Florian Fainelli [this message]
2021-04-26 21:33     ` Saravana Kannan
2021-04-26 21:47       ` Florian Fainelli
2021-04-27  7:05         ` Geert Uytterhoeven
2021-04-27  7:48         ` Cristian Marussi
     [not found]           ` <CA+-6iNz_kL0DnbRb0A=WSSLK0mnqw35S47TDXq5rhwXL_VWdPg@mail.gmail.com>
2021-04-27 14:11             ` Cristian Marussi
2021-04-27 15:10               ` Sudeep Holla
2021-04-27 16:24                 ` Saravana Kannan
2021-04-27 16:47                   ` Florian Fainelli
2021-04-27 21:05                     ` Saravana Kannan
2021-04-28  8:40                     ` Sudeep Holla
2021-04-27 16:24                 ` Florian Fainelli
2021-04-27 16:28                   ` Saravana Kannan
2021-04-27 16:42                     ` Sudeep Holla
2021-04-27 16:39                   ` Sudeep Holla
2021-04-27 16:50                     ` Florian Fainelli
2021-04-27 17:10                       ` Geert Uytterhoeven
2021-03-02 22:24 ` [PATCH v1 0/3] driver core: Set fw_devlink=on take II Michael Walle
2021-03-02 22:42   ` Saravana Kannan
2021-03-02 22:47     ` Saravana Kannan
2021-03-03  8:59       ` Michael Walle
2021-03-03  9:28         ` Saravana Kannan
2021-03-03 10:21           ` Michael Walle
2021-03-05  3:25             ` Saravana Kannan
2021-03-03  9:22 ` Geert Uytterhoeven
2021-03-03  9:24   ` Saravana Kannan
2021-03-03 10:02     ` Geert Uytterhoeven
2021-03-03 16:55       ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60989b90-7f8a-5306-e7d7-c5461bc9ac68@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alcooperx@gmail.com \
    --cc=cristian.marussi@arm.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.quinlan@broadcom.com \
    --cc=jonathanh@nvidia.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=m.szyprowski@samsung.com \
    --cc=michael@walle.cc \
    --cc=rafael@kernel.org \
    --cc=saravanak@google.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.