From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jastrzebski, MichalX K" <michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 0/6] Link Bonding mode 6 support (ALB)
Date: Thu, 19 Feb 2015 10:14:40 +0000
Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582138EAA30@IRSMSX109.ger.corp.intel.com>
References: <1423840570-6452-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1774392.VK6szrItcK@xps13>
 <60ABE07DBB3A454EB7FAD707B4BB1582138EA984@IRSMSX109.ger.corp.intel.com>
 <1533160.F3kMOSWkDY@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1533160.F3kMOSWkDY@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Thursday, February 19, 2015 10:40 AM
> To: Jastrzebski, MichalX K
> Cc: Doherty, Declan; dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)
>=20
> 2015-02-19 09:18, Jastrzebski, MichalX K:
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > > 2015-02-13 16:12, Declan Doherty:
> > > > On 13/02/15 15:16, Michal Jastrzebski wrote:
> > > > > Michal Jastrzebski (6):
> > > > >    net: changed arp_hdr struct declaration
> > > > >    bond: add link bonding mode 6 implementation
> > > > >    bond: add debug info for mode 6 link bonding
> > > > >    bond: add example application for link bonding mode 6
> > > > >    bond: modify TLB unit tests
> > > > >    bond: add unit tests for link bonding mode 6.
> > >
> > Hi Thomas,
> > > You didn't sign some of these patches. So I suspect that you should
> > > fix some authorship.
> > That's because I am not an author of all of these patches - 1/6, 5/6 an=
d 6/6
>=20
> You probably broke it by importing patches with "patch" command instead o=
f
> "git am".
> Then you must fix the authorship in your git tree before sending.
The authorship in v2 is proper as I think I shouldn't signoff patch that is=
 not mine
-  that I was never working on the code it provides, should I?=20
I edited the patches manually before I submitted it to match the proper aut=
hority,
In git tree I have all patches signed-off by myself by default.
>=20
> > > Some of the patches make some changes without explaining why.
> > I noticed 5/6 has got incomplete description. Probably it disappeared
> during edition.
>=20
> Yes please ask yourself why each patch is done, and check it's explained =
in
> commit log.
>=20
> > > > Series Acked-by: Declan Doherty <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > >
> > > Please, use checkpatch before submitting and/or when reviewing.
> > I was using checkptach.pl, and have no errors, but I will check again.
> > Maybe I overlooked something.
> > >
> > > A v3 is needed.
> >
> > Best regards
> > Michal