From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB5DC47082 for ; Mon, 31 May 2021 18:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 294846127C for ; Mon, 31 May 2021 18:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231569AbhEaSsB (ORCPT ); Mon, 31 May 2021 14:48:01 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:49844 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231680AbhEaSrq (ORCPT ); Mon, 31 May 2021 14:47:46 -0400 Received: from [192.168.1.18] ([86.243.172.93]) by mwinf5d55 with ME id BWm42500321Fzsu03Wm4L1; Mon, 31 May 2021 20:46:05 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 31 May 2021 20:46:05 +0200 X-ME-IP: 86.243.172.93 Subject: Re: [PATCH 5.4 135/177] net: netcp: Fix an error message To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, "David S. Miller" , Sasha Levin , Dan Carpenter References: <20210531130647.887605866@linuxfoundation.org> <20210531130652.606363904@linuxfoundation.org> From: Marion & Christophe JAILLET Message-ID: <60ba11bd-acc0-d48d-ad80-6987847e6e79@wanadoo.fr> Date: Mon, 31 May 2021 20:46:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210531130652.606363904@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 31/05/2021 à 15:14, Greg Kroah-Hartman a écrit : > From: Christophe JAILLET > > [ Upstream commit ddb6e00f8413e885ff826e32521cff7924661de0 ] > > 'ret' is known to be 0 here. > The expected error code is stored in 'tx_pipe->dma_queue', so use it > instead. > > While at it, switch from %d to %pe which is more user friendly. > > Fixes: 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") > Signed-off-by: Christophe JAILLET > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin > --- > drivers/net/ethernet/ti/netcp_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c > index 1b2702f74455..c0025bb8a584 100644 > --- a/drivers/net/ethernet/ti/netcp_core.c > +++ b/drivers/net/ethernet/ti/netcp_core.c > @@ -1350,8 +1350,8 @@ int netcp_txpipe_open(struct netcp_tx_pipe *tx_pipe) > tx_pipe->dma_queue = knav_queue_open(name, tx_pipe->dma_queue_id, > KNAV_QUEUE_SHARED); > if (IS_ERR(tx_pipe->dma_queue)) { > - dev_err(dev, "Could not open DMA queue for channel \"%s\": %d\n", > - name, ret); > + dev_err(dev, "Could not open DMA queue for channel \"%s\": %pe\n", > + name, tx_pipe->dma_queue); > ret = PTR_ERR(tx_pipe->dma_queue); > goto err; > } Hi, Apparently %pe is only supported up to (including) 5.5. It is not part of 5.4.123. So this patch should not be backported here or should be backported differently, ie:    leave dev_err as-is    move "ret = PTR_ERR(tx_pipe->dma_queue);" 1 line above (or %pe should be backported first) PS: adding Dan Carpenter because we had a small discussion about some potential backport issue when, using %pe CJ